Michal Wajdeczko 342fb97892 kunit: Reset test->priv after each param iteration ... If we run parameterized test that uses test->priv to prepare some custom data, then value of test->priv will leak to the next param iteration and may be unexpected. This could be easily seen if we promote example_priv_test to parameterized test as then only first test iteration will be successful: $ ./tools/testing/kunit/kunit.py run \ --kunitconfig ./lib/kunit/.kunitconfig *.example_priv* [ ] Starting KUnit Kernel (1/1)... [ ] ============================================================ [ ] =================== example (1 subtest) ==================== [ ] ==================== example_priv_test ==================== [ ] [PASSED] example value 3 [ ] # example_priv_test: initializing [ ] # example_priv_test: ASSERTION FAILED at lib/kunit/kunit-example-test.c:230 [ ] Expected test->priv == ((void *)0), but [ ] test->priv == 0000000060dfe290 [ ] ((void *)0) == 0000000000000000 [ ] # example_priv_test: cleaning up [ ] [FAILED] example value 2 [ ] # example_priv_test: initializing [ ] # example_priv_test: ASSERTION FAILED at lib/kunit/kunit-example-test.c:230 [ ] Expected test->priv == ((void *)0), but [ ] test->priv == 0000000060dfe290 [ ] ((void *)0) == 0000000000000000 [ ] # example_priv_test: cleaning up [ ] [FAILED] example value 1 [ ] # example_priv_test: initializing [ ] # example_priv_test: ASSERTION FAILED at lib/kunit/kunit-example-test.c:230 [ ] Expected test->priv == ((void *)0), but [ ] test->priv == 0000000060dfe290 [ ] ((void *)0) == 0000000000000000 [ ] # example_priv_test: cleaning up [ ] [FAILED] example value 0 [ ] # example_priv_test: initializing [ ] # example_priv_test: cleaning up [ ] # example_priv_test: pass:1 fail:3 skip:0 total:4 [ ] ================ [FAILED] example_priv_test ================ [ ] # example: initializing suite [ ] # module: kunit_example_test [ ] # example: exiting suite [ ] # Totals: pass:1 fail:3 skip:0 total:4 [ ] ===================== [FAILED] example ===================== Fix that by resetting test->priv after each param iteration, in similar way what we did for the test->status. Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: David Gow <davidgow@google.com> Cc: Rae Moar <rmoar@google.com> Reviewed-by: David Gow <davidgow@google.com> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>		2023-12-18 13:39:05 -07:00
..
.kunitconfig
assert.c	kunit: Don't use a managed alloc in is_literal()	2023-09-18 10:45:30 -06:00
attributes.c	kunit: add is_init test attribute	2023-12-18 13:21:15 -07:00
debugfs.c	kunit: add ability to run tests after boot using debugfs	2023-12-18 13:25:49 -07:00
debugfs.h
device-impl.h	kunit: Add APIs for managing devices	2023-12-18 13:28:08 -07:00
device.c	kunit: Add APIs for managing devices	2023-12-18 13:28:08 -07:00
executor_test.c	kunit: test: Fix the possible memory leak in executor_test	2023-09-28 08:51:07 -06:00
executor.c	kunit: add is_init test attribute	2023-12-18 13:21:15 -07:00
hooks-impl.h	kunit: Add printf attribute to fail_current_test_impl	2023-02-08 18:08:14 -07:00
hooks.c	kunit: Add "hooks" to call into KUnit when it's built as a module	2023-02-08 14:26:25 -07:00
Kconfig	kunit: Allow kunit test modules to use test filtering	2023-08-08 13:46:18 -06:00
kunit-example-test.c	kunit: Add example for using test->priv	2023-12-18 13:39:00 -07:00
kunit-test.c	kunit: Add APIs for managing devices	2023-12-18 13:28:08 -07:00
Makefile	kunit: Add APIs for managing devices	2023-12-18 13:28:08 -07:00
resource.c	kunit: Add kunit_add_action() to defer a call until test exit	2023-05-25 08:52:55 -06:00
static_stub.c	kunit: Expose 'static stub' API to redirect functions	2023-02-08 14:28:17 -07:00
string-stream-test.c	kunit: string-stream-test: Avoid cast warning when testing gfp_t flags	2023-12-18 13:21:14 -07:00
string-stream.c	kunit: string-stream: Allow ERR_PTR to be passed to string_stream_destroy()	2023-12-18 13:21:14 -07:00
string-stream.h	kunit: string-stream: Decouple string_stream from kunit	2023-09-18 10:45:40 -06:00
test.c	kunit: Reset test->priv after each param iteration	2023-12-18 13:39:05 -07:00
try-catch-impl.h
try-catch.c