dominictb e021e50d53 fix: scroll the cursor into view when focus (#46411) ... Summary: Currently in iOS, when focusing the multiline text input, the cursor is not automatically scrolled into view if it is out of view. This PR adds the small util to scroll the cursor into view when the text input focuses. This doesn't happen in Android due to [this](defb0bd137/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java (L360)) Original issue: https://github.com/Expensify/App/issues/48122 Original proposal: https://github.com/Expensify/App/issues/48122#issuecomment-2320769418 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [IOS] [ADDED] - Scroll the cursor into view when text input is focused Pull Request resolved: https://github.com/facebook/react-native/pull/46411 Test Plan: Code to reproduce in rn-tester ``` const TextInputWithFocusButton = () => { const inputToFocusRef = React.useRef<React.ElementRef<typeof TextInput> | null>(null); return ( <View> <ExampleTextInput ref={inputToFocusRef} placeholder="height increases with content" defaultValue="React Native enables you to build world-class application experiences on native platforms using a consistent developer experience based on JavaScript and React. The focus of React Native is on developer efficiency across all the platforms you care about - learn once, write anywhere. Facebook uses React Native in multiple production apps and will continue investing in React Native." multiline={true} enablesReturnKeyAutomatically={true} returnKeyType="go" style={[styles.multiline, styles.multilineExpandable]} /> <Button title="Focus" onPress={() => { inputToFocusRef.current?.focus(); }} /> </View> ); }; ``` Steps: - Move the cursor of the input to end of the input text - Scroll up the input - Blur the input - Click on `Focus` button to re-focus the input Note that before this fix, the cursor is not scrolled into view - In iOS <table> <tr> <th>Before</th> <th>After</th> </tr> <tr> <td> https://github.com/user-attachments/assets/de589cbf-158c-4e28-81d6-8412bf05ab23 </td> <td> https://github.com/user-attachments/assets/81c571f9-653b-49a5-9ecb-6eeaa2c54ec7 </td> </tr> </table> Reviewed By: sammy-SC Differential Revision: D62847985 Pulled By: cipolleschi fbshipit-source-id: c0367a7fc0a7a16b30c4538e59f42d971d959357		2024-11-18 03:38:49 -08:00
..
assets
babel-plugin-codegen
community-cli-plugin
core-cli-utils
debugger-frontend
dev-middleware
eslint-config-react-native
eslint-plugin-react-native
eslint-plugin-specs
gradle-plugin
helloworld
hermes-inspector-msggen
metro-config
normalize-color
polyfills
react-native	fix: scroll the cursor into view when focus (#46411)	2024-11-18 03:38:49 -08:00
react-native-babel-preset
react-native-babel-transformer
react-native-bots
react-native-codegen
react-native-codegen-typescript-test
react-native-info
react-native-popup-menu-android
react-native-test-library
react-native-test-renderer
rn-tester	fix: scroll the cursor into view when focus (#46411)	2024-11-18 03:38:49 -08:00
typescript-config
virtualized-lists