React/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2024-11-21 22:10:14 +00:00
Code Issues Actions 10 Packages Projects Releases Wiki Activity
A framework for building native applications using React
33,866 Commits 178 Branches 563 Tags 1.4 GiB
C++ 29.5%
JavaScript 16.7%
Java 16%
Objective-C++ 12.2%
Kotlin 12.2%
Other 13.3%
e021e50d53
Go to file
dominictb e021e50d53 fix: scroll the cursor into view when focus (#46411) 
Summary:
Currently in iOS, when focusing the multiline text input, the cursor is not automatically scrolled into view if it is out of view. This PR adds the small util to scroll the cursor into view when the text input focuses. This doesn't happen in Android due to [this](defb0bd137/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java (L360))

Original issue: https://github.com/Expensify/App/issues/48122
Original proposal: https://github.com/Expensify/App/issues/48122#issuecomment-2320769418

## Changelog:

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[IOS] [ADDED] - Scroll the cursor into view when text input is focused

Pull Request resolved: https://github.com/facebook/react-native/pull/46411

Test Plan:
Code to reproduce in rn-tester
```
const TextInputWithFocusButton = () => {
  const inputToFocusRef = React.useRef<React.ElementRef<typeof TextInput> | null>(null);
  return (
    <View>
      <ExampleTextInput
        ref={inputToFocusRef}
        placeholder="height increases with content"
        defaultValue="React Native enables you to build world-class application experiences on native platforms using a consistent developer experience based on JavaScript and React. The focus of React Native is on developer efficiency across all the platforms you care about - learn once, write anywhere. Facebook uses React Native in multiple production apps and will continue investing in React Native."
        multiline={true}
        enablesReturnKeyAutomatically={true}
        returnKeyType="go"
        style={[styles.multiline, styles.multilineExpandable]}
      />
      <Button title="Focus" onPress={() => {
        inputToFocusRef.current?.focus();
      }} />
    </View>
  );
};
```

Steps:
- Move the cursor of the input to end of the input text
- Scroll up the input
- Blur the input
- Click on `Focus` button to re-focus the input

Note that before this fix, the cursor is not scrolled into view

- In iOS

<table>
<tr>
<th>Before</th>
<th>After</th>
</tr>
<tr>
<td>

https://github.com/user-attachments/assets/de589cbf-158c-4e28-81d6-8412bf05ab23

</td>
<td>

https://github.com/user-attachments/assets/81c571f9-653b-49a5-9ecb-6eeaa2c54ec7

</td>
</tr>
</table>

Reviewed By: sammy-SC

Differential Revision: D62847985

Pulled By: cipolleschi

fbshipit-source-id: c0367a7fc0a7a16b30c4538e59f42d971d959357
2024-11-18 03:38:49 -08:00
.bundle
.circleci Remove CCI leftovers (#45589) 2024-07-23 06:40:08 -07:00
.github Only build ios in check nightlies (#47506) 2024-11-08 04:28:32 -08:00
flow-typed/npm add yargs#usage typing (#46983) 2024-10-11 11:27:09 -07:00
gradle/wrapper Gradle to 8.10.2 (#46656) 2024-09-27 00:43:25 -07:00
jest introduce ability to flush messege queue from tests (#47646) 2024-11-17 03:30:31 -08:00
packages fix: scroll the cursor into view when focus (#46411) 2024-11-18 03:38:49 -08:00
scripts Add Flow typing for test runner for RN integration tests (#47612) 2024-11-15 03:00:17 -08:00
tools RN: Fix sort-imports Lint Configuration (#47104) 2024-10-17 17:06:20 -07:00
.babelrc
.clang-format Add QualifierAlignment to Clang Format Config (#44098) 2024-04-15 16:03:26 -07:00
.editorconfig
.eslintignore directly call community-cli-plugin in react-native-xcode.sh (#44721) 2024-06-05 09:08:16 -07:00
.eslintrc.js RN: Fix sort-imports Lint Configuration (#47104) 2024-10-17 17:06:20 -07:00
.flowconfig Enable ban_spread_key_props in xplat/js (#47636) 2024-11-15 14:18:51 -08:00
.gitignore Initial implementation of Jest test runner for RN integration tests (#47558) 2024-11-14 06:20:47 -08:00
.prettierignore Fixes enum codegen value cases (#44654) 2024-06-07 07:53:59 -07:00
.prettierrc Format code-workspace file, clarify use of .vscode/ dir (#44874) 2024-06-11 09:27:48 -07:00
build.gradle.kts Make build_android publish to the staging repositories (#45468) 2024-07-16 13:58:43 -07:00
CHANGELOG-pre-060.md
CHANGELOG-pre-070.md
CHANGELOG.md Add changelog for 0.76.2 (#47620) 2024-11-15 04:58:13 -08:00
CODE_OF_CONDUCT.md
CONTRIBUTING.md
ECOSYSTEM.md
Gemfile Pin Xcodeproj to < 1.26.0 (#47237) 2024-10-28 04:20:31 -07:00
Gemfile.lock feat: add conditionals for iOS only code in RCTDeviceInfo.mm (#45176) 2024-06-28 06:02:38 -07:00
gradle.properties
gradlew Gradle to 8.9 (#45407) 2024-07-12 09:00:39 -07:00
gradlew.bat Gradle to 8.10 (#46369) 2024-09-06 09:28:13 -07:00
jest.config.js fix: running local tests (#46615) 2024-09-25 05:51:49 -07:00
LICENSE
LICENSE-docs
package.json Deploy 0.253.0 to xplat (#47622) 2024-11-14 14:05:17 -08:00
react-native.code-workspace Format code-workspace file, clarify use of .vscode/ dir (#44874) 2024-06-11 09:27:48 -07:00
README.md docs: bump minSdk to 23 (#42034) 2023-12-21 22:29:00 -08:00
runXcodeTests.sh
settings.gradle.kts Revert D59170923 (#45447) 2024-07-15 13:44:09 -07:00
yarn.lock Deploy 0.253.0 to xplat (#47622) 2024-11-14 14:05:17 -08:00

README.md

React Native

Learn once, write anywhere:
Build mobile apps with React.

React Native is released under the MIT license. Current CircleCI build status. Current npm package version. PRs welcome! Follow @reactnative

Getting Started · Learn the Basics · Showcase · Contribute · Community · Support

React Native brings React's declarative UI framework to iOS and Android. With React Native, you use native UI controls and have full access to the native platform.

  • Declarative. React makes it painless to create interactive UIs. Declarative views make your code more predictable and easier to debug.
  • Component-Based. Build encapsulated components that manage their state, then compose them to make complex UIs.
  • Developer Velocity. See local changes in seconds. Changes to JavaScript code can be live reloaded without rebuilding the native app.
  • Portability. Reuse code across iOS, Android, and other platforms.

React Native is developed and supported by many companies and individual core contributors. Find out more in our ecosystem overview.

Contents

📋 Requirements

React Native apps may target iOS 13.4 and Android 6.0 (API 23) or newer. You may use Windows, macOS, or Linux as your development operating system, though building and running iOS apps is limited to macOS. Tools like Expo can be used to work around this.

🎉 Building your first React Native app

Follow the Getting Started guide. The recommended way to install React Native depends on your project. Here you can find short guides for the most common scenarios:

📖 Documentation

The full documentation for React Native can be found on our website.

The React Native documentation discusses components, APIs, and topics that are specific to React Native. For further documentation on the React API that is shared between React Native and React DOM, refer to the React documentation.

The source for the React Native documentation and website is hosted on a separate repo, @facebook/react-native-website.

🚀 Upgrading

Upgrading to new versions of React Native may give you access to more APIs, views, developer tools, and other goodies. See the Upgrading Guide for instructions.

React Native releases are discussed in this discussion repo.

👏 How to Contribute

The main purpose of this repository is to continue evolving React Native core. We want to make contributing to this project as easy and transparent as possible, and we are grateful to the community for contributing bug fixes and improvements. Read below to learn how you can take part in improving React Native.

Code of Conduct

Facebook has adopted a Code of Conduct that we expect project participants to adhere to. Please read the full text so that you can understand what actions will and will not be tolerated.

Contributing Guide

Read our Contributing Guide to learn about our development process, how to propose bugfixes and improvements, and how to build and test your changes to React Native.

Open Source Roadmap

You can learn more about our vision for React Native in the Roadmap.

Good First Issues

We have a list of good first issues that contain bugs which have a relatively limited scope. This is a great place to get started, gain experience, and get familiar with our contribution process.

Discussions

Larger discussions and proposals are discussed in @react-native-community/discussions-and-proposals.

📄 License

React Native is MIT licensed, as found in the LICENSE file.

React Native documentation is Creative Commons licensed, as found in the LICENSE-docs file.