mirror of
https://github.com/facebook/react-native.git
synced 2024-11-22 06:29:46 +00:00
42cab1488c
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/43323 This fixes a seemingly pre-existent misconfiguration within our `test_ios_template` E2E test setup in CircleCI. **Background** We call `npx react-native-community/cli init` with the `--skip-install` flag, as part of the bootstrapping logic in `scripts/e2e/init-template-e2e.js`. This is necessary because we later want to explicitly call `npm install` with a custom `--registry` for our locally mirrored packages (via Verdaccio). For some reason, we were observing unexpected differences when this was run under CircleCI: 1. Runs `yarn init` 2. Runs a `yarn add` (unknown pkg) {F1464781818} https://app.circleci.com/pipelines/github/facebook/react-native/42725/workflows/f648468b-e916-4501-887d-ad293aa6fccf/jobs/1398950 This is causing a Yarn-based install ahead of where we want — ignoring the `--skip-install` flag. *I'm still unsure on the exact LOC cause in CLI* (but most likely, it's around the Yarn v3 move). **Impact of this fix** - The above meant that, when we were bootstrapping `test_ios_template` previously, packages weren't being read from Verdaccio, but **instead from npm** — using the `"0.74.0"` versions from the *previous branch cut* ❌. - After D54006327, this behaviour became breaking 💀 — since for the 0.74 -> 0.75 cut, we no longer physically published `"0.75.0-main"` (new format) packages to npm. **This change** I'm passing `--pm npm` to `npx react-native-community/cli init` to skip around any Yarn behaviour. This appears to have removed the erroneous `yarn` invocations ✅. Changelog: [Internal] bypass-github-export-checks Reviewed By: cortinico, cipolleschi Differential Revision: D54536848 fbshipit-source-id: 473b11924955f5787c82a6c81d4527d77b810aa5
180 lines
4.8 KiB
JavaScript
180 lines
4.8 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @flow
|
|
* @format
|
|
* @oncall react_native
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const {retry} = require('../circleci/retry');
|
|
const {REPO_ROOT} = require('../consts');
|
|
const {getPackages} = require('../utils/monorepo');
|
|
const {
|
|
VERDACCIO_SERVER_URL,
|
|
VERDACCIO_STORAGE_PATH,
|
|
setupVerdaccio,
|
|
} = require('./utils/verdaccio');
|
|
const {parseArgs} = require('@pkgjs/parseargs');
|
|
const chalk = require('chalk');
|
|
const {execSync} = require('child_process');
|
|
const path = require('path');
|
|
|
|
const config = {
|
|
options: {
|
|
projectName: {type: 'string'},
|
|
templatePath: {type: 'string'},
|
|
directory: {type: 'string'},
|
|
verbose: {type: 'boolean', default: false},
|
|
help: {type: 'boolean'},
|
|
},
|
|
};
|
|
|
|
async function main() {
|
|
const {
|
|
values: {help, ...options},
|
|
} = parseArgs(config);
|
|
|
|
if (help) {
|
|
console.log(`
|
|
Usage: node ./scripts/e2e/init-template-e2e.js [OPTIONS]
|
|
|
|
Bootstraps and runs \`react-native init\`, using the currently checked out
|
|
repository as the source of truth for the react-native package and
|
|
dependencies.
|
|
|
|
- Configures and starts a local npm proxy (Verdaccio).
|
|
- Builds and publishes all in-repo dependencies to the local npm proxy.
|
|
- Runs \`react-native init\` with the local npm proxy configured.
|
|
- Does NOT install CocoaPods dependencies.
|
|
|
|
Note: This script will mutate the contents of some package files, which
|
|
should not be committed.
|
|
|
|
Options:
|
|
--projectName The name of the new React Native project.
|
|
--templatePath The absolute path to the folder containing the template.
|
|
--directory The absolute path to the target project directory.
|
|
--verbose Print additional output. Default: false.
|
|
`);
|
|
return;
|
|
}
|
|
|
|
await initNewProjectFromSource(options);
|
|
|
|
// TODO(T179377112): Fix memory leak from `spawn` in `setupVerdaccio` (above
|
|
// kill command does not wait for kill success).
|
|
process.exit(0);
|
|
}
|
|
|
|
async function initNewProjectFromSource(
|
|
{
|
|
projectName,
|
|
templatePath,
|
|
directory,
|
|
verbose = false,
|
|
} /*: {projectName: string, templatePath: string, directory: string, verbose?: boolean} */,
|
|
) {
|
|
console.log('Starting local npm proxy (Verdaccio)');
|
|
const verdaccioPid = setupVerdaccio();
|
|
console.log('Done ✅');
|
|
|
|
try {
|
|
execSync('node ./scripts/build/build.js', {
|
|
cwd: REPO_ROOT,
|
|
stdio: 'inherit',
|
|
});
|
|
console.log('\nDone ✅');
|
|
|
|
console.log('Publishing packages to local npm proxy\n');
|
|
const packages = await getPackages({
|
|
includeReactNative: false,
|
|
includePrivate: false,
|
|
});
|
|
|
|
for (const {path: packagePath, packageJson} of Object.values(packages)) {
|
|
const desc = `${packageJson.name} (${path.relative(
|
|
REPO_ROOT,
|
|
packagePath,
|
|
)})`;
|
|
process.stdout.write(
|
|
`${desc} ${chalk.dim('.').repeat(Math.max(0, 72 - desc.length))} `,
|
|
);
|
|
execSync(
|
|
`npm publish --registry ${VERDACCIO_SERVER_URL} --access public`,
|
|
{
|
|
cwd: packagePath,
|
|
stdio: verbose ? 'inherit' : [process.stderr],
|
|
},
|
|
);
|
|
process.stdout.write(chalk.reset.inverse.bold.green(' DONE ') + '\n');
|
|
}
|
|
console.log('\nDone ✅');
|
|
|
|
console.log('Running react-native init without install');
|
|
execSync(
|
|
`node ./packages/react-native/cli.js init ${projectName} \
|
|
--directory ${directory} \
|
|
--template ${templatePath} \
|
|
--verbose \
|
|
--pm npm \
|
|
--skip-install`,
|
|
{
|
|
// Avoid loading packages/react-native/react-native.config.js
|
|
cwd: REPO_ROOT,
|
|
stdio: 'inherit',
|
|
},
|
|
);
|
|
console.log('\nDone ✅');
|
|
|
|
console.log('Installing project dependencies');
|
|
await installProjectUsingProxy(directory);
|
|
console.log('Done ✅');
|
|
} catch (e) {
|
|
console.log('Failed ❌');
|
|
throw e;
|
|
} finally {
|
|
console.log(`Cleanup: Killing Verdaccio process (PID: ${verdaccioPid})`);
|
|
try {
|
|
execSync(`kill -9 ${verdaccioPid}`);
|
|
console.log('Done ✅');
|
|
} catch {
|
|
console.warn('Failed to kill Verdaccio process');
|
|
}
|
|
console.log('Cleanup: Removing Verdaccio storage directory');
|
|
execSync(`rm -rf ${VERDACCIO_STORAGE_PATH}`);
|
|
console.log('Done ✅');
|
|
}
|
|
}
|
|
|
|
async function installProjectUsingProxy(cwd /*: string */) {
|
|
const execOptions = {
|
|
cwd,
|
|
stdio: 'inherit',
|
|
};
|
|
|
|
// TODO(huntie): Review pre-existing retry limit
|
|
const success = await retry('npm', execOptions, 3, 500, [
|
|
'install',
|
|
'--registry',
|
|
VERDACCIO_SERVER_URL,
|
|
]);
|
|
|
|
if (!success) {
|
|
throw new Error('Failed to install project dependencies');
|
|
}
|
|
}
|
|
|
|
module.exports = {
|
|
initNewProjectFromSource,
|
|
};
|
|
|
|
if (require.main === module) {
|
|
// eslint-disable-next-line no-void
|
|
void main();
|
|
}
|