mirror of
https://github.com/facebook/react-native.git
synced 2024-11-21 22:10:14 +00:00
42cab1488c
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/43323 This fixes a seemingly pre-existent misconfiguration within our `test_ios_template` E2E test setup in CircleCI. **Background** We call `npx react-native-community/cli init` with the `--skip-install` flag, as part of the bootstrapping logic in `scripts/e2e/init-template-e2e.js`. This is necessary because we later want to explicitly call `npm install` with a custom `--registry` for our locally mirrored packages (via Verdaccio). For some reason, we were observing unexpected differences when this was run under CircleCI: 1. Runs `yarn init` 2. Runs a `yarn add` (unknown pkg) {F1464781818} https://app.circleci.com/pipelines/github/facebook/react-native/42725/workflows/f648468b-e916-4501-887d-ad293aa6fccf/jobs/1398950 This is causing a Yarn-based install ahead of where we want — ignoring the `--skip-install` flag. *I'm still unsure on the exact LOC cause in CLI* (but most likely, it's around the Yarn v3 move). **Impact of this fix** - The above meant that, when we were bootstrapping `test_ios_template` previously, packages weren't being read from Verdaccio, but **instead from npm** — using the `"0.74.0"` versions from the *previous branch cut* ❌. - After D54006327, this behaviour became breaking 💀 — since for the 0.74 -> 0.75 cut, we no longer physically published `"0.75.0-main"` (new format) packages to npm. **This change** I'm passing `--pm npm` to `npx react-native-community/cli init` to skip around any Yarn behaviour. This appears to have removed the erroneous `yarn` invocations ✅. Changelog: [Internal] bypass-github-export-checks Reviewed By: cortinico, cipolleschi Differential Revision: D54536848 fbshipit-source-id: 473b11924955f5787c82a6c81d4527d77b810aa5 |
||
|---|---|---|
| .. | ||
| utils | ||
| init-template-e2e.js | ||
| run-ci-e2e-tests.js | ||
| verdaccio.yml | ||