Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity
a9dd03b1ec
node/GOVERNANCE.md
Michaël Zasso 0df6f4edd2 doc: improve description of the triagers team 
PR-URL: https://github.com/nodejs/node/pull/39833
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2021-08-23 14:42:28 +00:00

7.2 KiB
Raw Blame History

Node.js Project Governance

Triagers

Triagers assess newly-opened issues in the nodejs/node and nodejs/help repositories. The GitHub team for Node.js triagers is @nodejs/issue-triage. Triagers are given the "Triage" GitHub role and have:

  • Ability to label issues and pull requests
  • Ability to comment, close, and reopen issues and pull requests

See:

Collaborators

Node.js core collaborators maintain the nodejs/node GitHub repository. The GitHub team for Node.js core collaborators is @nodejs/collaborators. Collaborators have:

  • Commit access to the nodejs/node repository
  • Access to the Node.js continuous integration (CI) jobs

Both collaborators and non-collaborators may propose changes to the Node.js source code. The mechanism to propose such a change is a GitHub pull request. Collaborators review and merge (land) pull requests.

Two collaborators must approve a pull request before the pull request can land. (One collaborator approval is enough if the pull request has been open for more than 7 days.) Approving a pull request indicates that the collaborator accepts responsibility for the change. Approval must be from collaborators who are not authors of the change.

If a collaborator opposes a proposed change, then the change cannot land. The exception is if the TSC votes to approve the change despite the opposition. Usually, involving the TSC is unnecessary. Often, discussions or further changes result in collaborators removing their opposition.

See:

Collaborator activities

  • Helping users and novice contributors
  • Contributing code and documentation changes that improve the project
  • Reviewing and commenting on issues and pull requests
  • Participation in working groups
  • Merging pull requests

The TSC can remove inactive collaborators or provide them with Emeritus status. Emeriti may request that the TSC restore them to active status.

Technical Steering Committee

A subset of the collaborators forms the Technical Steering Committee (TSC). The TSC has final authority over this project, including:

  • Technical direction
  • Project governance and process (including this policy)
  • Contribution policy
  • GitHub repository hosting
  • Conduct guidelines
  • Maintaining the list of collaborators

The current list of TSC members is in the project README.

The TSC Charter governs the operations of the TSC. All changes to the Charter need approval by the OpenJS Foundation Cross-Project Council (CPC).

TSC meetings

The TSC meets in a voice conference call. Each year, the TSC elects a chair to run the meetings. The TSC streams its meetings for public viewing on YouTube or a similar service.

The TSC agenda includes issues that are at an impasse. The intention of the agenda is not to review or approve all patches. Collaborators review and approve patches on GitHub.

Any community member can create a GitHub issue asking that the TSC review something. If consensus-seeking fails for an issue, a collaborator may apply the tsc-agenda label. That will add it to the TSC meeting agenda.

Before each TSC meeting, the meeting chair will share the agenda with members of the TSC. TSC members can also add items to the agenda at the beginning of each meeting. The meeting chair and the TSC cannot veto or remove items.

The TSC may invite people to take part in a non-voting capacity.

During the meeting, the TSC chair ensures that someone takes minutes. After the meeting, the TSC chair ensures that someone opens a pull request with the minutes.

The TSC seeks to resolve as many issues as possible outside meetings using the TSC issue tracker. The process in the issue tracker is:

  • A TSC member opens an issue explaining the proposal/issue and @-mentions @nodejs/tsc.
  • The proposal passes if, after 72 hours, there are two or more TSC approvals and no TSC opposition.
  • If there is an extended impasse, a TSC member may make a motion for a vote.

Collaborator nominations

Existing collaborators can nominate someone to become a collaborator. Nominees should have significant and valuable contributions across the Node.js organization.

To nominate a new collaborator, open an issue in the nodejs/node repository. Provide a summary of the nominee's contributions. For example:

  • Commits in the nodejs/node repository.
    • Use the link https://github.com/nodejs/node/commits?author=GITHUB_ID
  • Pull requests and issues opened in the nodejs/node repository.
    • Use the link https://github.com/nodejs/node/issues?q=author:GITHUB_ID
  • Comments on pull requests and issues in the nodejs/node repository
    • Use the link https://github.com/nodejs/node/issues?q=commenter:GITHUB_ID
  • Reviews on pull requests in the nodejs/node repository
    • Use the link https://github.com/nodejs/node/pulls?q=reviewed-by:GITHUB_ID
  • Help provided to end-users and novice contributors
  • Pull requests and issues opened throughout the Node.js organization
    • Use the link https://github.com/search?q=author:GITHUB_ID+org:nodejs
  • Comments on pull requests and issues throughout the Node.js organization
    • Use the link https://github.com/search?q=commenter:GITHUB_ID+org:nodejs
  • Participation in other projects, teams, and working groups of the Node.js organization
  • Other participation in the wider Node.js community

Mention @nodejs/collaborators in the issue to notify other collaborators about the nomination.

The nomination passes if no collaborators oppose it after one week. Otherwise, the nomination fails.

There are steps a nominator can take in advance to make a nomination as frictionless as possible. To request feedback from other collaborators in private, use the collaborators discussion page (which only collaborators may view). A nominator may also work with the nominee to improve their contribution profile.

Collaborators might overlook someone with valuable contributions. In that case, the contributor may open an issue or contact a collaborator to request a nomination.

Onboarding

After the nomination passes, a TSC member onboards the new collaborator. See the onboarding guide for details of the onboarding process.

Consensus seeking process

The TSC follows a Consensus Seeking decision-making model per the TSC Charter.