mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
71e9bc1108
The spawnSync call was previously silently failing with this error: ```sh icupkg: unable to open input file "icudt*.dat" ``` because spawnSync doesn't support globbing. This change replaces the spawnSync call with execSync because that supports globbing. I have tested this workflow with some minor modifications in my fork and I can confirm that it works as expected now. The bot opened this PR - https://github.com/RaisinTen/node/pull/2 which updates deps/icu-small/source/data/in/icudt71l.dat.bz2. Fixes: https://github.com/nodejs/node/issues/44865 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/44870 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> |
||
---|---|---|
.. | ||
actions | ||
bootstrap | ||
clang-format | ||
configure.d | ||
dep_checker | ||
doc | ||
eslint-rules | ||
gyp | ||
icu | ||
inspector_protocol | ||
lint-md | ||
macos-installer | ||
msvs | ||
node_modules | ||
pip | ||
snapshot | ||
v8 | ||
v8_gypfiles | ||
zos | ||
.eslintrc.yaml | ||
build-addons.mjs | ||
certdata.txt | ||
checkimports.py | ||
compress_json.py | ||
copyfile.py | ||
cpplint.py | ||
create_android_makefiles | ||
create_expfile.sh | ||
enable_fips_include.py | ||
find-inactive-collaborators.mjs | ||
find-inactive-tsc.mjs | ||
gen_node_def.cc | ||
genv8constants.py | ||
getarch.py | ||
getendian.py | ||
getmachine.py | ||
getmoduleversion.py | ||
getnapibuildversion.py | ||
getnodeversion.py | ||
getsharedopensslhasquic.py | ||
gyp_node.py | ||
install.py | ||
js2c.py | ||
license2rtf.mjs | ||
license-builder.sh | ||
lint-pr-url.mjs | ||
lint-sh.mjs | ||
lsan_suppressions.txt | ||
macos-firewall.sh | ||
make-v8.sh | ||
mk-ca-bundle.pl | ||
mkssldef.py | ||
osx-codesign.sh | ||
osx-entitlements.plist | ||
osx-gon-config.json.tmpl | ||
osx-notarize.sh | ||
osx-pkg-postinstall.sh | ||
osx-productsign.sh | ||
release.sh | ||
run-valgrind.py | ||
run-worker.js | ||
sign.bat | ||
specialize_node_d.py | ||
test-npm-package.js | ||
test-v8.bat | ||
test.py | ||
update-authors.mjs | ||
update-cares.sh | ||
update-eslint.sh | ||
update-llhttp.sh | ||
update-nghttp2.sh | ||
update-npm.sh | ||
update-timezone.mjs | ||
update-undici.sh | ||
utils.py | ||
v8-json-to-junit.py | ||
valgrind.supp |