Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity
181052d7c2
node/GOVERNANCE.md
Rich Trott 181052d7c2 doc: revise Collaborator description in GOVERNANCE.md 
* Active voice
* Remove Node.js Foundation mention. It may be appropriate to add
  something back in when the new foundation is bootstrapped. We
  don't control membership criteria, so best to link to something else
  when it becomes available rather than make guarantees in this doc.

PR-URL: https://github.com/nodejs/node/pull/27071
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
2019-04-05 09:55:25 -07:00

7.9 KiB
Raw Blame History

Node.js Project Governance

Collaborators

Node.js Core Collaborators maintain the nodejs/node GitHub repository. The GitHub team for Node.js Core Collaborators is @nodejs/collaborators. Their privileges include but are not limited to:

  • Commit access to the nodejs/node repository
  • Access to the Node.js continuous integration (CI) jobs

Modifications of the contents of the nodejs/node repository are made on a collaborative basis. Anybody with a GitHub account may propose a modification via pull request and it will be considered by the project Collaborators.

At least two Collaborators must approve a pull request before the pull request lands. (One Collaborator approval is enough if the pull request has been open for more than 7 days.) Approving a pull request indicates that the Collaborator accepts responsibility for the change. Approval must be from Collaborators who are not authors of the change.

If one or more Collaborators oppose a proposed change, then the change cannot be accepted unless:

  • Discussions and/or additional changes result in no Collaborators objecting to the change. Previously-objecting Collaborators do not necessarily have to sign off on the change, but they should not be opposed to it.
  • The change is escalated to the TSC and the TSC votes to approve the change. This should only happen if disagreements between Collaborators cannot be resolved through discussion.

See:

Collaborator Activities

Typical activities of a Collaborator include:

  • Helping users and novice contributors
  • Contributing code and documentation changes that improve the project
  • Reviewing and commenting on issues and pull requests
  • Participation in working groups
  • Merging pull requests

The TSC periodically reviews the Collaborator list to identify inactive Collaborators. Past Collaborators are typically given Emeritus status. Emeriti may request that the TSC restore them to active status.

Technical Steering Committee

A subset of the Collaborators forms the Technical Steering Committee (TSC). The TSC has final authority over this project, including:

  • Technical direction
  • Project governance and process (including this policy)
  • Contribution policy
  • GitHub repository hosting
  • Conduct guidelines
  • Maintaining the list of additional Collaborators

The current list of TSC members can be found in the project README.

The operations of the TSC are governed by the TSC Charter as approved by the Node.js Foundation Board of Directors.

TSC Meetings

The TSC meets regularly in a voice conference call. The meeting is run by a designated meeting chair approved by the TSC. Each meeting is streamed on YouTube.

Items are added to the TSC agenda which are considered contentious or are modifications of governance, contribution policy, TSC membership, or release process.

The intention of the agenda is not to approve or review all patches. That should happen continuously on GitHub and be handled by the larger group of Collaborators.

Any community member or contributor can ask that something be reviewed by the TSC by logging a GitHub issue. If consensus-seeking among TSC members fails for a particular issue, it may be added to the TSC meeting agenda by adding the tsc-agenda label.

Prior to each TSC meeting, the meeting chair will share the agenda with members of the TSC. TSC members can also add items to the agenda at the beginning of each meeting. The meeting chair and the TSC cannot veto or remove items.

The TSC may invite additional persons to participate in a non-voting capacity.

The meeting chair is responsible for ensuring that minutes are taken and that a pull request with the minutes is submitted after the meeting.

Due to the challenges of scheduling a global meeting with participants in several time zones, the TSC will seek to resolve as many agenda items as possible outside of meetings using the TSC issue tracker. The process in the issue tracker is:

  • A TSC member opens an issue explaining the proposal/issue and @-mentions @nodejs/tsc.
  • After 72 hours, if there are two or more LGTMs from other TSC members and no explicit opposition from other TSC members, then the proposal is approved.
  • If there are any TSC members objecting, then a conversation ensues until either the proposal is dropped or the objecting members are persuaded. If there is an extended impasse, a motion for a vote may be made.

Collaborator Nominations

Any existing Collaborator can nominate an individual making significant and valuable contributions across the Node.js organization to become a new Collaborator.

To nominate a new Collaborator, open an issue in the nodejs/node repository, with a summary of the nominee's contributions, for example:

  • Commits in the nodejs/node repository.
    • Can be shown using the link https://github.com/nodejs/node/commits?author=${GITHUB_ID} (replace ${GITHUB_ID} with the nominee's GitHub ID).
  • Pull requests and issues opened in the nodejs/node repository.
    • Can be shown using the link https://github.com/nodejs/node/pulls?q=author%3A${GITHUB_ID}+
  • Comments and reviews on issues and pull requests in the nodejs/node repository
    • Can be shown using the links https://github.com/nodejs/node/pulls?q=reviewed-by%3A${GITHUB_ID}+ and https://github.com/nodejs/node/pulls?q=commenter%3A${GITHUB_ID}+
  • Assistance provided to end users and novice contributors
  • Participation in other projects, teams, and working groups of the Node.js organization
    • Can be shown using the links https://github.com/search?q=author%3A${GITHUB_ID}++org%3Anodejs&type=Issues and https://github.com/search?q=commenter%3A${GITHUB_ID}++org%3Anodejs&type=Issues
  • Other participation in the wider Node.js community

Mention @nodejs/collaborators in the issue to notify other Collaborators about the nomination.

If there are no objections raised by any Collaborators one week after the issue is opened, the nomination will be considered as accepted. Should there be any objections against the nomination, the TSC is responsible for working with the individuals involved and finding a resolution. The nomination must be approved by the TSC, which is assumed when there are no objections from any TSC members.

Prior to the public nomination, the Collaborator initiating it can seek feedback from other Collaborators in private using the GitHub discussion page of the Collaborators team, and work with the nominee to improve the nominee's contribution profile, in order to make the nomination as frictionless as possible.

If individuals making valuable contributions do not believe they have been considered for a nomination, they may log an issue or contact a Collaborator directly.

Onboarding

When the nomination is accepted, the new Collaborator will be onboarded by a TSC member. See the onboarding guide on details of the onboarding process. In general, the onboarding should be completed within a month after the nomination is accepted.

Consensus Seeking Process

The TSC follows a Consensus Seeking decision-making model as described by the TSC Charter.