Rafael Gonzaga
fde30a15e6
benchmark: change assert() to assert.ok()
...
PR-URL: https://github.com/nodejs/node/pull/54254
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-10 20:06:18 +00:00
Hüseyin Açacak
37f9eca5b5
module,win: fix long path resolve
...
PR-URL: https://github.com/nodejs/node/pull/53294
Fixes: https://github.com/nodejs/node/issues/50753
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
2024-08-10 14:12:53 +00:00
HEESEUNG
90d91abbfe
console: use validateOneOf for colorMode validation
...
refactor the Console constructor to use validateOneOf for validating
the colorMode parameter.
PR-URL: https://github.com/nodejs/node/pull/54245
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-10 01:49:40 +00:00
Node.js GitHub Bot
4557c13c21
deps: update undici to 6.19.7
...
PR-URL: https://github.com/nodejs/node/pull/54286
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2024-08-09 22:03:04 +00:00
Stephen Belanger
7366808b85
lib: improve async_context_frame structure
...
PR-URL: https://github.com/nodejs/node/pull/54239
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2024-08-09 19:44:42 +00:00
Rafael Gonzaga
88760f1c30
typings: add util.styleText type definition
...
PR-URL: https://github.com/nodejs/node/pull/54252
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2024-08-09 19:36:27 +00:00
Samuli Asmala
19bf154a13
doc: update buffer.constants.MAX_LENGTH size
...
Starting from Node v22.0.0 the `buffer.constants.MAX_LENGTH` has been
increased from 4 GiB to 8 PiB due to V8 engine update to 12.4.254.14.
PR-URL: https://github.com/nodejs/node/pull/54207
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-09 19:19:24 +00:00
Marco Ippolito
3cbeed88d9
module: refactor ts parser loading
...
PR-URL: https://github.com/nodejs/node/pull/54243
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2024-08-09 06:46:58 +00:00
Isaac-yz-Liu
30f6c56e03
test: fix timeout not being cleared
...
PR-URL: https://github.com/nodejs/node/pull/54242
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
2024-08-09 05:42:10 +00:00
Antoine du Hamel
9e6c526f6c
test: refactor test-runner-module-mocking
...
PR-URL: https://github.com/nodejs/node/pull/54233
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2024-08-08 18:27:08 +00:00
Jason Zhang
90dea9e3e0
doc: warn for windows build bug
...
Refs: https://github.com/nodejs/build/issues/3739
PR-URL: https://github.com/nodejs/node/pull/54217
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2024-08-08 05:58:53 +00:00
Pietro Marchini
88bac52b23
test_runner: fix erroneous diagnostic warning when only: false
...
Co-author: rstagi <r.stagi96@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/54116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2024-08-08 05:50:32 +00:00
Chengzhong Wu
2bcf9995d2
src: skip inspector wait in internal workers
...
Internal workers are essential to load user scripts and bootstrapped
with internal entrypoints. They should not be waiting for inspectors
even when `--inspect-brk` and `--inspect-wait` were specified, and avoid
blocking main thread to bootstrap.
IsolateData can be created with a specified PerIsolateOptions instead of
creating a copy from the per_process namespace. This also avoids
creating a copy bypassing the parent env's modified options, like
creating a worker thread from a worker thread.
PR-URL: https://github.com/nodejs/node/pull/54219
Fixes: https://github.com/nodejs/node/issues/53681
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2024-08-07 21:56:59 +00:00
Michael Dawson
e9deab9915
tools: make undici updater build wasm from src
...
- modify updater to include all files required to rebuild
wasm from what's stored in the deps/undici directory
- modify updater to build wasm from source while updating
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: https://github.com/nodejs/node/pull/54128
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
2024-08-07 16:57:26 -04:00
Node.js GitHub Bot
a3ff3e8cd4
meta: move one or more collaborators to emeritus
...
PR-URL: https://github.com/nodejs/node/pull/54210
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-08-07 19:20:40 +00:00
Deokjin Kim
a4f609faf5
doc: make some parameters optional in tracingChannel.traceCallback
...
Plus, add missing `position` parameter to CJS example.
PR-URL: https://github.com/nodejs/node/pull/54068
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2024-08-07 15:26:20 +09:30
Rafael Gonzaga
7327e44a05
doc: sort versions to fix the linter error
...
PR-URL: https://github.com/nodejs/node/pull/54229
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-08-06 23:56:00 +02:00
Luigi Pinca
e0634f58ab
test: use assert.{s,deepS}trictEqual()
...
Use `asset.strictEqual()` and `asset.deepStrictEqual()` in
`test/parallel/test-tls-set-sigalgs.js`.
PR-URL: https://github.com/nodejs/node/pull/54208
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2024-08-06 20:12:31 +00:00
Jonas
3ed9f989b8
fs: remove unnecessary option argument validation
...
PR-URL: https://github.com/nodejs/node/pull/53958
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2024-08-06 18:43:41 +00:00
Fedor Indutny
78150f3e9c
lib: fix unhandled errors in webstream adapters
...
WebStream's Readable controller does not tolerate `.close()` being
called after an `error`. However, when wrapping a Node's Readable stream
it is possible that the sequence of events leads to `finished()`'s
callback being invoked after such `error`.
In order to handle this, in this change we call the `finished()` handler
earlier when controller is canceled, and always handle this as an error
case.
Fix: https://github.com/nodejs/node/issues/54205
PR-URL: https://github.com/nodejs/node/pull/54206
Fixes: https://github.com/nodejs/node/issues/54205
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2024-08-06 18:34:35 +00:00
Alfredo González
e2c62203cc
doc: add esm examples to node:dns
...
PR-URL: https://github.com/nodejs/node/pull/54172
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-08-06 18:34:19 +00:00
Aviv Keller
dc86592f20
meta: add module label for the lib/internal/modules folder
...
PR-URL: https://github.com/nodejs/node/pull/52858
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-06 18:34:11 +00:00
Aviv Keller
0260bbeefa
benchmark: support --help in CLI
...
PR-URL: https://github.com/nodejs/node/pull/53358
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-06 18:21:27 +00:00
RafaelGSS
3660ad5c92
2024-08-06, Version 22.6.0 (Current)
...
Notable changes:
deps:
* (SEMVER-MINOR) V8: backport 7857eb34db42 (Stephen Belanger) https://github.com/nodejs/node/pull/53997
http:
* (SEMVER-MINOR) add diagnostics channel `http.client.request.error` (Kohei Ueno) https://github.com/nodejs/node/pull/54054
inspector:
* (SEMVER-MINOR) add initial support for network inspection (Kohei Ueno) https://github.com/nodejs/node/pull/53593
lib,src:
* drop --experimental-network-imports (Rafael Gonzaga) https://github.com/nodejs/node/pull/53822
meta:
* add jake to collaborators (jakecastelli) https://github.com/nodejs/node/pull/54004
module:
* (SEMVER-MINOR) add --experimental-strip-types (Marco Ippolito) https://github.com/nodejs/node/pull/53725
stream:
* (SEMVER-MINOR) expose DuplexPair API (Austin Wright) https://github.com/nodejs/node/pull/34111
test_runner:
* (SEMVER-MINOR) fix support watch with run(), add globPatterns option (Matteo Collina) https://github.com/nodejs/node/pull/53866
* (SEMVER-MINOR) refactor snapshots to get file from context (Colin Ihrig) https://github.com/nodejs/node/pull/53853
* (SEMVER-MINOR) add context.filePath (Colin Ihrig) https://github.com/nodejs/node/pull/53853
PR-URL: https://github.com/nodejs/node/pull/54123
2024-08-06 13:58:38 -03:00
Node.js GitHub Bot
54119757a3
deps: update acorn to 8.12.1
...
PR-URL: https://github.com/nodejs/node/pull/53465
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-08-06 11:59:50 -04:00
sungpaks
359b4284bc
test: add subtests to test-node-run
...
Added two subtests to test-node-run. First one is about unparsable
package.json file, and the second one is about there is no "script"
fields in package.json
PR-URL: https://github.com/nodejs/node/pull/54204
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2024-08-06 15:47:52 +00:00
Yelim Koo
e1e7a417da
benchmark: remove force option as force defaults to true
...
PR-URL: https://github.com/nodejs/node/pull/54203
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2024-08-06 15:20:45 +00:00
Antoine du Hamel
b47aa708a8
tools: add workflow to ensure README lists are in sync with gh teams
...
PR-URL: https://github.com/nodejs/node/pull/53901
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2024-08-06 13:50:27 +00:00
Chengzhong Wu
277ed9fd86
doc: add KevinEady as a triager
...
PR-URL: https://github.com/nodejs/node/pull/54179
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
2024-08-06 11:53:15 +00:00
Alfredo González
fd49758796
doc: add esm examples to node:console
...
PR-URL: https://github.com/nodejs/node/pull/54108
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2024-08-06 09:56:59 +00:00
Hüseyin Açacak
c852e222cb
path: fix relative on Windows
...
PR-URL: https://github.com/nodejs/node/pull/53991
Fixes: https://github.com/nodejs/node/issues/27534
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-08-06 09:40:23 +00:00
Sung Ye In
5bfebfec88
test_runner: make mock_loader not confuse CJS and ESM resolution
...
PR-URL: https://github.com/nodejs/node/pull/53846
Fixes: https://github.com/nodejs/node/issues/53807
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-08-06 11:24:24 +02:00
Sadzurami
24ed890663
doc: fix sea assets example
...
PR-URL: https://github.com/nodejs/node/pull/54192
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-06 08:24:23 +00:00
Stefan Stojanovic
1f69085db5
test: set test-structuredclone-jstransferable non-flaky
...
Fixes: https://github.com/nodejs/node/issues/50260
PR-URL: https://github.com/nodejs/node/pull/54115
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2024-08-06 08:24:15 +00:00
Aviv Keller
2b41c237c0
doc: add links to security steward companies
...
PR-URL: https://github.com/nodejs/node/pull/52981
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-08-06 07:51:07 +00:00
devstone
1bcdba233d
test: update wpt test for streams
...
PR-URL: https://github.com/nodejs/node/pull/54129
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-08-06 05:57:48 +00:00
Aviv Keller
accf2acdfb
build: support lint-js-fix in vcbuild.bat
...
PR-URL: https://github.com/nodejs/node/pull/53695
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
2024-08-06 05:57:35 +00:00
Node.js GitHub Bot
5f52c8ae54
deps: update undici to 6.19.5
...
PR-URL: https://github.com/nodejs/node/pull/54076
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2024-08-06 07:50:36 +02:00
Node.js GitHub Bot
f182c6c0bc
deps: update simdutf to 5.3.1
...
PR-URL: https://github.com/nodejs/node/pull/54196
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2024-08-06 07:48:54 +02:00
dependabot[bot]
5b32511f54
meta: bump actions/upload-artifact from 4.3.3 to 4.3.4
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](65462800fd...0b2256b8c0https://github.com/nodejs/node/pull/54166
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-06 07:48:06 +02:00
dependabot[bot]
66a34da003
meta: bump actions/download-artifact from 4.1.7 to 4.1.8
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.1.7 to 4.1.8.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](65a9edc588...fa0a91b85dhttps://github.com/nodejs/node/pull/54167
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-06 07:47:09 +02:00
dependabot[bot]
185218887b
meta: bump actions/setup-python from 5.1.0 to 5.1.1
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](82c7e631bb...39cd14951bhttps://github.com/nodejs/node/pull/54165
Refs: 39cd14951b
2024-08-06 07:45:54 +02:00
dependabot[bot]
552df3edab
meta: bump step-security/harden-runner from 2.8.1 to 2.9.0
...
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner ) from 2.8.1 to 2.9.0.
- [Release notes](https://github.com/step-security/harden-runner/releases )
- [Commits](17d0e2bd7d...0d381219ddhttps://github.com/nodejs/node/pull/54169
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-08-06 07:45:01 +02:00
dependabot[bot]
6edbc04a3b
meta: bump actions/setup-node from 4.0.2 to 4.0.3
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](60edb5dd54...1e60f620b9https://github.com/nodejs/node/pull/54170
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-06 07:44:12 +02:00
dependabot[bot]
e55eb45d34
meta: bump github/codeql-action from 3.25.11 to 3.25.15
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.11 to 3.25.15.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b611370bb5...afb54ba388https://github.com/nodejs/node/pull/54168
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-06 07:43:19 +02:00
dependabot[bot]
28adfbe746
meta: bump ossf/scorecard-action from 2.3.3 to 2.4.0
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.3.3 to 2.4.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](dc50aa9510...62b2cac7edhttps://github.com/nodejs/node/pull/54171
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-08-06 01:59:22 +02:00
sendoru
a5200da1d0
doc: move onread option from socket.connect() to new net.socket()
...
Fixes: https://github.com/nodejs/node/issues/53792
PR-URL: https://github.com/nodejs/node/pull/54194
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
2024-08-05 23:36:20 +00:00
James M Snell
926503b669
src: shift more crypto impl details to ncrypto
...
PR-URL: https://github.com/nodejs/node/pull/54028
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2024-08-05 14:01:21 -07:00
Joyee Cheung
c6aeddf140
sea: don't set code cache flags when snapshot is used
...
When both useCodeCache and useSnapshot are set, we generate the
snapshot and skip the generation of the code cache since the
snapshot already includes the code cache. But we previously still
persist the code cache setting in the flags that got serialized
into the SEA, so the resulting executable would still try to read
the code cache even if it's not added to the SEA, leading to a flaky
crash caused by OOB on some platforms.
This patch fixes the crash by ignoring the code cache setting when
generating the flag if both snapshot and code cache is configured.
PR-URL: https://github.com/nodejs/node/pull/54120
Fixes: https://github.com/nodejs/node/issues/50740
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2024-08-05 16:48:12 +00:00
Aviv Keller
981b5e3279
doc, meta: replace command with link to keys
...
PR-URL: https://github.com/nodejs/node/pull/53745
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2024-08-05 16:39:58 +00:00
