Commit Graph

37495 Commits

Author SHA1 Message Date
Antoine du Hamel
7e581c88fc
tools: fix stability index generation
PR-URL: https://github.com/nodejs/node/pull/45346
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
2022-11-07 01:25:44 +00:00
Tobias Nießen
7903f944ec
src: resolve TODO related to inspector CVEs
This was not done before the security release because the latest CVE was
not known at the time.

PR-URL: https://github.com/nodejs/node/pull/45341
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2022-11-06 22:08:59 +00:00
Yagiz Nizipli
e14321bb50
util: improve textdecoder decode performance
PR-URL: https://github.com/nodejs/node/pull/45294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2022-11-06 20:27:41 +00:00
Rich Trott
f9fab41140
tools: increase macOS cores to 3 on GitHub CI
In efbec85f30, we reduced the cores to 2
based on GitHub documentation. The documentation now says that there are
3 cores.

Refs: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
PR-URL: https://github.com/nodejs/node/pull/45340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-11-06 19:56:25 +00:00
theanarkh
4fc6ef53bc
doc: add more info for timer.setInterval
PR-URL: https://github.com/nodejs/node/pull/45232
Refs: https://github.com/nodejs/node/issues/45224
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2022-11-06 17:45:23 +00:00
Filip Skokan
4a258b2060
doc: use module names in stability overview table
PR-URL: https://github.com/nodejs/node/pull/45312
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-11-06 09:32:28 +00:00
Michaël Zasso
9ae8920175
deps: patch V8 to 10.7.193.20
Refs: https://github.com/v8/v8/compare/10.7.193.16...10.7.193.20
PR-URL: https://github.com/nodejs/node/pull/45228
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2022-11-06 07:40:08 +00:00
Node.js GitHub Bot
9de4838192
meta: update AUTHORS
PR-URL: https://github.com/nodejs/node/pull/45333
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-11-06 06:55:48 +00:00
Facundo Tuesca
1f517130dd
tools: add automation for updating base64 dependency
Add a Github Action that checks for new versions of the `base64` C
library, and creates a PR to update it if a newer version than the one
present in the repo is found.

Refs: https://github.com/nodejs/security-wg/issues/828
PR-URL: https://github.com/nodejs/node/pull/45300
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2022-11-06 02:17:03 +00:00
Daeyeon Jeong
11ffb7e297
doc: add node: prefix for examples
Core modules are currently distinguished with the `node:` prefix.
This updates a few examples in docs to use the prefix for consistency.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/45328
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2022-11-05 21:53:23 +00:00
Luigi Pinca
28bf0317c2 deps: upgrade to libuv 1.44.2
Notable changes:

- Build regression fixes for various platform updates
  (https://github.com/libuv/libuv/pull/3428,
  https://github.com/libuv/libuv/pull/3419,
  https://github.com/libuv/libuv/pull/3423,
  https://github.com/libuv/libuv/pull/3413,
  https://github.com/libuv/libuv/pull/3431)
- Support for GNU/Hurd (https://github.com/libuv/libuv/pull/3450)
- Release tool improvements
  (https://github.com/libuv/libuv-release-tool/pull/13)
- Better performing rw locks on Win32 (https://github.com/libuv/libuv/pull/3383)
- Support for posix_spawn API (https://github.com/libuv/libuv/pull/3257)
- Fix regression on OpenBSD (https://github.com/libuv/libuv/pull/3506)
- Add uv_available_parallelism() (https://github.com/libuv/libuv/pull/3499)
- Don't use thread-unsafe strtok() (https://github.com/libuv/libuv/pull/3524)
- Fix hang after NOTE_EXIT (https://github.com/libuv/libuv/pull/3521)
- Better align order-of-events behavior between platforms
  (https://github.com/libuv/libuv/pull/3598)
- Fix fs event not fired if the watched file is moved/removed/recreated
  (https://github.com/libuv/libuv/pull/3540)
- Fix pipe resource leak if closed during connect (and other bugs)
  (https://github.com/libuv/libuv/pull/3611)
- Don't error when killing a zombie process
  (https://github.com/libuv/libuv/pull/3625)
- Avoid posix_spawnp() cwd bug (https://github.com/libuv/libuv/pull/3597)
- Skip EVFILT_PROC events when invalidating events for an fd
  (https://github.com/libuv/libuv/pull/3629)

Fixes: https://github.com/nodejs/node/issues/42290
PR-URL: https://github.com/nodejs/node/pull/42340
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-11-05 19:53:50 +01:00
Luigi Pinca
65ec9f35e9 test: defer invocation checks
Do not immediately check the `tcpserver` hook invocations when it
closes. Do it in the next iteration of the event loop.

PR-URL: https://github.com/nodejs/node/pull/42340
Refs: https://github.com/nodejs/node/pull/42340#issuecomment-1290964192
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-11-05 19:53:24 +01:00
Luigi Pinca
8dd635eb41 lib: use process.nextTick() instead of setImmediate()
Do not delay the call to `stream.end()` too much.

PR-URL: https://github.com/nodejs/node/pull/42340
Refs: https://github.com/nodejs/node/pull/42340#issuecomment-1261163284
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-11-05 19:53:13 +01:00
Luigi Pinca
60de1476ea test: fix test-socket-write-after-fin-error
The `'error'` event is not emitted because the socket is already
destroyed when `socket.write()` is called. Use the `socket.write()`
callback instead.

PR-URL: https://github.com/nodejs/node/pull/42340
Refs: https://github.com/nodejs/node/pull/42340#issuecomment-1182387070
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-11-05 19:53:03 +01:00
Luigi Pinca
58431c0e6b os: convert uid and gid to 32-bit signed integers
Make `os.userInfo()` convert the `uid` and `gid` fields to 32-bit signed
integers on Windows.

PR-URL: https://github.com/nodejs/node/pull/42340
Refs: https://github.com/libuv/libuv/commit/f3e0bffcb14
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-11-05 19:52:50 +01:00
Matteo Collina
3a81b47bd5
lib: drop fetch experimental warning
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/45287
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2022-11-05 15:15:07 +00:00
Stephen Belanger
2db03a63a8
diagnostics_channel: mark as stable
PR-URL: https://github.com/nodejs/node/pull/45290
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
2022-11-05 12:03:53 +00:00
RafaelGSS
7124476fb3
src: revert is_release to 0
PR-URL: https://github.com/nodejs/node/pull/45315
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2022-11-04 19:01:08 -04:00
Juan José Arboleda
58e8a8c58e 2022-11-04, Version 18.12.1 'Hydrogen' (LTS)
This is a security release.

Notable changes:

The following CVEs are fixed in this release:

- CVE-2022-3602: A buffer overrun can be triggered in X.509
                 certificate verification (High)
- CVE-2022-3786: A buffer overrun can be triggered in X.509
                 certificate verification (High)
- CVE-2022-43548: DNS rebinding in --inspect via invalid octal IP
                  address (Medium)

PR-URL: https://github.com/nodejs-private/node-private/pull/365
2022-11-04 14:26:35 -05:00
RafaelGSS
9fb612e61c deps: update archs files for quictls/openssl-3.0.7+quic
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
    $ make -C deps/openssl/config clean
    $ make -C deps/openssl/config
    $ git add deps/openssl/config/archs
    $ git add deps/openssl/openssl
    $ git commit

CVE-ID: CVE-2022-3602, CVE-2022-3786
PR-URL: https://github.com/nodejs/node/pull/45286
2022-11-04 14:56:43 -03:00
RafaelGSS
196a56d9a5 deps: upgrade openssl sources to quictls/openssl-3.0.7+quic
This updates all sources in deps/openssl/openssl by:
    $ git clone git@github.com:quictls/openssl.git
    $ cd openssl
    $ git checkout openssl-3.0.7+quic
    $ cd ../node/deps/openssl
    $ rm -rf openssl
    $ cp -R ../../../openssl openssl
    $ rm -rf openssl/.git* openssl/.travis*
    $ git add --all openssl
    $ git commit openssl

CVE-ID: CVE-2022-3602, CVE-2022-3786
PR-URL: https://github.com/nodejs/node/pull/45286
2022-11-04 14:56:36 -03:00
Tobias Nießen
4124b03774 inspector: harden IP address validation again
Use inet_pton() to parse IP addresses, which restricts IP addresses
to a small number of well-defined formats. In particular, octal and
hexadecimal number formats are not allowed, and neither are leading
zeros. Also explicitly reject 0.0.0.0/8 and ::/128 as non-routable.

Refs: https://hackerone.com/reports/1710652
CVE-ID: CVE-2022-43548
PR-URL: https://github.com/nodejs-private/node-private/pull/354
Reviewed-by: Michael Dawson <midawson@redhat.com>
Reviewed-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-by: Rich Trott <rtrott@gmail.com>
2022-11-04 14:56:31 -03:00
RafaelGSS
e4135a1de1 2022-11-04, Version 19.0.1 (Current)
This is a security release.

Notable changes:

The following CVEs are fixed in this release:

- CVE-2022-3786: A buffer overrun can be triggered in X.509
                 certificate verification (High)
- CVE-2022-3602: A buffer overrun can be triggered in X.509
                 certificate verification (High)
- CVE-2022-43548: DNS rebinding in --inspect via invalid octal IP
                  address (Medium)

PR-URL: https://github.com/nodejs-private/node-private/pull/366
2022-11-04 14:55:40 -03:00
Beth Griggs
81123b6658
2022-11-04, Version 16.18.1 'Gallium' (LTS)
This is a security release.

Notable changes:

The following CVEs are fixed in this release:

- CVE-2022-43548: DNS rebinding in --inspect via invalid octal IP
                  address (Medium)

PR-URL: https://github.com/nodejs-private/node-private/pull/363
2022-11-04 16:28:31 +00:00
Beth Griggs
7a14550e7c
2022-11-04, Version 14.21.1 'Fermium' (LTS)
This is a security release.

Notable changes:

The following CVEs are fixed in this release:

- CVE-2022-43548: DNS rebinding in --inspect via invalid octal IP
                  address (Medium)

PR-URL: https://github.com/nodejs-private/node-private/pull/362
2022-11-04 16:12:57 +00:00
Rich Trott
1af63a90ca
doc: update name of Node.js core Slack channel
The name has been changed from nodejs-dev to nodejs-core.

PR-URL: https://github.com/nodejs/node/pull/45293
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
2022-11-03 03:02:18 +00:00
Antoine du Hamel
a3874dd637
tools: fix request-ci-failed comment
PR-URL: https://github.com/nodejs/node/pull/45291
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2022-11-03 02:14:40 +00:00
andreysoktoev
cc5adc2d3b
doc: fix "task_processor.js" typo
PR-URL: https://github.com/nodejs/node/pull/45257
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-11-03 00:51:44 +00:00
theanarkh
070e111c65
report: add more memory info
PR-URL: https://github.com/nodejs/node/pull/45254
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2022-11-02 17:18:49 +00:00
Kohei Ueno
86088ab78e
lib: fix TypeError when converting a detached buffer source
PR-URL: https://github.com/nodejs/node/pull/44020
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-11-01 23:59:26 +00:00
Danielle Adams
f1e93820a7
2022-11-01, Version 14.21.0 'Fermium' (LTS)
Notable changes:

* deps:
  * update corepack to 0.14.2 (Node.js GitHub Bot) https://github.com/nodejs/node/pull/44775
* src:
  * add --openssl-shared-config option (Daniel Bevenius) https://github.com/nodejs/node/pull/43124

PR-URL: https://github.com/nodejs/node/pull/44889
2022-11-01 17:19:41 -04:00
Juan José
74d214761c
test: make test-eventemitter-asyncresource.js shorter
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/45146
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
2022-11-01 20:15:41 +00:00
Santiago Gimeno
5e74cb6076 src: print nghttp2 logs when using --debug-nghttp2
PR-URL: https://github.com/nodejs/node/pull/45209
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2022-11-01 20:05:23 +00:00
Santiago Gimeno
159cf51f87 build,win: pass --debug-nghttp2 to configure
PR-URL: https://github.com/nodejs/node/pull/45209
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2022-11-01 20:05:22 +00:00
Yagiz Nizipli
a5c6f3e8a1
fs: update todo message
PR-URL: https://github.com/nodejs/node/pull/45265
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2022-11-01 18:32:36 +00:00
Antoine du Hamel
acd6f6c608
tools: refactor dynamic strings creation in shell scripts
PR-URL: https://github.com/nodejs/node/pull/45240
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
2022-11-01 12:36:44 +00:00
Luke Karrys
590cf569fe
test: convert test-debugger-pid to async/await
PR-URL: https://github.com/nodejs/node/pull/45179
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2022-11-01 05:45:47 +00:00
Rich Trott
6ccb069c4e
meta: update collaborator email address in README
PR-URL: https://github.com/nodejs/node/pull/45251
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2022-11-01 05:25:00 +00:00
theanarkh
8fb282e2b4
src: trace threadpool event
PR-URL: https://github.com/nodejs/node/pull/44458
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2022-11-01 04:21:13 +00:00
Tho
a14fc49570
fs: fix opts.filter issue in cpSync
PR-URL: https://github.com/nodejs/node/pull/45143
Fixes: https://github.com/nodejs/node/issues/44720
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-11-01 02:44:15 +00:00
Antoine du Hamel
d6ee27445b
buffer: fix validation of options in Blob constructor
PR-URL: https://github.com/nodejs/node/pull/45156
Refs: https://webidl.spec.whatwg.org/#es-dictionary
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2022-11-01 00:47:51 +01:00
Yagiz Nizipli
17ae2ab750
fs: add recursive watch to linux
PR-URL: https://github.com/nodejs/node/pull/45098
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2022-10-31 23:15:45 +00:00
Jérémy Lal
3d1bdc954d
src: lock-free init_process_flags
Fix https://github.com/nodejs/node/issues/45152

PR-URL: https://github.com/nodejs/node/pull/45221
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
2022-10-31 20:45:00 +00:00
Bradley Farias
ccd81e8717
module: ensure relative requires work from deleted directories
PR-URL: https://github.com/nodejs/node/pull/42384
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2022-10-31 19:53:58 +00:00
Madhuri
4d723c7fd6
http: headers(Distinct), trailers(Distinct) setters to be no-op
PR-URL: https://github.com/nodejs/node/pull/45176
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2022-10-31 18:44:05 +00:00
Node.js GitHub Bot
548f505c3c
tools: update lint-md-dependencies
Update @rollup/plugin-commonjs@23.0.2,
@rollup/plugin-node-resolve@15.0.1, and
rollup@3.2.3.

PR-URL: https://github.com/nodejs/node/pull/45237
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-10-31 16:25:53 +00:00
Rich Trott
2a31d5a0f6
meta: fix email address typo in README
Refs: https://github.com/nodejs/node/pull/45249#issuecomment-1296576197
PR-URL: https://github.com/nodejs/node/pull/45250
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luke Karrys <luke@lukekarry.com>
2022-10-31 16:25:40 +00:00
Raz Luvaton
ddb3ae7c30
stream: add compose operator
PR-URL: https://github.com/nodejs/node/pull/44937
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
2022-10-31 13:57:02 +00:00
dnalborczyk
ffa2e964e8
lib: fix AbortSignal.timeout parameter validation
PR-URL: https://github.com/nodejs/node/pull/42856
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
2022-10-31 12:47:38 +00:00
Richard Lau
e43ecd5fec
test: fix textdecoder test for small-icu builds
The `Shift_JIS` encoding may not be available, e.g. when Node.js is
configured with `--with-intl=small-icu`.

PR-URL: https://github.com/nodejs/node/pull/45225
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
2022-10-30 19:52:37 +00:00