Commit Graph

36739 Commits

Author SHA1 Message Date
Tobias Nießen
7abbbf2ff3
test: change misleading variable name
The return value of getPrime() is not a private key in any way.

Refs: https://github.com/nodejs/node-v0.x-archive/pull/2638

PR-URL: https://github.com/nodejs/node/pull/43990
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-07-26 09:51:42 +01:00
Moshe Atlow
7a18ee8315
doc: add missing test runner option
PR-URL: https://github.com/nodejs/node/pull/43989
Refs: https://github.com/nodejs/node/pull/43554
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-07-26 05:43:56 +01:00
Rich Trott
d150ca69d8
tools: add verbose flag to find-inactive-collaborators
PR-URL: https://github.com/nodejs/node/pull/43964
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-07-26 05:08:27 +01:00
Geoffrey Booth
7ef40322b7
esm: move package config helpers
PR-URL: https://github.com/nodejs/node/pull/43967
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-07-26 05:08:18 +01:00
Bethany Nicolle Griggs
da2764bda3
doc: update email and mailmap for BethGriggs
PR-URL: https://github.com/nodejs/node/pull/43985
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-07-25 20:26:12 +01:00
Tobias Nießen
3e6e9084be
src: refactor DH groups to delete crypto_groups.h
Rewrite FindDiffieHellmanGroup() using OpenSSL helper functions to
obtain the required constants directly, instead of loading them from
our own crypto_groups.h and converting them to BIGNUMs.

This also removes the need for the struct modp_group, so we can delete
crypto_groups.h altogether.

PR-URL: https://github.com/nodejs/node/pull/43896
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
2022-07-25 19:37:14 +01:00
shhh7612
771e509420 doc: add 15.x - 18.x to Other Versions section
Added 15.x - 18.x changelog links to the Other Versions section.

PR-URL: https://github.com/nodejs/node/pull/43940
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
2022-07-25 23:59:26 +08:00
Kohei Ueno
536df6a439
test: update WPT encoding tests
PR-URL: https://github.com/nodejs/node/pull/43958
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-07-25 16:12:05 +01:00
Keyhan Vakil
9599700537 doc: inspector.close undefined in worker threads
In the main thread, `inspector.close` is defined as `process._debugEnd`:

```
> inspector.close
[Function: _debugEnd]
```

It's not defined in worker threads:
```
> const {Worker} = require("worker_threads");
> new Worker("console.log(require(\"inspector\").close)", {eval:true})
undefined
```

(As far as I can tell this is intentional and has existed for quite some
time.)

PR-URL: https://github.com/nodejs/node/pull/43867
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
2022-07-25 22:31:56 +08:00
Antoine du Hamel
81a68b37cf
doc: improve documentation for safe Promise statics alternatives
PR-URL: https://github.com/nodejs/node/pull/43759
Refs: https://github.com/nodejs/node/pull/43728
Reviewed-By: Feng Yu <F3n67u@outlook.com>
2022-07-25 15:01:22 +01:00
Tobias Nießen
899106f1a2
src: remove dead code in base64_encode
If mode == Base64Mode::NORMAL, then the function has already returned.

Refs: https://github.com/nodejs/node/pull/39775

PR-URL: https://github.com/nodejs/node/pull/43979
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
2022-07-25 15:01:14 +01:00
Antoine du Hamel
2e4bcfcb96
tools: add more options to track flaky tests
Refs: https://github.com/nodejs/node/pull/43929#issuecomment-1193104729

PR-URL: https://github.com/nodejs/node/pull/43954
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
2022-07-25 13:01:41 +01:00
Keyhan Vakil
10ee408e86
doc: recommend git-node-v8
Per the comments in #43924, almost everyone uses `git-node-v8`. I
included example steps for using `git-node-v8`.

I ran through both of these instructions on a clean Linux machine (I had
to fudge the patch SHA of course) and they seemed to work.

Refs: https://github.com/nodejs/node/pull/43924

PR-URL: https://github.com/nodejs/node/pull/43934
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2022-07-25 12:31:42 +01:00
Ben Noordhuis
ceb8f9c6eb deps: cherry-pick libuv/libuv@3a7b955
Original commit log follows:

darwin: translate EPROTOTYPE to ECONNRESET (libuv/libuv#3413)

macOS versions 10.10 and 10.15 - and presumbaly 10.11 to 10.14, too -
have a bug where a race condition causes the kernel to return EPROTOTYPE
because the socket isn't fully constructed.

It's probably the result of the peer closing the connection and that is
why libuv translates it to ECONNRESET.

Previously, libuv retried until the EPROTOTYPE error went away but some
VPN software causes the same behavior except the error is permanent, not
transient, turning the retry mechanism into an infinite loop.

Refs: https://github.com/libuv/libuv/pull/482
Refs: https://github.com/libuv/libuv/pull/3405
Fixes: https://github.com/nodejs/node/issues/43916

PR-URL: https://github.com/nodejs/node/pull/43950
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2022-07-25 09:47:59 +00:00
Ben Noordhuis
7287f44cdc deps: cherry-pick libuv/libuv@abb109f
Original commit log follows:

darwin: remove EPROTOTYPE error workaround (libuv/libuv#3405)

It's been reported in the past that OS X 10.10, because of a race
condition in the XNU kernel, sometimes returns a transient EPROTOTYPE
error when trying to write to a socket. Libuv handles that by retrying
the operation until it succeeds or fails with a different error.

Recently it's been reported that current versions of the operating
system formerly known as OS X fail permanently with EPROTOTYPE under
certain conditions, resulting in an infinite loop.

Because Apple isn't exactly forthcoming with bug fixes or even details,
I'm opting to simply remove the workaround and have the error bubble up.

Refs: https://github.com/libuv/libuv/pull/482
Fixes: https://github.com/nodejs/node/issues/43916

PR-URL: https://github.com/nodejs/node/pull/43950
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2022-07-25 09:47:57 +00:00
Daeyeon Jeong
9aef414b73
net: fix socket._getpeername
Fixes: https://github.com/nodejs/node/issues/43009

If calling `this._handle.getpeername` returns an error at the first
call, its result shouldn't be cached to `this._peername`.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: https://github.com/nodejs/node/pull/43010
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
2022-07-25 09:09:49 +01:00
Shelley Vohr
92e63426c0
inspector: set sampling interval before start
PR-URL: https://github.com/nodejs/node/pull/43779
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-07-25 05:37:17 +01:00
Feng Yu
2a7ac9298e
test: remove test-whatwg-events-add-event-listener-options-once.js
PR-URL: https://github.com/nodejs/node/pull/43877
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-07-25 00:06:32 +01:00
theanarkh
875840959d
trace_events: trace net connect event
PR-URL: https://github.com/nodejs/node/pull/43903
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
2022-07-25 00:06:20 +01:00
Keyhan Vakil
e8e92ec2d1
buffer: do not leak memory if buffer is too big
A recent pull request changed this method to throw when the buffer was
too big, but this meant that the `free` finalizer would never get
called, leading to a memory leak.

A previous version of this diff included a test provoking this behavior
with `v8.serialize`, but it unfortunately kept triggering the OOM
killer, so it was removed.

Refs: https://github.com/nodejs/node/pull/40243

PR-URL: https://github.com/nodejs/node/pull/43938
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2022-07-25 00:06:08 +01:00
Andreu Botella
f9b7380b42
test: work scheduled in process.nextTick can keep the event loop alive
PR-URL: https://github.com/nodejs/node/pull/43787
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
2022-07-25 00:59:25 +02:00
Lenvin Gonsalves
dab492f044
test_runner: add support for boolean values for concurrency option
PR-URL: https://github.com/nodejs/node/pull/43887
Fixes: https://github.com/nodejs/node/issues/43837
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
2022-07-24 23:41:46 +02:00
Antoine du Hamel
d83446b4c4
test_runner: validate timeout option
PR-URL: https://github.com/nodejs/node/pull/43843
Reviewed-By: Feng Yu <F3n67u@outlook.com>
2022-07-24 23:11:16 +02:00
Daeyeon Jeong
0c27ca4bc9
stream: improve respondWithNewView()
This fixes validating an ArrayBufferView given to
ReadableStreamBYOBRequest.respondWithNewView() to improve the web
streams compatibility.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: https://github.com/nodejs/node/pull/43866
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2022-07-24 17:56:48 +01:00
Tobias Nießen
3b4c0e45d0
test: simplify test-tls-set-secure-context
Instead of recursively scheduling makeRemainingRequests and ignoring its
outcome, safely loop within the async function.

Avoid unncessary async lambda functions passed to assert.rejects.

Use events.once() to simplify control flow in makeRequest, instead of
manually constructing a Promise.

PR-URL: https://github.com/nodejs/node/pull/43878
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-07-24 17:56:40 +01:00
Kohei Ueno
a324ea03d9
doc: clarify subprocess.stdout/in/err property
PR-URL: https://github.com/nodejs/node/pull/43910
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
2022-07-24 17:43:05 +01:00
cola119
223418adf5
src: fix regression that a source marker is lost
PR-URL: https://github.com/nodejs/node/pull/43086
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2022-07-25 00:17:35 +08:00
Node.js GitHub Bot
130bdf0b31
meta: update AUTHORS
PR-URL: https://github.com/nodejs/node/pull/43966
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-07-24 15:57:16 +01:00
Moshe Atlow
2e682f10b6
test_runner: pass signal on timeout
PR-URL: https://github.com/nodejs/node/pull/43911
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2022-07-24 15:16:10 +01:00
theanarkh
da3949cfd7
http: fix http server connection list when close
PR-URL: https://github.com/nodejs/node/pull/43949
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
2022-07-24 15:06:24 +01:00
Livia Medeiros
050d974a25
test: use common.mustNotMutateObjectDeep() in fs tests
PR-URL: https://github.com/nodejs/node/pull/43819
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-07-24 14:29:06 +01:00
Node.js GitHub Bot
eb4dca030d
deps: update corepack to 0.12.1
PR-URL: https://github.com/nodejs/node/pull/43965
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
2022-07-24 14:14:16 +01:00
theanarkh
8f0dee1a5b
test: fix test http upload timeout
PR-URL: https://github.com/nodejs/node/pull/43935
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-07-24 13:42:25 +01:00
Jianru Lin
746169de0e
doc: fix typo in src/crypto/README.md
PR-URL: https://github.com/nodejs/node/pull/43968
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-07-24 14:17:16 +02:00
Daeyeon Jeong
72fd06f7f0
meta: update node-api in label-pr-config
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: https://github.com/nodejs/node/pull/43794
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
2022-07-24 13:12:07 +01:00
Mark S. Miller
5abd9baea8
process: use defineProperty instead of assignment
PR-URL: https://github.com/nodejs/node/pull/43907
Fixes: https://github.com/nodejs/node/issues/43496
Refs: https://github.com/endojs/endo/issues/576
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
2022-07-24 14:09:29 +02:00
Keyhan Vakil
a9cb6723b5
doc: remind backporter about v8_embedder_string
There's already a reminder earlier in the instructions, but not in the
worked example, so it's easy to miss while skimming.

PR-URL: https://github.com/nodejs/node/pull/43924
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-07-24 13:01:14 +01:00
Rhys
294ccf39a6
util: remove unicode support todo for perf implications
PR-URL: https://github.com/nodejs/node/pull/43762
Refs: https://github.com/nodejs/node/pull/43721
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2022-07-24 13:56:52 +02:00
Robert Nagy
31d9edc849
stream: fix 0 transform hwm backpressure
PR-URL: https://github.com/nodejs/node/pull/43685
Refs: https://github.com/nodejs/node/issues/42457
Refs: https://github.com/nodejs/node/pull/43648/files
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2022-07-24 13:55:11 +02:00
theanarkh
c7ac42f009
cluster: send connection to other server when worker drop it
PR-URL: https://github.com/nodejs/node/pull/43747
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
2022-07-24 11:18:33 +01:00
jiahao.si
b0285836f7
dns: fix getServers return undefined
PR-URL: https://github.com/nodejs/node/pull/43922
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2022-07-24 11:18:20 +01:00
theanarkh
d63a4cbbd8
dns: fix cares memory leak
PR-URL: https://github.com/nodejs/node/pull/43912
Refs: https://github.com/nodejs/node/pull/39735
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-07-24 06:04:54 +01:00
Tobias Nießen
7ef069e483
test: simplify ReplStream.wait()
PR-URL: https://github.com/nodejs/node/pull/43857
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-07-23 21:44:26 +01:00
Finn Yu
df7c49c91d
lib: refactor PriorityQueue to use private field
PR-URL: https://github.com/nodejs/node/pull/43889
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
2022-07-23 21:44:18 +01:00
Moshe Atlow
069cec8004
deps: update hast-util-raw
PR-URL: https://github.com/nodejs/node/pull/43927
Fixes: https://github.com/nodejs/node/issues/43864
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
2022-07-23 21:25:24 +01:00
Airing
6244110bb9
doc: fix typo in http.md
the returns need to be lowercase

PR-URL: https://github.com/nodejs/node/pull/43933
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
2022-07-23 17:50:39 +01:00
Daeyeon Jeong
d29e78a780
events: expose CustomEvent on global with CLI flag
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: https://github.com/nodejs/node/pull/43885
Fixes: https://github.com/nodejs/node/issues/40678
Refs: https://github.com/nodejs/node/pull/43514
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
2022-07-23 14:39:08 +01:00
Feng Yu
dffcfdde34 doc: add F3n67u to collaborators
Fixes: https://github.com/nodejs/node/issues/43839

PR-URL: https://github.com/nodejs/node/pull/43953
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
2022-07-23 20:23:23 +08:00
legendecas
50d0cd5123
src: per-isolate eternal template properties
`FunctionTemplate` and `ObjectTemplate` can be shared across realms.
They should be per-isolate eternal handles and can not be modified.

As these templates are lazily initialized, their setters are still
exposed with DCHECK on their value presence.

PR-URL: https://github.com/nodejs/node/pull/43802
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2022-07-23 11:20:07 +08:00
Rich Trott
5fbf33ef86
tools: add verbose flag to inactive TSC finder
Refs: https://github.com/nodejs/node/pull/43897#issuecomment-1189682369

PR-URL: https://github.com/nodejs/node/pull/43913
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
2022-07-22 18:20:54 +01:00