fix: bad assumption about tls in server tests (#915)

This commit fixes a bad assumption that `connectTls` will throw on a
handshaking error. Really the TLS conn will only fail on first read or
write.

.github/workflows/ci.yml

@@ -13,7 +13,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        deno: [stable, canary]
+        # TODO(lucacasonato): reenable stable after 1.10 release
+        deno: [canary] # [stable, canary]
         os: [macOS-latest, ubuntu-latest, windows-2019]
 
     steps:

http/server_test.ts

@@ -720,17 +720,18 @@ Deno.test({
     const p = iteratorReq(server);
 
     try {
-      // Invalid certificate, connection should throw
+      // Invalid certificate, connection should throw on first read or write
       // but should not crash the server
-      assertThrowsAsync(
+      const badConn = await Deno.connectTls({
-        () =>
+        hostname: "localhost",
-          Deno.connectTls({
+        port,
-            hostname: "localhost",
+        // certFile
-            port,
+      });
-            // certFile
+      await assertThrowsAsync(
-          }),
+        () => badConn.read(new Uint8Array(1)),
         Deno.errors.InvalidData,
       );
+      badConn.close();
 
       // Valid request after invalid
       const conn = await Deno.connectTls({