diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 050b5ca92..d29816000 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,8 @@ jobs: strategy: fail-fast: false matrix: - deno: [stable, canary] + # TODO(lucacasonato): reenable stable after 1.10 release + deno: [canary] # [stable, canary] os: [macOS-latest, ubuntu-latest, windows-2019] steps: diff --git a/http/server_test.ts b/http/server_test.ts index b1e5f6b1b..35cb46802 100644 --- a/http/server_test.ts +++ b/http/server_test.ts @@ -720,17 +720,18 @@ Deno.test({ const p = iteratorReq(server); try { - // Invalid certificate, connection should throw + // Invalid certificate, connection should throw on first read or write // but should not crash the server - assertThrowsAsync( - () => - Deno.connectTls({ - hostname: "localhost", - port, - // certFile - }), + const badConn = await Deno.connectTls({ + hostname: "localhost", + port, + // certFile + }); + await assertThrowsAsync( + () => badConn.read(new Uint8Array(1)), Deno.errors.InvalidData, ); + badConn.close(); // Valid request after invalid const conn = await Deno.connectTls({