Koichiro Den 9c9201afeb mm/slab: fix warning caused by duplicate kmem_cache creation in kmem_buckets_create ... Commit b035f5a6d8 ("mm: slab: reduce the kmalloc() minimum alignment if DMA bouncing possible") reduced ARCH_KMALLOC_MINALIGN to 8 on arm64. However, with KASAN_HW_TAGS enabled, arch_slab_minalign() becomes 16. This causes kmalloc_caches[*][8] to be aliased to kmalloc_caches[*][16], resulting in kmem_buckets_create() attempting to create a kmem_cache for size 16 twice. This duplication triggers warnings on boot: [ 2.325108] ------------[ cut here ]------------ [ 2.325135] kmem_cache of name 'memdup_user-16' already exists [ 2.325783] WARNING: CPU: 0 PID: 1 at mm/slab_common.c:107 __kmem_cache_create_args+0xb8/0x3b0 [ 2.327957] Modules linked in: [ 2.328550] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.12.0-rc5mm-unstable-arm64+ #12 [ 2.328683] Hardware name: QEMU QEMU Virtual Machine, BIOS 2024.02-2 03/11/2024 [ 2.328790] pstate: 61000009 (nZCv daif -PAN -UAO -TCO +DIT -SSBS BTYPE=--) [ 2.328911] pc : __kmem_cache_create_args+0xb8/0x3b0 [ 2.328930] lr : __kmem_cache_create_args+0xb8/0x3b0 [ 2.328942] sp : ffff800083d6fc50 [ 2.328961] x29: ffff800083d6fc50 x28: f2ff0000c1674410 x27: ffff8000820b0598 [ 2.329061] x26: 000000007fffffff x25: 0000000000000010 x24: 0000000000002000 [ 2.329101] x23: ffff800083d6fce8 x22: ffff8000832222e8 x21: ffff800083222388 [ 2.329118] x20: f2ff0000c1674410 x19: f5ff0000c16364c0 x18: ffff800083d80030 [ 2.329135] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 [ 2.329152] x14: 0000000000000000 x13: 0a73747369786520 x12: 79646165726c6120 [ 2.329169] x11: 656820747563205b x10: 2d2d2d2d2d2d2d2d x9 : 0000000000000000 [ 2.329194] x8 : 0000000000000000 x7 : 0000000000000000 x6 : 0000000000000000 [ 2.329210] x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000000000 [ 2.329226] x2 : 0000000000000000 x1 : 0000000000000000 x0 : 0000000000000000 [ 2.329291] Call trace: [ 2.329407] __kmem_cache_create_args+0xb8/0x3b0 [ 2.329499] kmem_buckets_create+0xfc/0x320 [ 2.329526] init_user_buckets+0x34/0x78 [ 2.329540] do_one_initcall+0x64/0x3c8 [ 2.329550] kernel_init_freeable+0x26c/0x578 [ 2.329562] kernel_init+0x3c/0x258 [ 2.329574] ret_from_fork+0x10/0x20 [ 2.329698] ---[ end trace 0000000000000000 ]--- [ 2.403704] ------------[ cut here ]------------ [ 2.404716] kmem_cache of name 'msg_msg-16' already exists [ 2.404801] WARNING: CPU: 2 PID: 1 at mm/slab_common.c:107 __kmem_cache_create_args+0xb8/0x3b0 [ 2.404842] Modules linked in: [ 2.404971] CPU: 2 UID: 0 PID: 1 Comm: swapper/0 Tainted: G W 6.12.0-rc5mm-unstable-arm64+ #12 [ 2.405026] Tainted: [W]=WARN [ 2.405043] Hardware name: QEMU QEMU Virtual Machine, BIOS 2024.02-2 03/11/2024 [ 2.405057] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 2.405079] pc : __kmem_cache_create_args+0xb8/0x3b0 [ 2.405100] lr : __kmem_cache_create_args+0xb8/0x3b0 [ 2.405111] sp : ffff800083d6fc50 [ 2.405115] x29: ffff800083d6fc50 x28: fbff0000c1674410 x27: ffff8000820b0598 [ 2.405135] x26: 000000000000ffd0 x25: 0000000000000010 x24: 0000000000006000 [ 2.405153] x23: ffff800083d6fce8 x22: ffff8000832222e8 x21: ffff800083222388 [ 2.405169] x20: fbff0000c1674410 x19: fdff0000c163d6c0 x18: ffff800083d80030 [ 2.405185] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 [ 2.405201] x14: 0000000000000000 x13: 0a73747369786520 x12: 79646165726c6120 [ 2.405217] x11: 656820747563205b x10: 2d2d2d2d2d2d2d2d x9 : 0000000000000000 [ 2.405233] x8 : 0000000000000000 x7 : 0000000000000000 x6 : 0000000000000000 [ 2.405248] x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000000000 [ 2.405271] x2 : 0000000000000000 x1 : 0000000000000000 x0 : 0000000000000000 [ 2.405287] Call trace: [ 2.405293] __kmem_cache_create_args+0xb8/0x3b0 [ 2.405305] kmem_buckets_create+0xfc/0x320 [ 2.405315] init_msg_buckets+0x34/0x78 [ 2.405326] do_one_initcall+0x64/0x3c8 [ 2.405337] kernel_init_freeable+0x26c/0x578 [ 2.405348] kernel_init+0x3c/0x258 [ 2.405360] ret_from_fork+0x10/0x20 [ 2.405370] ---[ end trace 0000000000000000 ]--- To address this, alias kmem_cache for sizes smaller than min alignment to the aligned sized kmem_cache, as done with the default system kmalloc bucket. Fixes: b32801d125 ("mm/slab: Introduce kmem_buckets_create() and family") Cc: <stable@vger.kernel.org> # v6.11+ Signed-off-by: Koichiro Den <koichiro.den@gmail.com> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com> Tested-by: Catalin Marinas <catalin.marinas@arm.com> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>		2024-11-05 17:26:27 +01:00
..
damon	mm/damon/Kconfig: update DAMON doc URL	2024-09-26 14:01:44 -07:00
kasan	Rust changes for v6.12	2024-09-25 10:25:40 -07:00
kfence	mm: kfence: fix elapsed time for allocated/freed track	2024-09-26 14:01:44 -07:00
kmsan
backing-dev.c
balloon_compaction.c
bootmem_info.c
cma_debug.c
cma_sysfs.c
cma.c
cma.h
compaction.c
debug_page_alloc.c
debug_page_ref.c
debug_vm_pgtable.c	mm/debug_vm_pgtable: Use pxdp_get() for accessing page table entries	2024-09-17 01:07:01 -07:00
debug.c
dmapool_test.c
dmapool.c
early_ioremap.c
execmem.c
fadvise.c
fail_page_alloc.c
failslab.c
filemap.c	mm/filemap: fix filemap_get_folios_contig THP panic	2024-09-26 14:01:43 -07:00
folio-compat.c
gup_test.c
gup_test.h
gup.c	mm/hugetlb: simplify refs in memfd_alloc_folio	2024-09-26 14:01:44 -07:00
highmem.c
hmm.c
huge_memory.c	[tree-wide] finally take no_llseek out	2024-09-27 08:18:43 -07:00
hugetlb_cgroup.c
hugetlb_vmemmap.c
hugetlb_vmemmap.h
hugetlb.c	mm/hugetlb: fix memfd_pin_folios resv_huge_pages leak	2024-09-26 14:01:43 -07:00
hwpoison-inject.c
init-mm.c
internal.h	ALong with the usual shower of singleton patches, notable patch series in	2024-09-21 07:29:05 -07:00
interval_tree.c
io-mapping.c
ioremap.c
Kconfig	mm: make SPLIT_PTE_PTLOCKS depend on SMP	2024-09-26 14:01:43 -07:00
Kconfig.debug
khugepaged.c
kmemleak.c
ksm.c
list_lru.c
maccess.c
madvise.c	ALong with the usual shower of singleton patches, notable patch series in	2024-09-21 07:29:05 -07:00
Makefile
mapping_dirty_helpers.c
memblock.c	memblock: updates for 6.12-rc1	2024-09-25 11:35:19 -07:00
memcontrol-v1.c	struct fd layout change (and conversion to accessor helpers)	2024-09-23 09:35:36 -07:00
memcontrol-v1.h	memcg: cleanup with !CONFIG_MEMCG_V1	2024-09-17 01:07:00 -07:00
memcontrol.c	ALong with the usual shower of singleton patches, notable patch series in	2024-09-21 07:29:05 -07:00
memfd.c	mm/hugetlb: simplify refs in memfd_alloc_folio	2024-09-26 14:01:44 -07:00
memory_hotplug.c	ALong with the usual shower of singleton patches, notable patch series in	2024-09-21 07:29:05 -07:00
memory-failure.c
memory-tiers.c	memory tiers: use default_dram_perf_ref_source in log message	2024-09-26 14:01:44 -07:00
memory.c	ALong with the usual shower of singleton patches, notable patch series in	2024-09-21 07:29:05 -07:00
mempolicy.c
mempool.c
memremap.c
memtest.c
migrate_device.c
migrate.c	mm: migrate: annotate data-race in migrate_folio_unmap()	2024-09-26 14:01:44 -07:00
mincore.c
mlock.c
mm_init.c
mm_slot.h
mmap_lock.c
mmap.c	lsm/stable-6.12 PR 20240923	2024-09-24 10:18:15 -07:00
mmu_gather.c
mmu_notifier.c
mmzone.c
mprotect.c
mremap.c
mseal.c	ALong with the usual shower of singleton patches, notable patch series in	2024-09-21 07:29:05 -07:00
msync.c
nommu.c
numa_emulation.c
numa_memblks.c
numa.c
oom_kill.c
page_alloc.c	ALong with the usual shower of singleton patches, notable patch series in	2024-09-21 07:29:05 -07:00
page_counter.c
page_ext.c
page_idle.c
page_io.c	mm: fix swap_read_folio_zeromap() for large folios with partial zeromap	2024-09-17 01:07:01 -07:00
page_isolation.c
page_owner.c
page_poison.c
page_reporting.c
page_reporting.h
page_table_check.c
page_vma_mapped.c
page-writeback.c	ALong with the usual shower of singleton patches, notable patch series in	2024-09-21 07:29:05 -07:00
pagewalk.c	mm/pagewalk: check pfnmap for folio_walk_start()	2024-09-17 01:06:58 -07:00
percpu-internal.h
percpu-km.c
percpu-stats.c
percpu-vm.c
percpu.c
pgalloc-track.h
pgtable-generic.c
process_vm_access.c
ptdump.c
readahead.c	struct fd layout change (and conversion to accessor helpers)	2024-09-23 09:35:36 -07:00
rmap.c
rodata_test.c
secretmem.c
shmem_quota.c
shmem.c	\n	2024-09-23 10:49:28 -07:00
show_mem.c	mm/show_mem.c: report alloc tags in human readable units	2024-09-17 01:07:00 -07:00
shrinker_debug.c
shrinker.c
shuffle.c
shuffle.h
slab_common.c	mm/slab: fix warning caused by duplicate kmem_cache creation in kmem_buckets_create	2024-11-05 17:26:27 +01:00
slab.h	mm, slab: suppress warnings in test_leak_destroy kunit test	2024-10-02 16:28:46 +02:00
slub.c	mm, slab: suppress warnings in test_leak_destroy kunit test	2024-10-02 16:28:46 +02:00
sparse-vmemmap.c
sparse.c
swap_cgroup.c
swap_slots.c
swap_state.c	mm: add nr argument in mem_cgroup_swapin_uncharge_swap() helper to support large folios	2024-09-17 01:07:01 -07:00
swap.c
swap.h	mm: fix swap_read_folio_zeromap() for large folios with partial zeromap	2024-09-17 01:07:01 -07:00
swapfile.c
truncate.c
usercopy.c
userfaultfd.c	ALong with the usual shower of singleton patches, notable patch series in	2024-09-21 07:29:05 -07:00
util.c
vma_internal.h
vma.c	mm/vma: return the exact errno in vms_gather_munmap_vmas()	2024-09-17 01:07:00 -07:00
vma.h
vmalloc.c	ALong with the usual shower of singleton patches, notable patch series in	2024-09-21 07:29:05 -07:00
vmpressure.c
vmscan.c	ALong with the usual shower of singleton patches, notable patch series in	2024-09-21 07:29:05 -07:00
vmstat.c
workingset.c
z3fold.c
zbud.c
zpool.c
zsmalloc.c	ALong with the usual shower of singleton patches, notable patch series in	2024-09-21 07:29:05 -07:00
zswap.c