mirror of
https://github.com/torvalds/linux.git
synced 2024-11-22 04:38:03 +00:00
2c92ca849f
With the rework of how the __string() handles dynamic strings where it
saves off the source string in field in the helper structure[1], the
assignment of that value to the trace event field is stored in the helper
value and does not need to be passed in again.
This means that with:
__string(field, mystring)
Which use to be assigned with __assign_str(field, mystring), no longer
needs the second parameter and it is unused. With this, __assign_str()
will now only get a single parameter.
There's over 700 users of __assign_str() and because coccinelle does not
handle the TRACE_EVENT() macro I ended up using the following sed script:
git grep -l __assign_str | while read a ; do
sed -e 's/\(__assign_str([^,]*[^ ,]\) *,[^;]*/\1)/' $a > /tmp/test-file;
mv /tmp/test-file $a;
done
I then searched for __assign_str() that did not end with ';' as those
were multi line assignments that the sed script above would fail to catch.
Note, the same updates will need to be done for:
__assign_str_len()
__assign_rel_str()
__assign_rel_str_len()
I tested this with both an allmodconfig and an allyesconfig (build only for both).
[1] https://lore.kernel.org/linux-trace-kernel/20240222211442.634192653@goodmis.org/
Link: https://lore.kernel.org/linux-trace-kernel/20240516133454.681ba6a0@rorschach.local.home
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Christian König <christian.koenig@amd.com> for the amdgpu parts.
Acked-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> #for
Acked-by: Rafael J. Wysocki <rafael@kernel.org> # for thermal
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Darrick J. Wong <djwong@kernel.org> # xfs
Tested-by: Guenter Roeck <linux@roeck-us.net>
135 lines
2.7 KiB
C
135 lines
2.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Because linux/module.h has tracepoints in the header, and ftrace.h
|
|
* used to include this file, define_trace.h includes linux/module.h
|
|
* But we do not want the module.h to override the TRACE_SYSTEM macro
|
|
* variable that define_trace.h is processing, so we only set it
|
|
* when module events are being processed, which would happen when
|
|
* CREATE_TRACE_POINTS is defined.
|
|
*/
|
|
#ifdef CREATE_TRACE_POINTS
|
|
#undef TRACE_SYSTEM
|
|
#define TRACE_SYSTEM module
|
|
#endif
|
|
|
|
#if !defined(_TRACE_MODULE_H) || defined(TRACE_HEADER_MULTI_READ)
|
|
#define _TRACE_MODULE_H
|
|
|
|
#include <linux/tracepoint.h>
|
|
|
|
#ifdef CONFIG_MODULES
|
|
|
|
struct module;
|
|
|
|
#define show_module_flags(flags) __print_flags(flags, "", \
|
|
{ (1UL << TAINT_PROPRIETARY_MODULE), "P" }, \
|
|
{ (1UL << TAINT_OOT_MODULE), "O" }, \
|
|
{ (1UL << TAINT_FORCED_MODULE), "F" }, \
|
|
{ (1UL << TAINT_CRAP), "C" }, \
|
|
{ (1UL << TAINT_UNSIGNED_MODULE), "E" })
|
|
|
|
TRACE_EVENT(module_load,
|
|
|
|
TP_PROTO(struct module *mod),
|
|
|
|
TP_ARGS(mod),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( unsigned int, taints )
|
|
__string( name, mod->name )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->taints = mod->taints;
|
|
__assign_str(name);
|
|
),
|
|
|
|
TP_printk("%s %s", __get_str(name), show_module_flags(__entry->taints))
|
|
);
|
|
|
|
TRACE_EVENT(module_free,
|
|
|
|
TP_PROTO(struct module *mod),
|
|
|
|
TP_ARGS(mod),
|
|
|
|
TP_STRUCT__entry(
|
|
__string( name, mod->name )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__assign_str(name);
|
|
),
|
|
|
|
TP_printk("%s", __get_str(name))
|
|
);
|
|
|
|
#ifdef CONFIG_MODULE_UNLOAD
|
|
/* trace_module_get/put are only used if CONFIG_MODULE_UNLOAD is defined */
|
|
|
|
DECLARE_EVENT_CLASS(module_refcnt,
|
|
|
|
TP_PROTO(struct module *mod, unsigned long ip),
|
|
|
|
TP_ARGS(mod, ip),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( unsigned long, ip )
|
|
__field( int, refcnt )
|
|
__string( name, mod->name )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->ip = ip;
|
|
__entry->refcnt = atomic_read(&mod->refcnt);
|
|
__assign_str(name);
|
|
),
|
|
|
|
TP_printk("%s call_site=%ps refcnt=%d",
|
|
__get_str(name), (void *)__entry->ip, __entry->refcnt)
|
|
);
|
|
|
|
DEFINE_EVENT(module_refcnt, module_get,
|
|
|
|
TP_PROTO(struct module *mod, unsigned long ip),
|
|
|
|
TP_ARGS(mod, ip)
|
|
);
|
|
|
|
DEFINE_EVENT(module_refcnt, module_put,
|
|
|
|
TP_PROTO(struct module *mod, unsigned long ip),
|
|
|
|
TP_ARGS(mod, ip)
|
|
);
|
|
#endif /* CONFIG_MODULE_UNLOAD */
|
|
|
|
TRACE_EVENT(module_request,
|
|
|
|
TP_PROTO(char *name, bool wait, unsigned long ip),
|
|
|
|
TP_ARGS(name, wait, ip),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( unsigned long, ip )
|
|
__field( bool, wait )
|
|
__string( name, name )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->ip = ip;
|
|
__entry->wait = wait;
|
|
__assign_str(name);
|
|
),
|
|
|
|
TP_printk("%s wait=%d call_site=%ps",
|
|
__get_str(name), (int)__entry->wait, (void *)__entry->ip)
|
|
);
|
|
|
|
#endif /* CONFIG_MODULES */
|
|
|
|
#endif /* _TRACE_MODULE_H */
|
|
|
|
/* This part must be outside protection */
|
|
#include <trace/define_trace.h>
|