mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2024-11-21 19:46:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

x86/PCI: Check pcie_find_root_port() return for NULL

Browse Source 
If pcie_find_root_port() is unable to locate a Root Port, it will return
NULL. Check the pointer for NULL before dereferencing it.

This particular case is in a quirk for devices that are always below a Root
Port, so this won't avoid a problem and doesn't need to be backported, but
check as a matter of style and to prevent copy/paste mistakes.

Link: https://lore.kernel.org/r/20240812202659.1649121-1-samasth.norway.ananda@oracle.com
Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
[bhelgaas: drop Fixes: and explain why there's no problem in this case]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
This commit is contained in:
Samasth Norway Ananda 2024-08-12 13:26:59 -07:00 committed by Bjorn Helgaas
parent 8400291e28
commit dbc3171194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
arch/x86/pci/fixup.c
View File

@ -980,7 +980,7 @@ static void amd_rp_pme_suspend(struct pci_dev *dev)
return; return;
rp = pcie_find_root_port(dev); rp = pcie_find_root_port(dev);
if (!rp->pm_cap) if (!rp || !rp->pm_cap)
return; return;
rp->pme_support &= ~((PCI_PM_CAP_PME_D3hot|PCI_PM_CAP_PME_D3cold) >> rp->pme_support &= ~((PCI_PM_CAP_PME_D3hot|PCI_PM_CAP_PME_D3cold) >>
@ -994,7 +994,7 @@ static void amd_rp_pme_resume(struct pci_dev *dev)
u16 pmc; u16 pmc;
rp = pcie_find_root_port(dev); rp = pcie_find_root_port(dev);
if (!rp->pm_cap) if (!rp || !rp->pm_cap)
return; return;
pci_read_config_word(rp, rp->pm_cap + PCI_PM_PMC, &pmc); pci_read_config_word(rp, rp->pm_cap + PCI_PM_PMC, &pmc);