mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 04:38:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

gpio: sim: switch to device_for_each_child_node_scoped()

Browse Source 
Switch to device_for_each_child_node_scoped() to simplify the code by
removing the need for a call to fwnode_handle_put() in the error path.

This also prevents possible memory leaks if new error paths are added
without the required call to fwnode_handle_put().

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240928-gpio_device_for_each_child_node_scoped-v1-2-c20eff315f4f@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
This commit is contained in:
Javier Carrasco 2024-09-28 21:47:36 +02:00 committed by Bartosz Golaszewski
parent 0a53be8e08
commit d64d0287f4
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/gpio/gpio-sim.c
View File

@ -520,16 +520,13 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
static int gpio_sim_probe(struct platform_device *pdev) static int gpio_sim_probe(struct platform_device *pdev)
{ {
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct fwnode_handle *swnode;
int ret; int ret;
device_for_each_child_node(dev, swnode) { device_for_each_child_node_scoped(dev, swnode) {
ret = gpio_sim_add_bank(swnode, dev); ret = gpio_sim_add_bank(swnode, dev);
if (ret) { if (ret)
fwnode_handle_put(swnode);
return ret; return ret;
} }
}
return 0; return 0;
} }