mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 04:38:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

rtc: rx8111: demote warnings to debug level

Browse Source 
The proper way for userspace to react on a read time error is to have a
look at the voltage low information. There is no point in cluttering dmesg
as it is often not even visible to the end user.

Reviewed-by: Waqar Hameed <waqar.hameed@axis.com>
Link: https://lore.kernel.org/r/20240417191937.33790-1-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
Alexandre Belloni 2024-04-17 21:19:35 +02:00
parent 6a216cbadb
commit b7ff9efebc
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/rtc/rtc-rx8111.c
View File

@ -170,14 +170,14 @@ static int rx8111_read_time(struct device *dev, struct rtc_time *tm)
} }
if (FIELD_GET(RX8111_FLAG_XST_BIT, regval)) { if (FIELD_GET(RX8111_FLAG_XST_BIT, regval)) {
dev_warn(data->dev, dev_dbg(data->dev,
"Crystal oscillation stopped, time is not reliable\n"); "Crystal oscillation stopped, time is not reliable\n");
return -EINVAL; return -EINVAL;
} }
if (FIELD_GET(RX8111_FLAG_VLF_BIT, regval)) { if (FIELD_GET(RX8111_FLAG_VLF_BIT, regval)) {
dev_warn(data->dev, dev_dbg(data->dev,
"Low voltage detected, time is not reliable\n"); "Low voltage detected, time is not reliable\n");
return -EINVAL; return -EINVAL;
} }
@ -188,7 +188,7 @@ static int rx8111_read_time(struct device *dev, struct rtc_time *tm)
} }
if (regval) { if (regval) {
dev_warn(data->dev, "Clock stopped, time is not reliable\n"); dev_dbg(data->dev, "Clock stopped, time is not reliable\n");
return -EINVAL; return -EINVAL;
} }