mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 04:38:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

backlight: lm3509_bl: Fix early returns in for_each_child_of_node()

Browse Source 
The for_each_child_of_node() macro automatically decrements the child
refcount at the end of every iteration. On early exits, of_node_put()
must be used to manually decrement the refcount and avoid memory leaks.

The scoped version of the macro accounts for such early breaks, fixing
the early exits without the need for explicit calls to of_node_put().

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@inria.fr>
Closes: https://lore.kernel.org/r/202406172314.2vVgelaS-lkp@intel.com/
Fixes: b72755f5b5 ("backlight: Add new lm3509 backlight driver")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20240624-lm3509_bl_scoped-v1-1-ceba9df38f23@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Javier Carrasco 2024-06-24 17:30:50 +02:00 committed by Lee Jones
parent bfd3587760
commit b337cc3ce4
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/video/backlight/lm3509_bl.c
View File

@ -157,10 +157,9 @@ static int lm3509_parse_led_sources(struct device_node *node,
static int lm3509_parse_dt_node(struct device *dev, static int lm3509_parse_dt_node(struct device *dev,
struct lm3509_bl_led_data *led_data) struct lm3509_bl_led_data *led_data)
{ {
struct device_node *child;
int seen_led_sources = 0; int seen_led_sources = 0;
for_each_child_of_node(dev->of_node, child) { for_each_child_of_node_scoped(dev->of_node, child) {
struct lm3509_bl_led_data *ld; struct lm3509_bl_led_data *ld;
int ret; int ret;
u32 reg; u32 reg;