mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 04:38:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

mcb: lpc: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Johannes Thumshirn <jth@kernel.org>
Link: https://lore.kernel.org/r/cd04e21a7e2646bfe44b2304eea2b3fd0ee84018.1714379722.git.jth@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Uwe Kleine-König 2024-04-29 10:38:25 +02:00 committed by Greg Kroah-Hartman
parent 0b6896838d
commit a2c72ed78a
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/mcb/mcb-lpc.c
View File

@ -97,13 +97,11 @@ static int mcb_lpc_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int mcb_lpc_remove(struct platform_device *pdev) static void mcb_lpc_remove(struct platform_device *pdev)
{ {
struct priv *priv = platform_get_drvdata(pdev); struct priv *priv = platform_get_drvdata(pdev);
mcb_release_bus(priv->bus); mcb_release_bus(priv->bus);
return 0;
} }
static struct platform_device *mcb_lpc_pdev; static struct platform_device *mcb_lpc_pdev;
@ -140,7 +138,7 @@ static struct platform_driver mcb_lpc_driver = {
.name = "mcb-lpc", .name = "mcb-lpc",
}, },
.probe = mcb_lpc_probe, .probe = mcb_lpc_probe,
.remove = mcb_lpc_remove, .remove_new = mcb_lpc_remove,
}; };
static const struct dmi_system_id mcb_lpc_dmi_table[] = { static const struct dmi_system_id mcb_lpc_dmi_table[] = {