mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2024-11-21 19:46:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

remoteproc: k3-r5: Fix error handling when power-up failed

Browse Source 
By simply bailing out, the driver was violating its rule and internal
assumptions that either both or no rproc should be initialized. E.g.,
this could cause the first core to be available but not the second one,
leading to crashes on its shutdown later on while trying to dereference
that second instance.

Fixes: 61f6f68447 ("remoteproc: k3-r5: Wait for core0 power-up before powering up core1")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Acked-by: Beleswar Padhi <b-padhi@ti.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/9f481156-f220-4adf-b3d9-670871351e26@siemens.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
This commit is contained in:
Jan Kiszka 2024-08-19 17:24:51 +02:00 committed by Mathieu Poirier
parent ff555fc553
commit 9ab27eb586
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/remoteproc/ti_k3_r5_remoteproc.c
View File

@ -1313,7 +1313,7 @@ static int k3_r5_cluster_rproc_init(struct platform_device *pdev)
dev_err(dev, dev_err(dev,
"Timed out waiting for %s core to power up!\n", "Timed out waiting for %s core to power up!\n",
rproc->name); rproc->name);
return ret; goto err_powerup;
} }
} }
@ -1329,6 +1329,7 @@ static int k3_r5_cluster_rproc_init(struct platform_device *pdev)
} }
} }
err_powerup:
rproc_del(rproc); rproc_del(rproc);
err_add: err_add:
k3_r5_reserved_mem_exit(kproc); k3_r5_reserved_mem_exit(kproc);