mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 04:38:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ata: pata_serverworks: Do not use the term blacklist

Browse Source 
Let's not use the term blacklist in the function
serverworks_osb4_filter() documentation comment and rather simply refer
to what that function looks at: the list of devices with groken UDMA5.

While at it, also constify the values of the csb_bad_ata100 array.

Of note is that all of this should probably be handled using libata
quirk mechanism but it is unclear if these UDMA5 quirks are specific
to this controller only.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Reviewed-by: Igor Pylypiv <ipylypiv@google.com>
This commit is contained in:
Damien Le Moal 2024-07-26 10:58:36 +09:00
parent 58157d607a
commit 858048568c
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/ata/pata_serverworks.c
View File

@ -46,10 +46,11 @@
#define SVWKS_CSB5_REVISION_NEW 0x92 /* min PCI_REVISION_ID for UDMA5 (A2.0) */ #define SVWKS_CSB5_REVISION_NEW 0x92 /* min PCI_REVISION_ID for UDMA5 (A2.0) */
#define SVWKS_CSB6_REVISION 0xa0 /* min PCI_REVISION_ID for UDMA4 (A1.0) */ #define SVWKS_CSB6_REVISION 0xa0 /* min PCI_REVISION_ID for UDMA4 (A1.0) */
/* Seagate Barracuda ATA IV Family drives in UDMA mode 5 /*
* can overrun their FIFOs when used with the CSB5 */ * Seagate Barracuda ATA IV Family drives in UDMA mode 5
* can overrun their FIFOs when used with the CSB5.
static const char *csb_bad_ata100[] = { */
static const char * const csb_bad_ata100[] = {
"ST320011A", "ST320011A",
"ST340016A", "ST340016A",
"ST360021A", "ST360021A",
@ -163,10 +164,11 @@ static unsigned int serverworks_osb4_filter(struct ata_device *adev, unsigned in
* @adev: ATA device * @adev: ATA device
* @mask: Mask of proposed modes * @mask: Mask of proposed modes
* *
* Check the blacklist and disable UDMA5 if matched * Check the list of devices with broken UDMA5 and
* disable UDMA5 if matched.
*/ */
static unsigned int serverworks_csb_filter(struct ata_device *adev,
static unsigned int serverworks_csb_filter(struct ata_device *adev, unsigned int mask) unsigned int mask)
{ {
const char *p; const char *p;
char model_num[ATA_ID_PROD_LEN + 1]; char model_num[ATA_ID_PROD_LEN + 1];