mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2024-11-21 19:46:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

scsi: 3w-sas: Remove snprintf() from sysfs call-backs and replace with sysfs_emit()

Browse Source 
Since snprintf() has the documented, but still rather strange trait of
returning the length of the data that *would have been* written to the
array if space were available, rather than the arguably more useful
length of data *actually* written, it is usually considered wise to use
something else instead in order to avoid confusion.

In the case of sysfs call-backs, new wrappers exist that do just that.

Link: https://lwn.net/Articles/69419/
Link: https://github.com/KSPP/linux/issues/105
Cc: Adam Radford <aradford@gmail.com>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20240111131732.1815560-3-lee@kernel.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Lee Jones 2024-01-11 13:17:23 +00:00 committed by Martin K. Petersen
parent a977c8158a
commit 7eaa48e9e4
1 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
drivers/scsi/3w-sas.c
View File

@ -166,24 +166,24 @@ static ssize_t twl_show_stats(struct device *dev,
ssize_t len; ssize_t len;
spin_lock_irqsave(tw_dev->host->host_lock, flags); spin_lock_irqsave(tw_dev->host->host_lock, flags);
len = snprintf(buf, PAGE_SIZE, "3w-sas Driver version: %s\n" len = sysfs_emit(buf, "3w-sas Driver version: %s\n"
"Current commands posted: %4d\n" "Current commands posted: %4d\n"
"Max commands posted: %4d\n" "Max commands posted: %4d\n"
"Last sgl length: %4d\n" "Last sgl length: %4d\n"
"Max sgl length: %4d\n" "Max sgl length: %4d\n"
"Last sector count: %4d\n" "Last sector count: %4d\n"
"Max sector count: %4d\n" "Max sector count: %4d\n"
"SCSI Host Resets: %4d\n" "SCSI Host Resets: %4d\n"
"AEN's: %4d\n", "AEN's: %4d\n",
TW_DRIVER_VERSION, TW_DRIVER_VERSION,
tw_dev->posted_request_count, tw_dev->posted_request_count,
tw_dev->max_posted_request_count, tw_dev->max_posted_request_count,
tw_dev->sgl_entries, tw_dev->sgl_entries,
tw_dev->max_sgl_entries, tw_dev->max_sgl_entries,
tw_dev->sector_count, tw_dev->sector_count,
tw_dev->max_sector_count, tw_dev->max_sector_count,
tw_dev->num_resets, tw_dev->num_resets,
tw_dev->aen_count); tw_dev->aen_count);
spin_unlock_irqrestore(tw_dev->host->host_lock, flags); spin_unlock_irqrestore(tw_dev->host->host_lock, flags);
return len; return len;
} /* End twl_show_stats() */ } /* End twl_show_stats() */