mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 04:38:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

firewire: ohci: obsolete direct usage of printk_ratelimit()

Browse Source 
A commit 77006a0a82 ("ratelimit: add comment warning people off
printk_ratelimit()") has already deprecated printk_ratelimit().

This commit uses alternative functions to obsolete its usage.

Link: https://lore.kernel.org/r/20240903101523.317110-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit is contained in:
Takashi Sakamoto 2024-09-03 19:15:23 +09:00
parent cd70237298
commit 7d35a00603
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/firewire/ohci.c
View File

@ -2268,13 +2268,11 @@ static irqreturn_t irq_handler(int irq, void *data)
reg_read(ohci, OHCI1394_PostedWriteAddressLo); reg_read(ohci, OHCI1394_PostedWriteAddressLo);
reg_write(ohci, OHCI1394_IntEventClear, reg_write(ohci, OHCI1394_IntEventClear,
OHCI1394_postedWriteErr); OHCI1394_postedWriteErr);
if (printk_ratelimit()) dev_err_ratelimited(ohci->card.device, "PCI posted write error\n");
ohci_err(ohci, "PCI posted write error\n");
} }
if (unlikely(event & OHCI1394_cycleTooLong)) { if (unlikely(event & OHCI1394_cycleTooLong)) {
if (printk_ratelimit()) dev_notice_ratelimited(ohci->card.device, "isochronous cycle too long\n");
ohci_notice(ohci, "isochronous cycle too long\n");
reg_write(ohci, OHCI1394_LinkControlSet, reg_write(ohci, OHCI1394_LinkControlSet,
OHCI1394_LinkControl_cycleMaster); OHCI1394_LinkControl_cycleMaster);
} }
@ -2286,8 +2284,7 @@ static irqreturn_t irq_handler(int irq, void *data)
* stop active cycleMatch iso contexts now and restart * stop active cycleMatch iso contexts now and restart
* them at least two cycles later. (FIXME?) * them at least two cycles later. (FIXME?)
*/ */
if (printk_ratelimit()) dev_notice_ratelimited(ohci->card.device, "isochronous cycle inconsistent\n");
ohci_notice(ohci, "isochronous cycle inconsistent\n");
} }
if (unlikely(event & OHCI1394_unrecoverableError)) if (unlikely(event & OHCI1394_unrecoverableError))