mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 04:08:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

crypto: simd - Do not call crypto_alloc_tfm during registration

Browse Source 
Algorithm registration is usually carried out during module init,
where as little work as possible should be carried out.  The SIMD
code violated this rule by allocating a tfm, this then triggers a
full test of the algorithm which may dead-lock in certain cases.

SIMD is only allocating the tfm to get at the alg object, which is
in fact already available as it is what we are registering.  Use
that directly and remove the crypto_alloc_tfm call.

Also remove some obsolete and unused SIMD API.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Herbert Xu 2024-08-17 14:58:35 +08:00
parent 37da5d0ffa
commit 3c44d31cb3
4 changed files with 19 additions and 73 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/arm/crypto/aes-ce-glue.c
View File

@ -711,7 +711,7 @@ static int __init aes_init(void)
algname = aes_algs[i].base.cra_name + 2; algname = aes_algs[i].base.cra_name + 2;
drvname = aes_algs[i].base.cra_driver_name + 2; drvname = aes_algs[i].base.cra_driver_name + 2;
basename = aes_algs[i].base.cra_driver_name; basename = aes_algs[i].base.cra_driver_name;
simd = simd_skcipher_create_compat(algname, drvname, basename); simd = simd_skcipher_create_compat(aes_algs + i, algname, drvname, basename);
err = PTR_ERR(simd); err = PTR_ERR(simd);
if (IS_ERR(simd)) if (IS_ERR(simd))
goto unregister_simds; goto unregister_simds;

2
arch/arm/crypto/aes-neonbs-glue.c
View File

@ -491,7 +491,7 @@ static int __init aes_init(void)
algname = aes_algs[i].base.cra_name + 2; algname = aes_algs[i].base.cra_name + 2;
drvname = aes_algs[i].base.cra_driver_name + 2; drvname = aes_algs[i].base.cra_driver_name + 2;
basename = aes_algs[i].base.cra_driver_name; basename = aes_algs[i].base.cra_driver_name;
simd = simd_skcipher_create_compat(algname, drvname, basename); simd = simd_skcipher_create_compat(aes_algs + i, algname, drvname, basename);
err = PTR_ERR(simd); err = PTR_ERR(simd);
if (IS_ERR(simd)) if (IS_ERR(simd))
goto unregister_simds; goto unregister_simds;

72
crypto/simd.c
View File

@ -136,27 +136,19 @@ static int simd_skcipher_init(struct crypto_skcipher *tfm)
return 0; return 0;
} }
struct simd_skcipher_alg *simd_skcipher_create_compat(const char *algname, struct simd_skcipher_alg *simd_skcipher_create_compat(struct skcipher_alg *ialg,
const char *algname,
const char *drvname, const char *drvname,
const char *basename) const char *basename)
{ {
struct simd_skcipher_alg *salg; struct simd_skcipher_alg *salg;
struct crypto_skcipher *tfm;
struct skcipher_alg *ialg;
struct skcipher_alg *alg; struct skcipher_alg *alg;
int err; int err;
tfm = crypto_alloc_skcipher(basename, CRYPTO_ALG_INTERNAL,
CRYPTO_ALG_INTERNAL | CRYPTO_ALG_ASYNC);
if (IS_ERR(tfm))
return ERR_CAST(tfm);
ialg = crypto_skcipher_alg(tfm);
salg = kzalloc(sizeof(*salg), GFP_KERNEL); salg = kzalloc(sizeof(*salg), GFP_KERNEL);
if (!salg) { if (!salg) {
salg = ERR_PTR(-ENOMEM); salg = ERR_PTR(-ENOMEM);
goto out_put_tfm; goto out;
} }
salg->ialg_name = basename; salg->ialg_name = basename;
@ -195,30 +187,16 @@ struct simd_skcipher_alg *simd_skcipher_create_compat(const char *algname,
if (err) if (err)
goto out_free_salg; goto out_free_salg;
out_put_tfm: out:
crypto_free_skcipher(tfm);
return salg; return salg;
out_free_salg: out_free_salg:
kfree(salg); kfree(salg);
salg = ERR_PTR(err); salg = ERR_PTR(err);
goto out_put_tfm; goto out;
} }
EXPORT_SYMBOL_GPL(simd_skcipher_create_compat); EXPORT_SYMBOL_GPL(simd_skcipher_create_compat);
struct simd_skcipher_alg *simd_skcipher_create(const char *algname,
const char *basename)
{
char drvname[CRYPTO_MAX_ALG_NAME];
if (snprintf(drvname, CRYPTO_MAX_ALG_NAME, "simd-%s", basename) >=
CRYPTO_MAX_ALG_NAME)
return ERR_PTR(-ENAMETOOLONG);
return simd_skcipher_create_compat(algname, drvname, basename);
}
EXPORT_SYMBOL_GPL(simd_skcipher_create);
void simd_skcipher_free(struct simd_skcipher_alg *salg) void simd_skcipher_free(struct simd_skcipher_alg *salg)
{ {
crypto_unregister_skcipher(&salg->alg); crypto_unregister_skcipher(&salg->alg);
@ -246,7 +224,7 @@ int simd_register_skciphers_compat(struct skcipher_alg *algs, int count,
algname = algs[i].base.cra_name + 2; algname = algs[i].base.cra_name + 2;
drvname = algs[i].base.cra_driver_name + 2; drvname = algs[i].base.cra_driver_name + 2;
basename = algs[i].base.cra_driver_name; basename = algs[i].base.cra_driver_name;
simd = simd_skcipher_create_compat(algname, drvname, basename); simd = simd_skcipher_create_compat(algs + i, algname, drvname, basename);
err = PTR_ERR(simd); err = PTR_ERR(simd);
if (IS_ERR(simd)) if (IS_ERR(simd))
goto err_unregister; goto err_unregister;
@ -383,27 +361,19 @@ static int simd_aead_init(struct crypto_aead *tfm)
return 0; return 0;
} }
struct simd_aead_alg *simd_aead_create_compat(const char *algname, static struct simd_aead_alg *simd_aead_create_compat(struct aead_alg *ialg,
const char *algname,
const char *drvname, const char *drvname,
const char *basename) const char *basename)
{ {
struct simd_aead_alg *salg; struct simd_aead_alg *salg;
struct crypto_aead *tfm;
struct aead_alg *ialg;
struct aead_alg *alg; struct aead_alg *alg;
int err; int err;
tfm = crypto_alloc_aead(basename, CRYPTO_ALG_INTERNAL,
CRYPTO_ALG_INTERNAL | CRYPTO_ALG_ASYNC);
if (IS_ERR(tfm))
return ERR_CAST(tfm);
ialg = crypto_aead_alg(tfm);
salg = kzalloc(sizeof(*salg), GFP_KERNEL); salg = kzalloc(sizeof(*salg), GFP_KERNEL);
if (!salg) { if (!salg) {
salg = ERR_PTR(-ENOMEM); salg = ERR_PTR(-ENOMEM);
goto out_put_tfm; goto out;
} }
salg->ialg_name = basename; salg->ialg_name = basename;
@ -442,36 +412,20 @@ struct simd_aead_alg *simd_aead_create_compat(const char *algname,
if (err) if (err)
goto out_free_salg; goto out_free_salg;
out_put_tfm: out:
crypto_free_aead(tfm);
return salg; return salg;
out_free_salg: out_free_salg:
kfree(salg); kfree(salg);
salg = ERR_PTR(err); salg = ERR_PTR(err);
goto out_put_tfm; goto out;
} }
EXPORT_SYMBOL_GPL(simd_aead_create_compat);
struct simd_aead_alg *simd_aead_create(const char *algname, static void simd_aead_free(struct simd_aead_alg *salg)
const char *basename)
{
char drvname[CRYPTO_MAX_ALG_NAME];
if (snprintf(drvname, CRYPTO_MAX_ALG_NAME, "simd-%s", basename) >=
CRYPTO_MAX_ALG_NAME)
return ERR_PTR(-ENAMETOOLONG);
return simd_aead_create_compat(algname, drvname, basename);
}
EXPORT_SYMBOL_GPL(simd_aead_create);
void simd_aead_free(struct simd_aead_alg *salg)
{ {
crypto_unregister_aead(&salg->alg); crypto_unregister_aead(&salg->alg);
kfree(salg); kfree(salg);
} }
EXPORT_SYMBOL_GPL(simd_aead_free);
int simd_register_aeads_compat(struct aead_alg *algs, int count, int simd_register_aeads_compat(struct aead_alg *algs, int count,
struct simd_aead_alg **simd_algs) struct simd_aead_alg **simd_algs)
@ -493,7 +447,7 @@ int simd_register_aeads_compat(struct aead_alg *algs, int count,
algname = algs[i].base.cra_name + 2; algname = algs[i].base.cra_name + 2;
drvname = algs[i].base.cra_driver_name + 2; drvname = algs[i].base.cra_driver_name + 2;
basename = algs[i].base.cra_driver_name; basename = algs[i].base.cra_driver_name;
simd = simd_aead_create_compat(algname, drvname, basename); simd = simd_aead_create_compat(algs + i, algname, drvname, basename);
err = PTR_ERR(simd); err = PTR_ERR(simd);
if (IS_ERR(simd)) if (IS_ERR(simd))
goto err_unregister; goto err_unregister;

12
include/crypto/internal/simd.h
View File

@ -14,11 +14,10 @@
struct simd_skcipher_alg; struct simd_skcipher_alg;
struct skcipher_alg; struct skcipher_alg;
struct simd_skcipher_alg *simd_skcipher_create_compat(const char *algname, struct simd_skcipher_alg *simd_skcipher_create_compat(struct skcipher_alg *ialg,
const char *algname,
const char *drvname, const char *drvname,
const char *basename); const char *basename);
struct simd_skcipher_alg *simd_skcipher_create(const char *algname,
const char *basename);
void simd_skcipher_free(struct simd_skcipher_alg *alg); void simd_skcipher_free(struct simd_skcipher_alg *alg);
int simd_register_skciphers_compat(struct skcipher_alg *algs, int count, int simd_register_skciphers_compat(struct skcipher_alg *algs, int count,
@ -32,13 +31,6 @@ void simd_unregister_skciphers(struct skcipher_alg *algs, int count,
struct simd_aead_alg; struct simd_aead_alg;
struct aead_alg; struct aead_alg;
struct simd_aead_alg *simd_aead_create_compat(const char *algname,
const char *drvname,
const char *basename);
struct simd_aead_alg *simd_aead_create(const char *algname,
const char *basename);
void simd_aead_free(struct simd_aead_alg *alg);
int simd_register_aeads_compat(struct aead_alg *algs, int count, int simd_register_aeads_compat(struct aead_alg *algs, int count,
struct simd_aead_alg **simd_algs); struct simd_aead_alg **simd_algs);