mirror of
https://github.com/torvalds/linux.git
synced 2024-11-21 19:46:16 +00:00
char: xilinx_hwicap: Fix NULL vs IS_ERR() bug
The devm_platform_ioremap_resource() function returns error pointers.
It never returns NULL. Update the check accordingly.
Fixes: 6723718321
("char: xilinx_hwicap: Modernize driver probe")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Michal Simek <michal.simek@amd.com>
Link: https://lore.kernel.org/r/ef647a9c-b1b7-4338-9bc0-28165ec2a367@moroto.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
b44abdd294
commit
316459ba40
@ -639,8 +639,8 @@ static int hwicap_setup(struct platform_device *pdev, int id,
|
|||||||
dev_set_drvdata(dev, drvdata);
|
dev_set_drvdata(dev, drvdata);
|
||||||
|
|
||||||
drvdata->base_address = devm_platform_ioremap_resource(pdev, 0);
|
drvdata->base_address = devm_platform_ioremap_resource(pdev, 0);
|
||||||
if (!drvdata->base_address) {
|
if (IS_ERR(drvdata->base_address)) {
|
||||||
retval = -ENODEV;
|
retval = PTR_ERR(drvdata->base_address);
|
||||||
goto failed;
|
goto failed;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user