mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 04:38:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

init: replace deprecated strncpy with strscpy_pad

Browse Source 
strncpy() is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.

data_page wants to be NUL-terminated and NUL-padded, use strscpy_pad to
provide both of these. data_page no longer awkwardly relies on
init_mount to perform its NUL-termination, although that sanity check is
left unchanged.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Cc:  <linux-hardening@vger.kernel.org>
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20240402-strncpy-init-do_mounts-c-v1-1-e16d7bc20974@google.com
Signed-off-by: Kees Cook <keescook@chromium.org>
This commit is contained in:
Justin Stitt 2024-04-02 20:39:49 +00:00 committed by Kees Cook
parent 998b18072c
commit 07f8230b4b
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
init/do_mounts.c
View File

@ -159,8 +159,7 @@ static int __init do_mount_root(const char *name, const char *fs,
if (!p) if (!p)
return -ENOMEM; return -ENOMEM;
data_page = page_address(p); data_page = page_address(p);
/* zero-pad. init_mount() will make sure it's terminated */ strscpy_pad(data_page, data, PAGE_SIZE);
strncpy(data_page, data, PAGE_SIZE);
} }
ret = init_mount(name, "/root", fs, flags, data_page); ret = init_mount(name, "/root", fs, flags, data_page);