landlock: Support network rules with TCP bind and connect
Add network rules support in the ruleset management helpers and the
landlock_create_ruleset() syscall. Extend user space API to support
network actions:
* Add new network access rights: LANDLOCK_ACCESS_NET_BIND_TCP and
LANDLOCK_ACCESS_NET_CONNECT_TCP.
* Add a new network rule type: LANDLOCK_RULE_NET_PORT tied to struct
landlock_net_port_attr. The allowed_access field contains the network
access rights, and the port field contains the port value according to
the controlled protocol. This field can take up to a 64-bit value
but the maximum value depends on the related protocol (e.g. 16-bit
value for TCP). Network port is in host endianness [1].
* Add a new handled_access_net field to struct landlock_ruleset_attr
that contains network access rights.
* Increment the Landlock ABI version to 4.
Implement socket_bind() and socket_connect() LSM hooks, which enable
to control TCP socket binding and connection to specific ports.
Expand access_masks_t from u16 to u32 to be able to store network access
rights alongside filesystem access rights for rulesets' handled access
rights.
Access rights are not tied to socket file descriptors but checked at
bind() or connect() call time against the caller's Landlock domain. For
the filesystem, a file descriptor is a direct access to a file/data.
However, for network sockets, we cannot identify for which data or peer
a newly created socket will give access to. Indeed, we need to wait for
a connect or bind request to identify the use case for this socket.
Likewise a directory file descriptor may enable to open another file
(i.e. a new data item), but this opening is also restricted by the
caller's domain, not the file descriptor's access rights [2].
[1] https://lore.kernel.org/r/278ab07f-7583-a4e0-3d37-1bacd091531d@digikod.net
[2] https://lore.kernel.org/r/263c1eb3-602f-57fe-8450-3f138581bee7@digikod.net
Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
Link: https://lore.kernel.org/r/20231026014751.414649-9-konstantin.meskhidze@huawei.com
[mic: Extend commit message, fix typo in comments, and specify
endianness in the documentation]
Co-developed-by: Mickaël Salaün <mic@digikod.net>
Signed-off-by: Mickaël Salaün <mic@digikod.net>
2023-10-26 01:47:47 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
|
|
|
/*
|
|
|
|
* Landlock LSM - Network management and hooks
|
|
|
|
*
|
|
|
|
* Copyright © 2022-2023 Huawei Tech. Co., Ltd.
|
|
|
|
* Copyright © 2022-2023 Microsoft Corporation
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/in.h>
|
|
|
|
#include <linux/net.h>
|
|
|
|
#include <linux/socket.h>
|
|
|
|
#include <net/ipv6.h>
|
|
|
|
|
|
|
|
#include "common.h"
|
|
|
|
#include "cred.h"
|
|
|
|
#include "limits.h"
|
|
|
|
#include "net.h"
|
|
|
|
#include "ruleset.h"
|
|
|
|
|
|
|
|
int landlock_append_net_rule(struct landlock_ruleset *const ruleset,
|
|
|
|
const u16 port, access_mask_t access_rights)
|
|
|
|
{
|
|
|
|
int err;
|
|
|
|
const struct landlock_id id = {
|
|
|
|
.key.data = (__force uintptr_t)htons(port),
|
|
|
|
.type = LANDLOCK_KEY_NET_PORT,
|
|
|
|
};
|
|
|
|
|
|
|
|
BUILD_BUG_ON(sizeof(port) > sizeof(id.key.data));
|
|
|
|
|
|
|
|
/* Transforms relative access rights to absolute ones. */
|
|
|
|
access_rights |= LANDLOCK_MASK_ACCESS_NET &
|
|
|
|
~landlock_get_net_access_mask(ruleset, 0);
|
|
|
|
|
|
|
|
mutex_lock(&ruleset->lock);
|
|
|
|
err = landlock_insert_rule(ruleset, id, access_rights);
|
|
|
|
mutex_unlock(&ruleset->lock);
|
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2024-11-09 11:08:55 +00:00
|
|
|
static const struct access_masks any_net = {
|
|
|
|
.net = ~0,
|
|
|
|
};
|
landlock: Support network rules with TCP bind and connect
Add network rules support in the ruleset management helpers and the
landlock_create_ruleset() syscall. Extend user space API to support
network actions:
* Add new network access rights: LANDLOCK_ACCESS_NET_BIND_TCP and
LANDLOCK_ACCESS_NET_CONNECT_TCP.
* Add a new network rule type: LANDLOCK_RULE_NET_PORT tied to struct
landlock_net_port_attr. The allowed_access field contains the network
access rights, and the port field contains the port value according to
the controlled protocol. This field can take up to a 64-bit value
but the maximum value depends on the related protocol (e.g. 16-bit
value for TCP). Network port is in host endianness [1].
* Add a new handled_access_net field to struct landlock_ruleset_attr
that contains network access rights.
* Increment the Landlock ABI version to 4.
Implement socket_bind() and socket_connect() LSM hooks, which enable
to control TCP socket binding and connection to specific ports.
Expand access_masks_t from u16 to u32 to be able to store network access
rights alongside filesystem access rights for rulesets' handled access
rights.
Access rights are not tied to socket file descriptors but checked at
bind() or connect() call time against the caller's Landlock domain. For
the filesystem, a file descriptor is a direct access to a file/data.
However, for network sockets, we cannot identify for which data or peer
a newly created socket will give access to. Indeed, we need to wait for
a connect or bind request to identify the use case for this socket.
Likewise a directory file descriptor may enable to open another file
(i.e. a new data item), but this opening is also restricted by the
caller's domain, not the file descriptor's access rights [2].
[1] https://lore.kernel.org/r/278ab07f-7583-a4e0-3d37-1bacd091531d@digikod.net
[2] https://lore.kernel.org/r/263c1eb3-602f-57fe-8450-3f138581bee7@digikod.net
Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
Link: https://lore.kernel.org/r/20231026014751.414649-9-konstantin.meskhidze@huawei.com
[mic: Extend commit message, fix typo in comments, and specify
endianness in the documentation]
Co-developed-by: Mickaël Salaün <mic@digikod.net>
Signed-off-by: Mickaël Salaün <mic@digikod.net>
2023-10-26 01:47:47 +00:00
|
|
|
|
|
|
|
static int current_check_access_socket(struct socket *const sock,
|
|
|
|
struct sockaddr *const address,
|
|
|
|
const int addrlen,
|
2024-03-07 09:39:22 +00:00
|
|
|
access_mask_t access_request)
|
landlock: Support network rules with TCP bind and connect
Add network rules support in the ruleset management helpers and the
landlock_create_ruleset() syscall. Extend user space API to support
network actions:
* Add new network access rights: LANDLOCK_ACCESS_NET_BIND_TCP and
LANDLOCK_ACCESS_NET_CONNECT_TCP.
* Add a new network rule type: LANDLOCK_RULE_NET_PORT tied to struct
landlock_net_port_attr. The allowed_access field contains the network
access rights, and the port field contains the port value according to
the controlled protocol. This field can take up to a 64-bit value
but the maximum value depends on the related protocol (e.g. 16-bit
value for TCP). Network port is in host endianness [1].
* Add a new handled_access_net field to struct landlock_ruleset_attr
that contains network access rights.
* Increment the Landlock ABI version to 4.
Implement socket_bind() and socket_connect() LSM hooks, which enable
to control TCP socket binding and connection to specific ports.
Expand access_masks_t from u16 to u32 to be able to store network access
rights alongside filesystem access rights for rulesets' handled access
rights.
Access rights are not tied to socket file descriptors but checked at
bind() or connect() call time against the caller's Landlock domain. For
the filesystem, a file descriptor is a direct access to a file/data.
However, for network sockets, we cannot identify for which data or peer
a newly created socket will give access to. Indeed, we need to wait for
a connect or bind request to identify the use case for this socket.
Likewise a directory file descriptor may enable to open another file
(i.e. a new data item), but this opening is also restricted by the
caller's domain, not the file descriptor's access rights [2].
[1] https://lore.kernel.org/r/278ab07f-7583-a4e0-3d37-1bacd091531d@digikod.net
[2] https://lore.kernel.org/r/263c1eb3-602f-57fe-8450-3f138581bee7@digikod.net
Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
Link: https://lore.kernel.org/r/20231026014751.414649-9-konstantin.meskhidze@huawei.com
[mic: Extend commit message, fix typo in comments, and specify
endianness in the documentation]
Co-developed-by: Mickaël Salaün <mic@digikod.net>
Signed-off-by: Mickaël Salaün <mic@digikod.net>
2023-10-26 01:47:47 +00:00
|
|
|
{
|
|
|
|
__be16 port;
|
|
|
|
layer_mask_t layer_masks[LANDLOCK_NUM_ACCESS_NET] = {};
|
|
|
|
const struct landlock_rule *rule;
|
|
|
|
struct landlock_id id = {
|
|
|
|
.type = LANDLOCK_KEY_NET_PORT,
|
|
|
|
};
|
2024-11-09 11:08:55 +00:00
|
|
|
const struct landlock_ruleset *const dom =
|
|
|
|
landlock_get_applicable_domain(landlock_get_current_domain(),
|
|
|
|
any_net);
|
landlock: Support network rules with TCP bind and connect
Add network rules support in the ruleset management helpers and the
landlock_create_ruleset() syscall. Extend user space API to support
network actions:
* Add new network access rights: LANDLOCK_ACCESS_NET_BIND_TCP and
LANDLOCK_ACCESS_NET_CONNECT_TCP.
* Add a new network rule type: LANDLOCK_RULE_NET_PORT tied to struct
landlock_net_port_attr. The allowed_access field contains the network
access rights, and the port field contains the port value according to
the controlled protocol. This field can take up to a 64-bit value
but the maximum value depends on the related protocol (e.g. 16-bit
value for TCP). Network port is in host endianness [1].
* Add a new handled_access_net field to struct landlock_ruleset_attr
that contains network access rights.
* Increment the Landlock ABI version to 4.
Implement socket_bind() and socket_connect() LSM hooks, which enable
to control TCP socket binding and connection to specific ports.
Expand access_masks_t from u16 to u32 to be able to store network access
rights alongside filesystem access rights for rulesets' handled access
rights.
Access rights are not tied to socket file descriptors but checked at
bind() or connect() call time against the caller's Landlock domain. For
the filesystem, a file descriptor is a direct access to a file/data.
However, for network sockets, we cannot identify for which data or peer
a newly created socket will give access to. Indeed, we need to wait for
a connect or bind request to identify the use case for this socket.
Likewise a directory file descriptor may enable to open another file
(i.e. a new data item), but this opening is also restricted by the
caller's domain, not the file descriptor's access rights [2].
[1] https://lore.kernel.org/r/278ab07f-7583-a4e0-3d37-1bacd091531d@digikod.net
[2] https://lore.kernel.org/r/263c1eb3-602f-57fe-8450-3f138581bee7@digikod.net
Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
Link: https://lore.kernel.org/r/20231026014751.414649-9-konstantin.meskhidze@huawei.com
[mic: Extend commit message, fix typo in comments, and specify
endianness in the documentation]
Co-developed-by: Mickaël Salaün <mic@digikod.net>
Signed-off-by: Mickaël Salaün <mic@digikod.net>
2023-10-26 01:47:47 +00:00
|
|
|
|
|
|
|
if (!dom)
|
|
|
|
return 0;
|
|
|
|
if (WARN_ON_ONCE(dom->num_layers < 1))
|
|
|
|
return -EACCES;
|
|
|
|
|
|
|
|
/* Checks if it's a (potential) TCP socket. */
|
|
|
|
if (sock->type != SOCK_STREAM)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* Checks for minimal header length to safely read sa_family. */
|
|
|
|
if (addrlen < offsetofend(typeof(*address), sa_family))
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
switch (address->sa_family) {
|
|
|
|
case AF_UNSPEC:
|
|
|
|
case AF_INET:
|
|
|
|
if (addrlen < sizeof(struct sockaddr_in))
|
|
|
|
return -EINVAL;
|
|
|
|
port = ((struct sockaddr_in *)address)->sin_port;
|
|
|
|
break;
|
|
|
|
|
|
|
|
#if IS_ENABLED(CONFIG_IPV6)
|
|
|
|
case AF_INET6:
|
|
|
|
if (addrlen < SIN6_LEN_RFC2133)
|
|
|
|
return -EINVAL;
|
|
|
|
port = ((struct sockaddr_in6 *)address)->sin6_port;
|
|
|
|
break;
|
|
|
|
#endif /* IS_ENABLED(CONFIG_IPV6) */
|
|
|
|
|
|
|
|
default:
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Specific AF_UNSPEC handling. */
|
|
|
|
if (address->sa_family == AF_UNSPEC) {
|
|
|
|
/*
|
|
|
|
* Connecting to an address with AF_UNSPEC dissolves the TCP
|
|
|
|
* association, which have the same effect as closing the
|
|
|
|
* connection while retaining the socket object (i.e., the file
|
|
|
|
* descriptor). As for dropping privileges, closing
|
|
|
|
* connections is always allowed.
|
|
|
|
*
|
|
|
|
* For a TCP access control system, this request is legitimate.
|
|
|
|
* Let the network stack handle potential inconsistencies and
|
|
|
|
* return -EINVAL if needed.
|
|
|
|
*/
|
|
|
|
if (access_request == LANDLOCK_ACCESS_NET_CONNECT_TCP)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* For compatibility reason, accept AF_UNSPEC for bind
|
|
|
|
* accesses (mapped to AF_INET) only if the address is
|
|
|
|
* INADDR_ANY (cf. __inet_bind). Checking the address is
|
|
|
|
* required to not wrongfully return -EACCES instead of
|
|
|
|
* -EAFNOSUPPORT.
|
|
|
|
*
|
|
|
|
* We could return 0 and let the network stack handle these
|
|
|
|
* checks, but it is safer to return a proper error and test
|
|
|
|
* consistency thanks to kselftest.
|
|
|
|
*/
|
|
|
|
if (access_request == LANDLOCK_ACCESS_NET_BIND_TCP) {
|
|
|
|
/* addrlen has already been checked for AF_UNSPEC. */
|
|
|
|
const struct sockaddr_in *const sockaddr =
|
|
|
|
(struct sockaddr_in *)address;
|
|
|
|
|
|
|
|
if (sock->sk->__sk_common.skc_family != AF_INET)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (sockaddr->sin_addr.s_addr != htonl(INADDR_ANY))
|
|
|
|
return -EAFNOSUPPORT;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
/*
|
|
|
|
* Checks sa_family consistency to not wrongfully return
|
|
|
|
* -EACCES instead of -EINVAL. Valid sa_family changes are
|
|
|
|
* only (from AF_INET or AF_INET6) to AF_UNSPEC.
|
|
|
|
*
|
|
|
|
* We could return 0 and let the network stack handle this
|
|
|
|
* check, but it is safer to return a proper error and test
|
|
|
|
* consistency thanks to kselftest.
|
|
|
|
*/
|
|
|
|
if (address->sa_family != sock->sk->__sk_common.skc_family)
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
id.key.data = (__force uintptr_t)port;
|
|
|
|
BUILD_BUG_ON(sizeof(port) > sizeof(id.key.data));
|
|
|
|
|
|
|
|
rule = landlock_find_rule(dom, id);
|
2024-03-07 09:39:22 +00:00
|
|
|
access_request = landlock_init_layer_masks(
|
landlock: Support network rules with TCP bind and connect
Add network rules support in the ruleset management helpers and the
landlock_create_ruleset() syscall. Extend user space API to support
network actions:
* Add new network access rights: LANDLOCK_ACCESS_NET_BIND_TCP and
LANDLOCK_ACCESS_NET_CONNECT_TCP.
* Add a new network rule type: LANDLOCK_RULE_NET_PORT tied to struct
landlock_net_port_attr. The allowed_access field contains the network
access rights, and the port field contains the port value according to
the controlled protocol. This field can take up to a 64-bit value
but the maximum value depends on the related protocol (e.g. 16-bit
value for TCP). Network port is in host endianness [1].
* Add a new handled_access_net field to struct landlock_ruleset_attr
that contains network access rights.
* Increment the Landlock ABI version to 4.
Implement socket_bind() and socket_connect() LSM hooks, which enable
to control TCP socket binding and connection to specific ports.
Expand access_masks_t from u16 to u32 to be able to store network access
rights alongside filesystem access rights for rulesets' handled access
rights.
Access rights are not tied to socket file descriptors but checked at
bind() or connect() call time against the caller's Landlock domain. For
the filesystem, a file descriptor is a direct access to a file/data.
However, for network sockets, we cannot identify for which data or peer
a newly created socket will give access to. Indeed, we need to wait for
a connect or bind request to identify the use case for this socket.
Likewise a directory file descriptor may enable to open another file
(i.e. a new data item), but this opening is also restricted by the
caller's domain, not the file descriptor's access rights [2].
[1] https://lore.kernel.org/r/278ab07f-7583-a4e0-3d37-1bacd091531d@digikod.net
[2] https://lore.kernel.org/r/263c1eb3-602f-57fe-8450-3f138581bee7@digikod.net
Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
Link: https://lore.kernel.org/r/20231026014751.414649-9-konstantin.meskhidze@huawei.com
[mic: Extend commit message, fix typo in comments, and specify
endianness in the documentation]
Co-developed-by: Mickaël Salaün <mic@digikod.net>
Signed-off-by: Mickaël Salaün <mic@digikod.net>
2023-10-26 01:47:47 +00:00
|
|
|
dom, access_request, &layer_masks, LANDLOCK_KEY_NET_PORT);
|
2024-03-07 09:39:22 +00:00
|
|
|
if (landlock_unmask_layers(rule, access_request, &layer_masks,
|
landlock: Support network rules with TCP bind and connect
Add network rules support in the ruleset management helpers and the
landlock_create_ruleset() syscall. Extend user space API to support
network actions:
* Add new network access rights: LANDLOCK_ACCESS_NET_BIND_TCP and
LANDLOCK_ACCESS_NET_CONNECT_TCP.
* Add a new network rule type: LANDLOCK_RULE_NET_PORT tied to struct
landlock_net_port_attr. The allowed_access field contains the network
access rights, and the port field contains the port value according to
the controlled protocol. This field can take up to a 64-bit value
but the maximum value depends on the related protocol (e.g. 16-bit
value for TCP). Network port is in host endianness [1].
* Add a new handled_access_net field to struct landlock_ruleset_attr
that contains network access rights.
* Increment the Landlock ABI version to 4.
Implement socket_bind() and socket_connect() LSM hooks, which enable
to control TCP socket binding and connection to specific ports.
Expand access_masks_t from u16 to u32 to be able to store network access
rights alongside filesystem access rights for rulesets' handled access
rights.
Access rights are not tied to socket file descriptors but checked at
bind() or connect() call time against the caller's Landlock domain. For
the filesystem, a file descriptor is a direct access to a file/data.
However, for network sockets, we cannot identify for which data or peer
a newly created socket will give access to. Indeed, we need to wait for
a connect or bind request to identify the use case for this socket.
Likewise a directory file descriptor may enable to open another file
(i.e. a new data item), but this opening is also restricted by the
caller's domain, not the file descriptor's access rights [2].
[1] https://lore.kernel.org/r/278ab07f-7583-a4e0-3d37-1bacd091531d@digikod.net
[2] https://lore.kernel.org/r/263c1eb3-602f-57fe-8450-3f138581bee7@digikod.net
Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
Link: https://lore.kernel.org/r/20231026014751.414649-9-konstantin.meskhidze@huawei.com
[mic: Extend commit message, fix typo in comments, and specify
endianness in the documentation]
Co-developed-by: Mickaël Salaün <mic@digikod.net>
Signed-off-by: Mickaël Salaün <mic@digikod.net>
2023-10-26 01:47:47 +00:00
|
|
|
ARRAY_SIZE(layer_masks)))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
return -EACCES;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int hook_socket_bind(struct socket *const sock,
|
|
|
|
struct sockaddr *const address, const int addrlen)
|
|
|
|
{
|
|
|
|
return current_check_access_socket(sock, address, addrlen,
|
|
|
|
LANDLOCK_ACCESS_NET_BIND_TCP);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int hook_socket_connect(struct socket *const sock,
|
|
|
|
struct sockaddr *const address,
|
|
|
|
const int addrlen)
|
|
|
|
{
|
|
|
|
return current_check_access_socket(sock, address, addrlen,
|
|
|
|
LANDLOCK_ACCESS_NET_CONNECT_TCP);
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct security_hook_list landlock_hooks[] __ro_after_init = {
|
|
|
|
LSM_HOOK_INIT(socket_bind, hook_socket_bind),
|
|
|
|
LSM_HOOK_INIT(socket_connect, hook_socket_connect),
|
|
|
|
};
|
|
|
|
|
|
|
|
__init void landlock_add_net_hooks(void)
|
|
|
|
{
|
|
|
|
security_add_hooks(landlock_hooks, ARRAY_SIZE(landlock_hooks),
|
2023-09-12 20:56:46 +00:00
|
|
|
&landlock_lsmid);
|
landlock: Support network rules with TCP bind and connect
Add network rules support in the ruleset management helpers and the
landlock_create_ruleset() syscall. Extend user space API to support
network actions:
* Add new network access rights: LANDLOCK_ACCESS_NET_BIND_TCP and
LANDLOCK_ACCESS_NET_CONNECT_TCP.
* Add a new network rule type: LANDLOCK_RULE_NET_PORT tied to struct
landlock_net_port_attr. The allowed_access field contains the network
access rights, and the port field contains the port value according to
the controlled protocol. This field can take up to a 64-bit value
but the maximum value depends on the related protocol (e.g. 16-bit
value for TCP). Network port is in host endianness [1].
* Add a new handled_access_net field to struct landlock_ruleset_attr
that contains network access rights.
* Increment the Landlock ABI version to 4.
Implement socket_bind() and socket_connect() LSM hooks, which enable
to control TCP socket binding and connection to specific ports.
Expand access_masks_t from u16 to u32 to be able to store network access
rights alongside filesystem access rights for rulesets' handled access
rights.
Access rights are not tied to socket file descriptors but checked at
bind() or connect() call time against the caller's Landlock domain. For
the filesystem, a file descriptor is a direct access to a file/data.
However, for network sockets, we cannot identify for which data or peer
a newly created socket will give access to. Indeed, we need to wait for
a connect or bind request to identify the use case for this socket.
Likewise a directory file descriptor may enable to open another file
(i.e. a new data item), but this opening is also restricted by the
caller's domain, not the file descriptor's access rights [2].
[1] https://lore.kernel.org/r/278ab07f-7583-a4e0-3d37-1bacd091531d@digikod.net
[2] https://lore.kernel.org/r/263c1eb3-602f-57fe-8450-3f138581bee7@digikod.net
Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
Link: https://lore.kernel.org/r/20231026014751.414649-9-konstantin.meskhidze@huawei.com
[mic: Extend commit message, fix typo in comments, and specify
endianness in the documentation]
Co-developed-by: Mickaël Salaün <mic@digikod.net>
Signed-off-by: Mickaël Salaün <mic@digikod.net>
2023-10-26 01:47:47 +00:00
|
|
|
}
|