Go to file
Andi Kleen 3d06e9c3e0 Simplify switch bit test clustering algorithm
The current switch bit test clustering enumerates all possible case
clusters combinations to find ones that fit the bit test constrains
best.  This causes performance problems with very large switches.

For bit test clustering which happens naturally in word sized chunks
I don't think such an expensive algorithm is really needed.

This patch implements a simple greedy algorithm that walks
the sorted list and examines word sized windows and tries
to cluster them.

Surprisingly the new algorithm gives consistly better clusters
for the examples I tried.

For example from the gcc bootstrap:

old: 0-15 16-31 96-175
new: 0-31 96-175

I'm not fully sure why that is, probably some bug in the old
algorithm? This shows even up in the test suite where if-to-switch-6
now can generate a switch, as well as a case in switch-1.c

I don't have a proof that the new algorithm is always as good or better,
but so far at least I don't see any counter examples.

It also fixes the excessive compile time in PR117091,
however this was already fixed by an earlier patch
that doesn't run clustering when no targets have multiple
values.

gcc/ChangeLog:

	PR middle-end/117091
	* tree-switch-conversion.cc (bit_test_cluster::find_bit_tests):
	Change clustering algorithm to simple greedy.

gcc/testsuite/ChangeLog:

	* gcc.dg/tree-ssa/if-to-switch-6.c: Allow condition chain.
	* gcc.dg/tree-ssa/switch-1.c: Allow more bit tests.
	* gcc.dg/pr21643.c: Use -fno-bit-tests
	* gcc.target/aarch64/pr99988.c: Use -fno-bit-tests
2024-10-29 15:10:23 -07:00
.forgejo top-level: Add pull request template for Forgejo 2024-10-23 19:45:09 +01:00
.github
c++tools
config
contrib
fixincludes
gcc Simplify switch bit test clustering algorithm 2024-10-29 15:10:23 -07:00
gnattools
gotools
include Daily bump. 2024-10-26 00:19:39 +00:00
INSTALL
libada
libatomic
libbacktrace Daily bump. 2024-10-26 00:19:39 +00:00
libcc1
libcody
libcpp Daily bump. 2024-10-26 00:19:39 +00:00
libdecnumber
libffi Daily bump. 2024-10-26 00:19:39 +00:00
libgcc Daily bump. 2024-10-26 00:19:39 +00:00
libgfortran
libgm2
libgo runtime/testdata: fix for C23 nullptr keyword 2024-10-18 20:18:31 -07:00
libgomp Daily bump. 2024-10-23 00:19:43 +00:00
libgrust
libiberty
libitm
libobjc
libphobos
libquadmath
libsanitizer
libssp
libstdc++-v3 libstdc++: Fix complexity of drop_view::begin() const [PR112641] 2024-10-29 09:26:19 -04:00
libvtv
lto-plugin
maintainer-scripts
zlib
.b4-config
.dir-locals.el
.gitattributes
.gitignore
ABOUT-NLS
ar-lib
ChangeLog Daily bump. 2024-10-29 00:18:25 +00:00
ChangeLog.jit
ChangeLog.tree-ssa
compile
config-ml.in
config.guess
config.rpath
config.sub
configure build: update bootstrap req to C++14 2024-10-28 08:55:35 -04:00
configure.ac build: update bootstrap req to C++14 2024-10-28 08:55:35 -04:00
COPYING
COPYING3
COPYING3.LIB
COPYING.LIB
COPYING.RUNTIME
depcomp
install-sh
libtool-ldflags
libtool.m4
lt~obsolete.m4
ltgcc.m4
ltmain.sh
ltoptions.m4
ltsugar.m4
ltversion.m4
MAINTAINERS
Makefile.def
Makefile.in
Makefile.tpl
missing
mkdep
mkinstalldirs
move-if-change
multilib.am
README
SECURITY.txt
symlink-tree
test-driver
ylwrap

This directory contains the GNU Compiler Collection (GCC).

The GNU Compiler Collection is free software.  See the files whose
names start with COPYING for copying permission.  The manuals, and
some of the runtime libraries, are under different terms; see the
individual source files for details.

The directory INSTALL contains copies of the installation information
as HTML and plain text.  The source of this information is
gcc/doc/install.texi.  The installation information includes details
of what is included in the GCC sources and what files GCC installs.

See the file gcc/doc/gcc.texi (together with other files that it
includes) for usage and porting information.  An online readable
version of the manual is in the files gcc/doc/gcc.info*.

See http://gcc.gnu.org/bugs/ for how to report bugs usefully.

Copyright years on GCC source files may be listed using range
notation, e.g., 1987-2012, indicating that every year in the range,
inclusive, is a copyrightable year that could otherwise be listed
individually.