mirror/gcc
1
0
Fork 0
mirror of https://github.com/gcc-mirror/gcc.git synced 2024-11-21 13:40:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[libbacktrace] fix up broken test

Browse Source 
zstdtest has some inline data where some testcases lack the
uncompressed length field.  Thus it computes that but still
ends up allocating memory for the uncompressed buffer based on
that (zero) length.  Oops.  Causes memory corruption if the
allocator returns non-NULL.

libbacktrace/
	* zstdtest.c (test_samples): Properly compute the allocation
	size for the uncompressed data.
This commit is contained in:
Richard Biener 2023-08-03 15:21:51 +02:00
parent 9524718654
commit a9b6043983
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libbacktrace/zstdtest.c
View File

@ -197,7 +197,11 @@ test_samples (struct backtrace_state *state)
unsigned char *uncompressed;
size_t uncompressed_len;
uncompressed = (unsigned char *) malloc (tests[i].uncompressed_len);
uncompressed_len = tests[i].uncompressed_len;
if (uncompressed_len == 0)
uncompressed_len = strlen (tests[i].uncompressed);
uncompressed = (unsigned char *) malloc (uncompressed_len);
if (uncompressed == NULL)
{
perror ("malloc");
@ -206,10 +210,6 @@ test_samples (struct backtrace_state *state)
continue;
}
uncompressed_len = tests[i].uncompressed_len;
if (uncompressed_len == 0)
uncompressed_len = strlen (tests[i].uncompressed);
if (!backtrace_uncompress_zstd (state,
((const unsigned char *)
tests[i].compressed),