fix(proxy): correct the logic of bypass returning false (#14579)

packages/vite/src/node/server/middlewares/proxy.ts

@@ -154,7 +154,8 @@ export function proxyMiddleware(
             return next()
           } else if (bypassResult === false) {
             debug?.(`bypass: ${req.url} -> 404`)
-            return res.end(404)
+            res.statusCode = 404
+            return res.end()
           }
         }
 

playground/proxy-bypass/__tests__/proxy-hmr.spec.ts

@@ -0,0 +1,8 @@
+import { expect, test, vi } from 'vitest'
+import { browserLogs } from '~utils'
+
+test('proxy-bypass', async () => {
+  await vi.waitFor(() => {
+    expect(browserLogs.join('\n')).toContain('status of 404 (Not Found)')
+  })
+})

playground/proxy-bypass/index.html

@@ -0,0 +1,2 @@
+root app<br />
+<iframe src="/anotherApp" style="border: 0"></iframe>

playground/proxy-bypass/package.json

@@ -0,0 +1,11 @@
+{
+  "name": "@vitejs/test-proxy-bypass",
+  "private": true,
+  "version": "0.0.0",
+  "type": "module",
+  "scripts": {
+    "dev": "vite",
+    "build": "vite build",
+    "preview": "vite preview"
+  }
+}

playground/proxy-bypass/vite.config.js

@@ -0,0 +1,15 @@
+import { defineConfig } from 'vite'
+
+export default defineConfig({
+  server: {
+    port: 9606,
+    proxy: {
+      '/anotherApp': {
+        target: 'http://localhost:9607',
+        bypass: () => {
+          return false
+        },
+      },
+    },
+  },
+})

pnpm-lock.yaml

@@ -1030,6 +1030,8 @@ importers:
 
   playground/preserve-symlinks/module-a: {}
 
+  playground/proxy-bypass: {}
+
   playground/proxy-hmr: {}
 
   playground/proxy-hmr/other-app: {}