Vue/vite
1
0
Fork 0
mirror of https://github.com/vitejs/vite.git synced 2024-11-21 22:59:10 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

fix(lib): remove pure CSS dynamic import (#17601)

Browse Source
This commit is contained in:
Bjorn Lu 2024-07-02 17:49:19 +08:00 committed by GitHub
parent dafff4ae6e
commit 055f1c16e5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/vite/src/node/plugins/importAnalysisBuild.ts
View File

@ -403,7 +403,9 @@ export function buildImportAnalysisPlugin(config: ResolvedConfig): Plugin {
return
}
if (ssr || isWorker) {
// If preload is not enabled, we parse through each imports and remove any imports to pure CSS chunks
// as they are removed from the bundle
if (!insertPreload) {
const removedPureCssFiles = removedPureCssFilesCache.get(config)
if (removedPureCssFiles && removedPureCssFiles.size > 0) {
for (const file in bundle) {

8
playground/lib/__tests__/lib.spec.ts
View File

@ -67,6 +67,14 @@ describe.runIf(isBuild)('build', () => {
expect(code).toMatch(/await import\("\.\/message-[-\w]{8}.js"\)/)
})
test('Library mode does not have any reference to pure CSS chunks', async () => {
const code = readFile('dist/lib/dynamic-import-message.es.mjs')
// Does not import pure CSS chunks and replaced by `Promise.resolve({})` instead
expect(code).not.toMatch(/await import\("\.\/dynamic-[-\w]{8}.js"\)/)
expect(code).toMatch(/await Promise.resolve\(\{.*\}\)/)
})
test('@import hoist', async () => {
serverLogs.forEach((log) => {
// no warning from esbuild css minifier