A framework for building native applications using React
Go to file
Kræn Hansen c3091ccfed Fix podspec_source_build_from_local_source_dir to ensure the artifacts_dir exists before downloading into it (#47698)
Summary:
In its current for the `podspec_source_build_from_local_source_dir` makes an assumption in the existence of the `artifacts_dir` ("Pods/hermes-engine-artifacts"). This is okay in the case where the `pod install` command is first ran without sitting the `REACT_NATIVE_OVERRIDE_HERMES_DIR` because of

1948076b81/packages/react-native/sdks/hermes-engine/hermes-utils.rb (L227)

In a clean checkout however, this results in an error when archiving the Hermes directory due to the missing parent directory of the archive's destination.
This PR suggests adding a check for and optional creation of the existence of the archive directory before usage.

An alternative that I considered was ensuring the existence inside of the `artifacts_dir` function:

1948076b81/packages/react-native/sdks/hermes-engine/hermes-utils.rb (L198-L200)

But there's only one other call site, which already does the `mkdir -p`.

## Changelog:

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[IOS] [FIXED] - Ensure artifacts directory exists when building Hermes from local source

Pull Request resolved: https://github.com/facebook/react-native/pull/47698

Test Plan:
I verified the fix by:

- Doing a local git clone of the `hermes` repository.
- Ensure no `Pods` directory exists.
- `export REACT_NATIVE_OVERRIDE_HERMES_DIR=/your/local/path/to/hermes` pointing to the local `hermes` repository.
- Run `pod install`

Reviewed By: cipolleschi

Differential Revision: D66162175

Pulled By: dmytrorykun

fbshipit-source-id: 322633e217063e7ca199b9a9602e279df5fbdb70
2024-11-19 03:44:42 -08:00
.bundle Introduce Gemfile, ruby-version (#32303) 2021-10-01 21:22:26 -07:00
.circleci Remove CCI leftovers (#45589) 2024-07-23 06:40:08 -07:00
.github Only build ios in check nightlies (#47506) 2024-11-08 04:28:32 -08:00
flow-typed/npm dev-middleware: refactor tests to use undici.request (#47675) 2024-11-18 15:14:02 -08:00
gradle/wrapper Gradle to 8.10.2 (#46656) 2024-09-27 00:43:25 -07:00
jest Filter out AppRegistry logs from output (#47658) 2024-11-18 04:38:43 -08:00
packages Fix podspec_source_build_from_local_source_dir to ensure the artifacts_dir exists before downloading into it (#47698) 2024-11-19 03:44:42 -08:00
scripts Add Flow typing for test runner for RN integration tests (#47612) 2024-11-15 03:00:17 -08:00
tools RN: Fix sort-imports Lint Configuration (#47104) 2024-10-17 17:06:20 -07:00
.babelrc Move react-native-babel-transformer and react-native-babel-preset from Metro to React Native repo (#38228) 2023-07-27 11:48:16 -07:00
.clang-format Add QualifierAlignment to Clang Format Config (#44098) 2024-04-15 16:03:26 -07:00
.editorconfig Revert removal of CRLF from Windows bat files (#31398) 2021-09-09 22:44:32 -07:00
.eslintignore directly call community-cli-plugin in react-native-xcode.sh (#44721) 2024-06-05 09:08:16 -07:00
.eslintrc.js RN: Fix sort-imports Lint Configuration (#47104) 2024-10-17 17:06:20 -07:00
.flowconfig Enable ban_spread_key_props in xplat/js (#47636) 2024-11-15 14:18:51 -08:00
.gitignore Initial implementation of Jest test runner for RN integration tests (#47558) 2024-11-14 06:20:47 -08:00
.prettierignore Fixes enum codegen value cases (#44654) 2024-06-07 07:53:59 -07:00
.prettierrc Format code-workspace file, clarify use of .vscode/ dir (#44874) 2024-06-11 09:27:48 -07:00
build.gradle.kts Make build_android publish to the staging repositories (#45468) 2024-07-16 13:58:43 -07:00
CHANGELOG-pre-060.md split the changelog into decades (#38017) 2023-06-22 04:19:40 -07:00
CHANGELOG-pre-070.md Remove duplicate changelog entry (#38177) 2023-07-05 09:32:10 -07:00
CHANGELOG.md Add changelog for 0.76.2 (#47620) 2024-11-15 04:58:13 -08:00
CODE_OF_CONDUCT.md docs: add new version convenant contribuitor guide link (#32107) 2021-08-30 10:18:11 -07:00
CONTRIBUTING.md Update CONTRIBUTING.md, replace wiki links (#34035) 2022-06-21 19:30:23 -07:00
ECOSYSTEM.md Add @getsentry to React Native incubating partners list (#38091) 2023-06-27 10:48:43 -07:00
Gemfile Pin Xcodeproj to < 1.26.0 (#47237) 2024-10-28 04:20:31 -07:00
Gemfile.lock feat: add conditionals for iOS only code in RCTDeviceInfo.mm (#45176) 2024-06-28 06:02:38 -07:00
gradle.properties Bump AGP to 8.1.1 (#39392) 2023-09-12 09:21:08 -07:00
gradlew Gradle to 8.9 (#45407) 2024-07-12 09:00:39 -07:00
gradlew.bat Gradle to 8.10 (#46369) 2024-09-06 09:28:13 -07:00
jest.config.js fix: running local tests (#46615) 2024-09-25 05:51:49 -07:00
LICENSE Re-add the top level LICENSE file (#37916) 2023-06-15 13:14:17 -07:00
LICENSE-docs More licenses 2015-03-24 19:59:10 -07:00
package.json Deploy 0.253.0 to xplat (#47622) 2024-11-14 14:05:17 -08:00
react-native.code-workspace Format code-workspace file, clarify use of .vscode/ dir (#44874) 2024-06-11 09:27:48 -07:00
README.md docs: bump minSdk to 23 (#42034) 2023-12-21 22:29:00 -08:00
runXcodeTests.sh Use realpath instead of readlink 2022-02-22 02:23:02 -08:00
settings.gradle.kts Revert D59170923 (#45447) 2024-07-15 13:44:09 -07:00
yarn.lock Deploy 0.253.0 to xplat (#47622) 2024-11-14 14:05:17 -08:00

React Native

Learn once, write anywhere:
Build mobile apps with React.

React Native is released under the MIT license. Current CircleCI build status. Current npm package version. PRs welcome! Follow @reactnative

Getting Started · Learn the Basics · Showcase · Contribute · Community · Support

React Native brings React's declarative UI framework to iOS and Android. With React Native, you use native UI controls and have full access to the native platform.

  • Declarative. React makes it painless to create interactive UIs. Declarative views make your code more predictable and easier to debug.
  • Component-Based. Build encapsulated components that manage their state, then compose them to make complex UIs.
  • Developer Velocity. See local changes in seconds. Changes to JavaScript code can be live reloaded without rebuilding the native app.
  • Portability. Reuse code across iOS, Android, and other platforms.

React Native is developed and supported by many companies and individual core contributors. Find out more in our ecosystem overview.

Contents

📋 Requirements

React Native apps may target iOS 13.4 and Android 6.0 (API 23) or newer. You may use Windows, macOS, or Linux as your development operating system, though building and running iOS apps is limited to macOS. Tools like Expo can be used to work around this.

🎉 Building your first React Native app

Follow the Getting Started guide. The recommended way to install React Native depends on your project. Here you can find short guides for the most common scenarios:

📖 Documentation

The full documentation for React Native can be found on our website.

The React Native documentation discusses components, APIs, and topics that are specific to React Native. For further documentation on the React API that is shared between React Native and React DOM, refer to the React documentation.

The source for the React Native documentation and website is hosted on a separate repo, @facebook/react-native-website.

🚀 Upgrading

Upgrading to new versions of React Native may give you access to more APIs, views, developer tools, and other goodies. See the Upgrading Guide for instructions.

React Native releases are discussed in this discussion repo.

👏 How to Contribute

The main purpose of this repository is to continue evolving React Native core. We want to make contributing to this project as easy and transparent as possible, and we are grateful to the community for contributing bug fixes and improvements. Read below to learn how you can take part in improving React Native.

Code of Conduct

Facebook has adopted a Code of Conduct that we expect project participants to adhere to. Please read the full text so that you can understand what actions will and will not be tolerated.

Contributing Guide

Read our Contributing Guide to learn about our development process, how to propose bugfixes and improvements, and how to build and test your changes to React Native.

Open Source Roadmap

You can learn more about our vision for React Native in the Roadmap.

Good First Issues

We have a list of good first issues that contain bugs which have a relatively limited scope. This is a great place to get started, gain experience, and get familiar with our contribution process.

Discussions

Larger discussions and proposals are discussed in @react-native-community/discussions-and-proposals.

📄 License

React Native is MIT licensed, as found in the LICENSE file.

React Native documentation is Creative Commons licensed, as found in the LICENSE-docs file.