mirror of
https://github.com/facebook/react-native.git
synced 2024-11-21 22:10:14 +00:00
780fe80fca
Summary: Reverts https://github.com/facebook/react-native/pull/29012 It is not really possible to properly validate if ENTRY_FILE exists since it is resolved by metro, and the server is not always running from the app root, like in a monorepo with multiple RN apps running on the same metro server. In my case I run metro on the repo root and entry file will be something like `apps/app/index.js`. `-f "$ENTRY_FILE"` will fail since the script is run from the project folder (`PROJECT_ROOT`, in my case the `apps/app` folder, so it tries to resolve `apps/app/apps/app/index.js`). I don't think this check is actually useful since metro will report the error if the entry file is invalid (fixed in https://github.com/facebook/react-native/pull/30150). The error is not as user friendly, but I think it is still fine. Maybe it could be improved in metro. ## Changelog [iOS] [Fixed] - Don't validate ENTRY_FILE in react-native-xcode.sh Pull Request resolved: https://github.com/facebook/react-native/pull/32762 Test Plan: Before <img width="854" alt="image" src="https://user-images.githubusercontent.com/2677334/146100834-39310c9f-1767-496a-8698-1026726a1120.png"> After if file is actually missing <img width="987" alt="image" src="https://user-images.githubusercontent.com/2677334/146100893-d01e2247-c787-4174-ac60-2f308c338c8f.png"> After if file exists, builds successfully. Reviewed By: cortinico Differential Revision: D37066073 Pulled By: cipolleschi fbshipit-source-id: 8f6b149099a39d9179996bb965daa6cd9e06feac |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| circleci | ||
| cocoapods | ||
| codegen | ||
| hermes | ||
| react_native_pods_utils | ||
| versiontemplates | ||
| xcode | ||
| .packager.env | ||
| .tests.env | ||
| android-e2e-test.js | ||
| android-setup.sh | ||
| bump-oss-version.js | ||
| compose-source-maps.js | ||
| download-kotlin-compiler-with-buck.sh | ||
| find-node-for-xcode.sh | ||
| generate-api-docs.js | ||
| generate-artifacts.js | ||
| generate-provider-cli.js | ||
| generate-specs-cli.js | ||
| ios-configure-glog.sh | ||
| launchPackager.bat | ||
| launchPackager.command | ||
| lint-java.js | ||
| node-binary.sh | ||
| objc-test.sh | ||
| packager-reporter.js | ||
| packager.sh | ||
| prepare-package-for-release.js | ||
| process-podspecs.sh | ||
| publish-npm.js | ||
| react_native_pods.rb | ||
| react-native-xcode.sh | ||
| run_ruby_tests.sh | ||
| run-android-ci-instrumentation-tests.js | ||
| run-android-emulator.sh | ||
| run-android-local-integration-tests.sh | ||
| run-android-local-unit-tests.sh | ||
| run-ci-e2e-tests.js | ||
| run-ci-javascript-tests.js | ||
| run-instrumentation-tests-via-adb-shell.sh | ||
| set-rn-template-version.js | ||
| set-rn-version.js | ||
| sync-css-layout.sh | ||
| test-manual-e2e.sh | ||
| try-n-times.js | ||
| update_podfile_lock.sh | ||
| update-ruby.sh | ||
| validate-android-device-env.sh | ||
| validate-android-sdk.sh | ||
| validate-android-test-env.sh | ||
| validate-ios-test-env.sh | ||
| version-utils.js | ||
