mirror of
https://github.com/facebook/react-native.git
synced 2024-11-21 12:39:27 +00:00
4dd8d3db57
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/47608 This is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle. You have been added as a reviewer by Sentinel or Butterfly. Autodiff project: fileops2 Autodiff partition: xplat.js.react-native-github.packages.react-native.ReactCommon.cxxreact Autodiff bookmark: ad.fileops2.xplat.js.react-native-github.packages.react-native.ReactCommon.cxxreact This updates `open`, `close`, `read`, `write`, and `pipe` call sites to use `folly::fileops` qualified name lookup. This is the 2nd phase in a 3-phase change to remove folly's global definitions of the posix functions that conflict with windows CRT. The 1st phase created namespaces for folly's posix functions. The 2nd phase updates callsites to use the qualified name of folly's `open`, `close`, `read`, `write`, and `pipe` functions. The 3rd and final phase will remove folly's globally defined posix functions and have windows CRT define them again. **What is the reason for this change?** Folly's global definitions of posix functions on Windows causes `#include` order issues if folly is not included first. For example, when `gtest/gtest.h` is included before folly, gtest includes `windows.h` and that declares `open`, `read`, and `chdir`, which creates ambiguous references to folly's `open`, `read`, and `chdir`. Another example is where posix functions go undeclared when `folly/portability/windows.h` is included without other portability headers (e.g., `folly/portability/unistd.h`). `folly/portability/windows.h` includes `windows.h` in a way that only underscore versions of the posix functions are available (e.g., `_open`, `_close`). These issues create friction for windows development. **Background: What is the purpose of `folly::portability::{fcntl,stdlib,sysstat,unistd}`?** It is a portability layer to make posix functions available and behave consistently across platforms. Some posix functions don't exist on windows (e.g., `sysconf`). Some other posix functions, folly changes to adapt behavior across platforms. For example, on windows folly defines `open`, `read`, `write`, and `close` functions to work with sockets. Folly makes these functions available in the global scope for convenience. Changelog: [Internal] Reviewed By: javache Differential Revision: D65855147 fbshipit-source-id: b06863330ca213b9d1bffe0ee85e0fbf1bc8a845 |
||
|---|---|---|
| .. | ||
| assets | ||
| babel-plugin-codegen | ||
| community-cli-plugin | ||
| core-cli-utils | ||
| debugger-frontend | ||
| dev-middleware | ||
| eslint-config-react-native | ||
| eslint-plugin-react-native | ||
| eslint-plugin-specs | ||
| gradle-plugin | ||
| helloworld | ||
| hermes-inspector-msggen | ||
| metro-config | ||
| normalize-color | ||
| polyfills | ||
| react-native | ||
| react-native-babel-preset | ||
| react-native-babel-transformer | ||
| react-native-bots | ||
| react-native-codegen | ||
| react-native-codegen-typescript-test | ||
| react-native-info | ||
| react-native-popup-menu-android | ||
| react-native-test-library | ||
| react-native-test-renderer | ||
| rn-tester | ||
| typescript-config | ||
| virtualized-lists | ||