mirror of
https://github.com/facebook/react-native.git
synced 2024-11-21 20:50:09 +00:00
156454ef39
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/47689 We were seeing some segfaults from trying to access `display_` in Yoga's `replaceChild` function. Some memory debugging helped identify this was a use-after-free error and NickGerleman suggested we try swapping these lines. Logic being the shared_ptr of YogaLayoutableShadowNode is replaced right before we go and replace its yoga node in the yoga tree. If this is the last shared_ptr holding this node we will delete this object and thus the yoga node with it. We do not need to do this first, so let's swap the lines. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66142356 fbshipit-source-id: 8fd835346edc91e045ed2ee8945a95af21c47556 |
||
|---|---|---|
| .. | ||
| assets | ||
| babel-plugin-codegen | ||
| community-cli-plugin | ||
| core-cli-utils | ||
| debugger-frontend | ||
| dev-middleware | ||
| eslint-config-react-native | ||
| eslint-plugin-react-native | ||
| eslint-plugin-specs | ||
| gradle-plugin | ||
| helloworld | ||
| hermes-inspector-msggen | ||
| metro-config | ||
| normalize-color | ||
| polyfills | ||
| react-native | ||
| react-native-babel-preset | ||
| react-native-babel-transformer | ||
| react-native-bots | ||
| react-native-codegen | ||
| react-native-codegen-typescript-test | ||
| react-native-info | ||
| react-native-popup-menu-android | ||
| react-native-test-library | ||
| react-native-test-renderer | ||
| rn-tester | ||
| typescript-config | ||
| virtualized-lists | ||