Commit Graph

5 Commits

Author SHA1 Message Date
zhongwuzw
1a1795a537 Fixes enum codegen value cases (#44654)
Summary:
Fixes https://github.com/facebook/react-native/issues/44632

## Changelog:

[GENERAL] [FIXED] - [codegen] Fixes enum codegen value cases

Pull Request resolved: https://github.com/facebook/react-native/pull/44654

Test Plan: https://github.com/facebook/react-native/issues/44632

Reviewed By: cipolleschi, dmytrorykun

Differential Revision: D58135645

Pulled By: cortinico

fbshipit-source-id: 5c0634ef1d1d7375d2ecfcf7f916d67fd39b7300
2024-06-07 07:53:59 -07:00
Oskar Kwaśniewski
1e0fc76325 fix: add build generated files to *ignore config (#41826)
Summary:
This PR adds build generated files to *ignore config files. This allows to locally run `yarn lint`

## Changelog:

[INTERNAL] [ADDED] - Add build generated files to local config files

Pull Request resolved: https://github.com/facebook/react-native/pull/41826

Test Plan: CI Green

Reviewed By: huntie

Differential Revision: D51939024

Pulled By: cortinico

fbshipit-source-id: cfd6c1c13dd23c692859cd06fa5955024fafc522
2023-12-08 10:17:31 -08:00
Riccardo Cipolleschi
4deb29ae1b Make prettier ignore generated folders (#39076)
Summary:
This change introduce the `.prettierignore` file to skip some generated folders.
Prettier was checking that the JS files inside the Pods/ and the sdks/ folders were properly formatted.
However, we don't control those folders.

Running prettier in those folders was taking extra 10s to 30s on average, some time we can now save.

## Changelog:

[Internal] - Make prettier skip generated folders

Pull Request resolved: https://github.com/facebook/react-native/pull/39076

Test Plan:
Tested locally

| Before | After |
| --- | --- |
| <img width="593" alt="Screenshot 2023-08-18 at 11 28 51" src="https://github.com/facebook/react-native/assets/11162307/65eb773b-1966-49cd-bd51-6310fe48cf3b"> | <img width="515" alt="Screenshot 2023-08-18 at 11 29 09" src="https://github.com/facebook/react-native/assets/11162307/969ff9e4-f05b-43bf-9a95-7b37dea7d3d0"> |

Reviewed By: christophpurrer

Differential Revision: D48466583

Pulled By: cipolleschi

fbshipit-source-id: 60a4335af2c337c6d3d143d8d5b56d4a41073feb
2023-08-18 08:42:13 -07:00
Tim Yung
280e4ce4fe RN: Change @{ => no}format in React Files
Summary:
Instead of using `.prettierrc` to ignore the files sync'd from React, replace `format` with `noformat`.

This is necessary because currently, the version of Prettier used in React Native (v2.4.1) differs from the version used in React (v1.19.1). We can revert this when React is upgraded.

Changelog:
[Internal]

Reviewed By: ShikaSD

Differential Revision: D32129937

fbshipit-source-id: ca3b379edd732670a9a0b1b20b3f31bdad4b74aa
2021-11-09 00:33:12 -08:00
Tim Yung
32f36fe105 RN: Fix Prettier Formatting Errors (#32524)
Summary:
Ignores the `Libraries/Renderer/` directory of files which are synchronized from React (and should not be modified).

Also, formats some EventEmitter modules that for some reason were missed when I upgraded to Prettier v2.x.

## Changelog

[Internal]

Pull Request resolved: https://github.com/facebook/react-native/pull/32524

Test Plan:
```
yarn run format-check
```

Reviewed By: javache

Differential Revision: D32129837

Pulled By: yungsters

fbshipit-source-id: 1cb42cec210508db499850e13f77beefdb35eb25
2021-11-09 00:33:12 -08:00