React/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2024-11-21 22:10:14 +00:00
Code Issues Actions 10 Packages Projects Releases Wiki Activity

Add support for Buck oncall annotations (#35562)

Browse Source 
Summary:
Newer versions of Buck (not released open source) support an `oncall` annotation to denote who owns a particular BUCK file. These annotations are useful to support so that if BUCK files are updated with such annotations they don't break.

## Changelog

[Internal] [Changed] - support oncall annotation in BUCK files

Pull Request resolved: https://github.com/facebook/react-native/pull/35562

Test Plan: The `test_buck` CI job validates that the file can be evaluated by open-source Buck. I ran this on a CircleCI fork, and it passed.

Reviewed By: motiz88

Differential Revision: D41731925

Pulled By: cortinico

fbshipit-source-id: 7d0ae164c3e6289d4aa76892658d46bbe4faf99c
This commit is contained in:
Neil Mitchell 2022-12-05 06:12:46 -08:00 committed by Facebook GitHub Bot
parent 032bed45a9
commit bdb2fd6979
3 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.buckconfig
View File

@ -15,3 +15,6 @@
[alias]
rntester = //packages/rn-tester/android/app:app
[buildfile]
includes = //tools/build_defs/oss/preload.bzl

2
ReactAndroid/src/main/java/com/facebook/react/BUCK
View File

@ -1,5 +1,7 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_target", "rn_android_library")
oncall("react_native")
rn_android_library(
name = "react",
srcs = glob(["*.java"]),

4
tools/build_defs/oss/preload.bzl Normal file
View File

@ -0,0 +1,4 @@
# These are symbols that are available in newer versions of Buck, but not the open source one.
def oncall(_team):
pass