From ac0dbe1ea2b313de45536816fadfbd907d221f55 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Wed, 20 Nov 2024 23:08:03 -0800 Subject: [PATCH] Migrate ReactClippingProhibitedView to Kotlin (#47752) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/47752 Migrate ReactClippingProhibitedView to Kotlin changelog: [internal] internal Reviewed By: javache Differential Revision: D66217071 fbshipit-source-id: e7559db5c3f2795b78f51c3bd5a3f521eb54b70d --- ...bitedView.java => ReactClippingProhibitedView.kt} | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) rename packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/{ReactClippingProhibitedView.java => ReactClippingProhibitedView.kt} (60%) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactClippingProhibitedView.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactClippingProhibitedView.kt similarity index 60% rename from packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactClippingProhibitedView.java rename to packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactClippingProhibitedView.kt index 66b1c72e048..f28973157dd 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactClippingProhibitedView.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactClippingProhibitedView.kt @@ -5,22 +5,22 @@ * LICENSE file in the root directory of this source tree. */ -package com.facebook.react.uimanager; +package com.facebook.react.uimanager /** * Some Views may not function if added directly to a ViewGroup that clips them. For example, TTRC * markers may rely on `onDraw` functionality to work properly, and will break if they're clipped * out of the View hierarchy for any resaon. * - *

This situation can occur more often in Fabric with View Flattening. We may prevent this sort - * of View Flattening from occurring in the future, but the connection is not entirely certain. + * This situation can occur more often in Fabric with View Flattening. We may prevent this sort of + * View Flattening from occurring in the future, but the connection is not entirely certain. * - *

This can occur either because ReactViewGroup clips them out, using the ordinarary subview + * This can occur either because ReactViewGroup clips them out, using the ordinarary subview * clipping feature. It is also possible if a View is added directly to a ReactRootView below the * fold of the screen. * - *

Generally the solution is to prevent View flattening in JS by adding `collapsable=false` to a + * Generally the solution is to prevent View flattening in JS by adding `collapsable=false` to a * parent component of the clipped view, and/or move the View higher up in the hierarchy so it is * always rendered within the first page of the screen. */ -public interface ReactClippingProhibitedView {} +public interface ReactClippingProhibitedView