React/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2024-11-22 06:29:46 +00:00
Code Issues Actions 15 Packages Projects Releases Wiki Activity

Back out "RN: Switch to Choco-Install from Windows Hermes CI" (#34818)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/34818

Original commit changeset: 69c03845d2f2

I had to back this out because Choco-Install is not recognized by CircleCI and currently the OSS pipeline is broken.

This didn't happen in previous Jobs because Hermes has not changed and the build was skipped.
See [this job](https://app.circleci.com/pipelines/github/facebook/react-native/16088/workflows/d9e1c028-9422-4609-ba9f-6c35460efbb5/jobs/303255?invite=true#step-104-40) for example.

## Changelog
[General][Fixed] - Fix the Windows Pipeline

Reviewed By: cortinico

Differential Revision: D39928281

fbshipit-source-id: be641efe026a9d3f7cd75943e9b7a39ab1673e18
This commit is contained in:
Riccardo Cipolleschi 2022-09-29 07:22:39 -07:00 committed by Facebook GitHub Bot
parent 4a336f0637
commit 8bb9717faa
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.circleci/config.yml
View File

@ -1204,9 +1204,9 @@ jobs:
name: Build HermesC for Windows
command: |
if (-not(Test-Path -Path $Env:HERMES_WS_DIR\win64-bin\hermesc.exe)) {
Choco-Install -PackageName cmake -ArgumentList "--no-progress", "--version 3.14.7"
choco install --no-progress cmake --version 3.14.7
if (-not $?) { throw "Failed to install CMake" }
Choco-Install -PackageName python3 -ArgumentList "--no-progress"
choco install --no-progress python3
if (-not $?) { throw "Failed to install Python" }
cd $Env:HERMES_WS_DIR\icu