From 7e0bdcb7800cef787bf4c4a168ec0a368b8d2e24 Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Mon, 18 Nov 2024 07:34:43 -0800 Subject: [PATCH] Back out "fix(iOS): unify prefetchImageWithMetadata's signature in JS and ObjC land" (#47664) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/47664 We landed the previous change in [4dd60acb7d](https://github.com/facebook/react-native/commit/4dd60acb7ddc2811453e84e3567c1a114fa5e6f9), but this is breaking the OSS CI because now the two signatures do not match ## Changelog: [Internal] - Revert make the prefetchImageWithMetadata's queryRoot nullable Reviewed By: GijsWeterings Differential Revision: D66096759 fbshipit-source-id: b0ce87d82edd63576df7a04c58d5aec3173ad8d6 --- packages/react-native/Libraries/Image/RCTImageLoader.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/Libraries/Image/RCTImageLoader.mm b/packages/react-native/Libraries/Image/RCTImageLoader.mm index 014c22bfd4d..68a12d35122 100644 --- a/packages/react-native/Libraries/Image/RCTImageLoader.mm +++ b/packages/react-native/Libraries/Image/RCTImageLoader.mm @@ -1227,7 +1227,7 @@ RCT_EXPORT_METHOD(prefetchImage RCT_EXPORT_METHOD(prefetchImageWithMetadata : (NSString *)uri queryRootName - : (nullable NSString *)queryRootName rootTag + : (NSString *)queryRootName rootTag : (double)rootTag resolve : (RCTPromiseResolveBlock)resolve reject : (RCTPromiseRejectBlock)reject)