From 5acf7c961687505fdab9399d54b06c5dac0b4351 Mon Sep 17 00:00:00 2001 From: Kevin Gozali Date: Thu, 3 Sep 2020 19:11:04 -0700 Subject: [PATCH] Android Gradle: remove configureondemand property Summary: It looks like this config in gradle.properties caused the :packages:rn-tester:android:app:dependencies task to fail. This was reported here: https://github.com/gradle/gradle/issues/9645#issuecomment-530746758 -- it's likely related to using Kotlin build.gradle.kts? For now comment these out. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D23521954 fbshipit-source-id: 9997f4950d89e5fc57036b05db5518b39d47737b --- gradle.properties | 3 ++- packages/rn-tester/android/app/gradle.properties | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/gradle.properties b/gradle.properties index 9f6c5bf6c1c..f0a3fdf5d79 100644 --- a/gradle.properties +++ b/gradle.properties @@ -1,4 +1,5 @@ -org.gradle.configureondemand=true +# This is causing issue with dependencies task: https://github.com/gradle/gradle/issues/9645#issuecomment-530746758 +# org.gradle.configureondemand=true org.gradle.daemon=true org.gradle.jvmargs=-Xmx4g -XX:MaxPermSize=2048m -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8 org.gradle.parallel=true diff --git a/packages/rn-tester/android/app/gradle.properties b/packages/rn-tester/android/app/gradle.properties index 4ff9751aab7..bba40bc5101 100644 --- a/packages/rn-tester/android/app/gradle.properties +++ b/packages/rn-tester/android/app/gradle.properties @@ -1,5 +1,6 @@ org.gradle.parallel=true -org.gradle.configureondemand=true +# This is causing issue with dependencies task: https://github.com/gradle/gradle/issues/9645#issuecomment-530746758 +# org.gradle.configureondemand=true MYAPP_RELEASE_STORE_FILE=my-release-key.keystore MYAPP_RELEASE_KEY_ALIAS=androiddebugkey MYAPP_RELEASE_STORE_PASSWORD=android