React/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2024-11-21 22:10:14 +00:00
Code Issues Actions 10 Packages Projects Releases Wiki Activity

Internalize TaskCompletionSource class (#47543)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/47543

TaskCompletionSource is public but it shouldn't, in this diff I'm making it intenral

changelog: [Android][Breaking] Reduce visibility of TaskCompletionSource class

Reviewed By: javache

Differential Revision: D65738324

fbshipit-source-id: 61db35a408162c53398b20e45a52f3eb46de1eae
This commit is contained in:
David Vacca 2024-11-11 07:03:00 -08:00 committed by Facebook GitHub Bot
parent a4eb5794cc
commit 4f55161132
2 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/react-native/ReactAndroid/api/ReactAndroid.api
View File

@ -3895,17 +3895,6 @@ public abstract interface class com/facebook/react/runtime/internal/bolts/Task$U
public abstract fun unobservedException (Lcom/facebook/react/runtime/internal/bolts/Task;Lcom/facebook/react/runtime/internal/bolts/UnobservedTaskException;)V
}
public final class com/facebook/react/runtime/internal/bolts/TaskCompletionSource {
public fun <init> ()V
public final fun getTask ()Lcom/facebook/react/runtime/internal/bolts/Task;
public final fun setCancelled ()V
public final fun setError (Ljava/lang/Exception;)V
public final fun setResult (Ljava/lang/Object;)V
public final fun trySetCancelled ()Z
public final fun trySetError (Ljava/lang/Exception;)Z
public final fun trySetResult (Ljava/lang/Object;)Z
}
public final class com/facebook/react/shell/MainPackageConfig {
public fun <init> (Lcom/facebook/imagepipeline/core/ImagePipelineConfig;)V
public final fun getFrescoConfig ()Lcom/facebook/imagepipeline/core/ImagePipelineConfig;

2
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/internal/bolts/TaskCompletionSource.kt
View File

@ -13,7 +13,7 @@ package com.facebook.react.runtime.internal.bolts
* access to the consumer side through the getTask() method while isolating the Task's completion
* mechanisms from the consumer.
*/
public class TaskCompletionSource<TResult>() {
internal class TaskCompletionSource<TResult>() {
/** @return the Task associated with this TaskCompletionSource. */
public val task: Task<TResult> = Task()