mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
c1bbc5d569
In order to adapt to V8 changes regarding storing private properties on Externals, ExternalWrapper objects were introduced in #51149. However, this new code stores the type tag pointer and not the 128-bit value inside. This breaks some pre-existing code that were making temporary tags. It also means that unloading the module will cause existing External objects to have a tag pointer that points nowhere (use-after-free bug). Change ExternalWrapper to store tags by value to fix this regression. PR-URL: https://github.com/nodejs/node/pull/52426 Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> |
||
|---|---|---|
| .. | ||
| binding.gyp | ||
| test_exceptions.c | ||
| test_exceptions.js | ||
| test_null.c | ||
| test_null.h | ||
| test_null.js | ||
| test_object.c | ||
| test.js | ||