mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
eb8a51a35c
Set the default maxBuffer size to 204,800 bytes for execSync, execFileSync, and spawnSync. APIs that return the child output as a string should have non-infinite defaults for maxBuffer sizes to avoid out-of-memory error conditions. A non-infinite default used to be the documented behaviour for all relevant APIs, but the implemented behaviour for execSync, execFileSync and spawnSync was to have no maxBuffer limits. PR-URL: https://github.com/nodejs/node/pull/23027 Refs: https://github.com/nodejs/node/pull/22894 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
53 lines
1.2 KiB
JavaScript
53 lines
1.2 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
|
|
// This test checks that the maxBuffer option for child_process.spawnSync()
|
|
// works as expected.
|
|
|
|
const assert = require('assert');
|
|
const execFileSync = require('child_process').execFileSync;
|
|
const msgOut = 'this is stdout';
|
|
const msgOutBuf = Buffer.from(`${msgOut}\n`);
|
|
|
|
const args = [
|
|
'-e',
|
|
`console.log("${msgOut}");`
|
|
];
|
|
|
|
// Verify that an error is returned if maxBuffer is surpassed.
|
|
{
|
|
assert.throws(
|
|
() => execFileSync(process.execPath, args, { maxBuffer: 1 }),
|
|
(e) => {
|
|
assert.ok(e, 'maxBuffer should error');
|
|
assert.strictEqual(e.errno, 'ENOBUFS');
|
|
assert.deepStrictEqual(e.stdout, msgOutBuf);
|
|
return true;
|
|
}
|
|
);
|
|
}
|
|
|
|
// Verify that a maxBuffer size of Infinity works.
|
|
{
|
|
const ret = execFileSync(process.execPath, args, { maxBuffer: Infinity });
|
|
|
|
assert.deepStrictEqual(ret, msgOutBuf);
|
|
}
|
|
|
|
// maxBuffer size is 200 * 1024 at default.
|
|
{
|
|
assert.throws(
|
|
() => {
|
|
execFileSync(
|
|
process.execPath,
|
|
['-e', "console.log('a'.repeat(200 * 1024))"],
|
|
{ encoding: 'utf-8' }
|
|
);
|
|
}, (e) => {
|
|
assert.ok(e, 'maxBuffer should error');
|
|
assert.strictEqual(e.errno, 'ENOBUFS');
|
|
return true;
|
|
}
|
|
);
|
|
}
|