mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
4bc7025309
Validate encoding passed to write(chunk, encoding, cb) and throw if it is invalid. PR-URL: https://github.com/nodejs/node/pull/33075 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
76 lines
1.4 KiB
JavaScript
76 lines
1.4 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const { Writable } = require('stream');
|
|
|
|
function expectError(w, args, code, sync) {
|
|
if (sync) {
|
|
if (code) {
|
|
assert.throws(() => w.write(...args), { code });
|
|
} else {
|
|
w.write(...args);
|
|
}
|
|
} else {
|
|
let errorCalled = false;
|
|
let ticked = false;
|
|
w.write(...args, common.mustCall((err) => {
|
|
assert.strictEqual(ticked, true);
|
|
assert.strictEqual(errorCalled, false);
|
|
assert.strictEqual(err.code, code);
|
|
}));
|
|
ticked = true;
|
|
w.on('error', common.mustCall((err) => {
|
|
errorCalled = true;
|
|
assert.strictEqual(err.code, code);
|
|
}));
|
|
}
|
|
}
|
|
|
|
function test(autoDestroy) {
|
|
{
|
|
const w = new Writable({
|
|
autoDestroy,
|
|
_write() {}
|
|
});
|
|
w.end();
|
|
expectError(w, ['asd'], 'ERR_STREAM_WRITE_AFTER_END');
|
|
}
|
|
|
|
{
|
|
const w = new Writable({
|
|
autoDestroy,
|
|
_write() {}
|
|
});
|
|
w.destroy();
|
|
}
|
|
|
|
{
|
|
const w = new Writable({
|
|
autoDestroy,
|
|
_write() {}
|
|
});
|
|
expectError(w, [null], 'ERR_STREAM_NULL_VALUES', true);
|
|
}
|
|
|
|
{
|
|
const w = new Writable({
|
|
autoDestroy,
|
|
_write() {}
|
|
});
|
|
expectError(w, [{}], 'ERR_INVALID_ARG_TYPE', true);
|
|
}
|
|
|
|
{
|
|
const w = new Writable({
|
|
decodeStrings: false,
|
|
autoDestroy,
|
|
_write() {}
|
|
});
|
|
expectError(w, ['asd', 'noencoding'], 'ERR_UNKNOWN_ENCODING', true);
|
|
}
|
|
}
|
|
|
|
test(false);
|
|
test(true);
|