mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
74 lines
1.8 KiB
JavaScript
74 lines
1.8 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
const body =
|
|
'<html><head></head><body><h1>this is some data</h2></body></html>';
|
|
const trailerKey = 'test-trailer';
|
|
const trailerValue = 'testing';
|
|
|
|
const server = h2.createServer();
|
|
|
|
// We use the lower-level API here
|
|
server.on('stream', common.mustCall(onStream));
|
|
|
|
function onStream(stream, headers, flags) {
|
|
stream.on('trailers', common.mustCall((headers) => {
|
|
assert.strictEqual(headers[trailerKey], trailerValue);
|
|
stream.end(body);
|
|
}));
|
|
stream.respond({
|
|
'content-type': 'text/html',
|
|
':status': 200
|
|
}, { waitForTrailers: true });
|
|
stream.on('wantTrailers', () => {
|
|
stream.sendTrailers({ [trailerKey]: trailerValue });
|
|
assert.throws(
|
|
() => stream.sendTrailers({}),
|
|
{
|
|
code: 'ERR_HTTP2_TRAILERS_ALREADY_SENT',
|
|
name: 'Error'
|
|
}
|
|
);
|
|
});
|
|
|
|
assert.throws(
|
|
() => stream.sendTrailers({}),
|
|
{
|
|
code: 'ERR_HTTP2_TRAILERS_NOT_READY',
|
|
name: 'Error'
|
|
}
|
|
);
|
|
}
|
|
|
|
server.listen(0);
|
|
|
|
server.on('listening', common.mustCall(function() {
|
|
const client = h2.connect(`http://localhost:${this.address().port}`);
|
|
const req = client.request({ ':path': '/', ':method': 'POST' },
|
|
{ waitForTrailers: true });
|
|
req.on('wantTrailers', () => {
|
|
req.sendTrailers({ [trailerKey]: trailerValue });
|
|
});
|
|
req.on('data', common.mustCall());
|
|
req.on('trailers', common.mustCall((headers) => {
|
|
assert.strictEqual(headers[trailerKey], trailerValue);
|
|
}));
|
|
req.on('close', common.mustCall(() => {
|
|
assert.throws(
|
|
() => req.sendTrailers({}),
|
|
{
|
|
code: 'ERR_HTTP2_INVALID_STREAM',
|
|
name: 'Error'
|
|
}
|
|
);
|
|
server.close();
|
|
client.close();
|
|
}));
|
|
req.end('data');
|
|
|
|
}));
|