node/async_error_sync_main.out at d1eaded0d1f65330116e8d8c7b07a1507bb84a07 - node - Alpaca Bi's Private Git Pepository

Nodejs/node

mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00

Joyee Cheung 757f3f8b2c

process: reduce the number of internal frames in async stack trace

Previously, we call the JS land `runNextTicks` implementation
immediately from JS land after evaluating the main module or the
input, so these synchronous JS call frames would show up in the stack
trace of the async errors, which can be confusing. This patch moves
those calls into C++ so that more of these internal scheduler
implementation details can be hidden and the users can see a cleaner
a cleaner async JS stack trace.

PR-URL: https://github.com/nodejs/node/pull/27392
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

2019-04-28 15:36:28 +08:00

7 lines

256 B

Plaintext

Raw Blame History

 Error: test
     at one (*fixtures*async-error.js:4:9)
     at two (*fixtures*async-error.js:17:9)
     at async three (*fixtures*async-error.js:20:3)
     at async four (*fixtures*async-error.js:24:3)
     at async main (*message*async_error_sync_main.js:7:5)