mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
bff7a46f31
It's likely that anyone using `process.report.getReport()` will be processing the return value thereafter (e.g., filtering fields or redacting secrets). This change eliminates boilerplate by calling `JSON.parse()` on the return value. Also modified the `validateContent()` and `validate()` test helpers in `test/common/report.js` to be somewhat more obvious and helpful. Of note, a report failing validation will now be easier (though still not _easy_) to read when prepended to the stack trace. - Refs: https://github.com/nodejs/diagnostics/issues/315 PR-URL: https://github.com/nodejs/node/pull/28630 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> |
||
|---|---|---|
| .. | ||
| test-report-config.js | ||
| test-report-fatal-error.js | ||
| test-report-getreport.js | ||
| test-report-signal.js | ||
| test-report-uncaught-exception.js | ||
| test-report-uv-handles.js | ||
| test-report-writereport.js | ||
| testcfg.py | ||