mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
35 lines
842 B
JavaScript
35 lines
842 B
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const async_hooks = require('async_hooks');
|
|
const { AsyncResource } = async_hooks;
|
|
const { spawn } = require('child_process');
|
|
|
|
const initHooks = require('./init-hooks');
|
|
|
|
if (process.argv[2] === 'child') {
|
|
initHooks().enable();
|
|
|
|
class Foo extends AsyncResource {
|
|
constructor(type) {
|
|
super(type, async_hooks.executionAsyncId());
|
|
}
|
|
}
|
|
|
|
[null, undefined, 1, Date, {}, []].forEach((i) => {
|
|
assert.throws(() => new Foo(i), {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
});
|
|
});
|
|
|
|
} else {
|
|
const args = process.argv.slice(1).concat('child');
|
|
spawn(process.execPath, args)
|
|
.on('close', common.mustCall((code) => {
|
|
// No error because the type was defaulted
|
|
assert.strictEqual(code, 0);
|
|
}));
|
|
}
|